{"id":817127,"url":"http://patchwork.ozlabs.org/api/patches/817127/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/1506013525-29291-14-git-send-email-allen.lkml@gmail.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1506013525-29291-14-git-send-email-allen.lkml@gmail.com>","list_archive_url":null,"date":"2017-09-21T17:04:34","name":"[13/64] drivers: net: ns83820: use setup_timer() helper.","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"6eaa23c67532682139b442d8d489b185b55f33d1","submitter":{"id":72354,"url":"http://patchwork.ozlabs.org/api/people/72354/?format=json","name":"Allen Pais","email":"allen.lkml@gmail.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1506013525-29291-14-git-send-email-allen.lkml@gmail.com/mbox/","series":[{"id":4448,"url":"http://patchwork.ozlabs.org/api/series/4448/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=4448","date":"2017-09-21T17:04:27","name":"use setup_timer() helper function.","version":1,"mbox":"http://patchwork.ozlabs.org/series/4448/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/817127/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/817127/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"n6WS2ctD\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xykLM0JtDz9s3T\n\tfor ;\n\tFri, 22 Sep 2017 03:36:27 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752146AbdIURHH (ORCPT );\n\tThu, 21 Sep 2017 13:07:07 -0400","from mail-pg0-f66.google.com ([74.125.83.66]:37058 \"EHLO\n\tmail-pg0-f66.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751581AbdIURHF (ORCPT\n\t); Thu, 21 Sep 2017 13:07:05 -0400","by mail-pg0-f66.google.com with SMTP id v5so3736263pgn.4;\n\tThu, 21 Sep 2017 10:07:05 -0700 (PDT)","from localhost.localdomain ([103.42.74.194])\n\tby smtp.gmail.com with ESMTPSA id\n\tp12sm3174090pgn.90.2017.09.21.10.06.58\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tThu, 21 Sep 2017 10:07:03 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=hM8lSRZT71KHfIrgimS7dFW/nUTdbu0zTUhcCRIAKEA=;\n\tb=n6WS2ctDGZ9lfUxsS046+1W2chvUxoUMhE7sEzmDukfyoPBWBtIgPhKlGiHWGUA+i2\n\t2MLK8rWLP8VfNSDjhlYRH0aP4m2EWucJt9lW0E/tt5KCbjBk6KYXx6iSp/c5ut7eW/g0\n\tOwu1McveHtUb/ZrOKtH6+9wxd4EN+ZpEJFTVJexNUAxFnckgUuPDFrmXlq/pw9ano/ak\n\tNh7qrC8szTT1jSbRb760RnuW9e4O7gmBvAjP3U3K0V6f63aoUJNTyfkAwchnsvruwWhw\n\t7qyv8uDlaWdzp9ve37CnTAcwLmsb+FkXbgEyMruI/ttH6QxVvWUIeaFAmrFINsvCMzM6\n\tC3AA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=hM8lSRZT71KHfIrgimS7dFW/nUTdbu0zTUhcCRIAKEA=;\n\tb=dxSI9JE6W3X3BOgyTKpG0I5I47urbflIxWSsJSycwXd7ArsRI/lKlWgsURZoJI0AfX\n\t9abu/4mwn5866O1IQJWv2LkLAeZQvpbemBDTRbBZNFjnNO4YwXei3ref6621wq9o1hkg\n\tdckgT9ZNn3DJrVZHfcBZPj4xVB3pnUngd3dgU0JOQyYz6oCzEo0Wrf+jNJz90VWnwo0G\n\tZ7FxRtLhJZA9+fWN3Ns2D08/tTc8cRf8a8Oerww8DAJo/9dCY6vMCDMaQMXh1SzOi1Qi\n\tf80INRUQuz0oDGfHZeYfYLdVGTqUokzwSKDnBEx72hqonO9e8xyGKBTPkv784qFIzasz\n\thsdw==","X-Gm-Message-State":"AHPjjUjlmwpWpEbdWQU5UDmIvpElGaFk6ICXVqdXBlSxrDJXmn9KVjHB\n\tyVUiZVd/fPXgJqT3Ye8LXqvmuyF1Ex8=","X-Google-Smtp-Source":"AOwi7QAifFu48XNILr/EWdMW4PBODHAGWeXWFxpOBypTN2q9Bewg/ND4BTcd9yQMxst9TG4GerGB1A==","X-Received":"by 10.101.85.68 with SMTP id t4mr6355501pgr.151.1506013624451;\n\tThu, 21 Sep 2017 10:07:04 -0700 (PDT)","From":"Allen Pais ","To":"netdev@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org, m.grzeschik@pengutronix.de,\n\tdmitry.tarnyagin@lockless.no, wg@grandegger.com,\n\tmkl@pengutronix.de, mark.einon@gmail.com, linux@armlinux.org.uk,\n\tpcnet32@frontier.com, f.fainelli@gmail.com,\n\tbcm-kernel-feedback-list@broadcom.com, venza@brownhat.org,\n\tajk@comnets.uni-bremen.de, jes@trained-monkey.org,\n\tromieu@fr.zoreil.com, khc@pm.waw.pl, simon@thekelleys.org.uk,\n\tdavem@davemloft.net, linux-can@vger.kernel.org,\n\tadi-buildroot-devel@lists.sourceforge.net,\n\tAllen Pais ","Subject":"[PATCH 13/64] drivers: net: ns83820: use setup_timer() helper.","Date":"Thu, 21 Sep 2017 22:34:34 +0530","Message-Id":"<1506013525-29291-14-git-send-email-allen.lkml@gmail.com>","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1506013525-29291-1-git-send-email-allen.lkml@gmail.com>","References":"<1506013525-29291-1-git-send-email-allen.lkml@gmail.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Use setup_timer function instead of initializing timer with the\n function and data fields.\n\nSigned-off-by: Allen Pais \n---\n drivers/net/ethernet/natsemi/ns83820.c | 4 +---\n 1 file changed, 1 insertion(+), 3 deletions(-)","diff":"diff --git a/drivers/net/ethernet/natsemi/ns83820.c b/drivers/net/ethernet/natsemi/ns83820.c\nindex 729095d..99d3c78 100644\n--- a/drivers/net/ethernet/natsemi/ns83820.c\n+++ b/drivers/net/ethernet/natsemi/ns83820.c\n@@ -1652,9 +1652,7 @@ static int ns83820_open(struct net_device *ndev)\n \twritel(0, dev->base + TXDP_HI);\n \twritel(desc, dev->base + TXDP);\n \n-\tinit_timer(&dev->tx_watchdog);\n-\tdev->tx_watchdog.data = (unsigned long)ndev;\n-\tdev->tx_watchdog.function = ns83820_tx_watch;\n+\tsetup_timer(&dev->tx_watchdog, ns83820_tx_watch, (unsigned long)ndev);\n \tmod_timer(&dev->tx_watchdog, jiffies + 2*HZ);\n \n \tnetif_start_queue(ndev);\t/* FIXME: wait for phy to come up */\n","prefixes":["13/64"]}