{"id":817125,"url":"http://patchwork.ozlabs.org/api/patches/817125/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/1506013525-29291-16-git-send-email-allen.lkml@gmail.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1506013525-29291-16-git-send-email-allen.lkml@gmail.com>","list_archive_url":null,"date":"2017-09-21T17:04:36","name":"[15/64] drivers: net: sundance: use setup_timer() helper.","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"a8e63d94b0d7168dc42a664a84d01f8d73ed65e3","submitter":{"id":72354,"url":"http://patchwork.ozlabs.org/api/people/72354/?format=json","name":"Allen Pais","email":"allen.lkml@gmail.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1506013525-29291-16-git-send-email-allen.lkml@gmail.com/mbox/","series":[{"id":4448,"url":"http://patchwork.ozlabs.org/api/series/4448/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=4448","date":"2017-09-21T17:04:27","name":"use setup_timer() helper function.","version":1,"mbox":"http://patchwork.ozlabs.org/series/4448/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/817125/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/817125/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Pqztl6OV\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xykJz0sjdz9s3T\n\tfor ;\n\tFri, 22 Sep 2017 03:35:15 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752190AbdIURHV (ORCPT );\n\tThu, 21 Sep 2017 13:07:21 -0400","from mail-pf0-f194.google.com ([209.85.192.194]:33558 \"EHLO\n\tmail-pf0-f194.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751581AbdIURHS (ORCPT\n\t); Thu, 21 Sep 2017 13:07:18 -0400","by mail-pf0-f194.google.com with SMTP id h4so2724478pfk.0;\n\tThu, 21 Sep 2017 10:07:18 -0700 (PDT)","from localhost.localdomain ([103.42.74.194])\n\tby smtp.gmail.com with ESMTPSA id\n\tp12sm3174090pgn.90.2017.09.21.10.07.10\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tThu, 21 Sep 2017 10:07:15 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=UfgokdY8FYzGDdi0UdCFHeiXPeG/382kE3Jkd6AFapw=;\n\tb=Pqztl6OVST/yMxFXFzYETqFe+z5BDlbIKNlmbT3M45FskUOTwA6Qebq5Di2cSKJoXd\n\tlzonUnQOidYsg7y+8JxqznMQ8JFYnUcW4WpWiutUb+HMQPLVdsygqWCiIX7Db1rFcymo\n\t/nGBSvTa9Hj15k26/4a48CqrqIjo1Wab+8r73Dyc8eYrsIaxdAVDUFvh2hfFcFLbwdnB\n\tEuDh7dKqKsiKmsQejeS+x+EvnmUzDXT0Fv+fXTr6CfPhZUBalecHE9EeiXs3C4MG92JF\n\tAuhSlubNWnYV9YhpozTNzSTsz0zoM+GJyGJSWmDP4NfOsHD4iP6X2sM/FSr0hueI+Ke8\n\t34gA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=UfgokdY8FYzGDdi0UdCFHeiXPeG/382kE3Jkd6AFapw=;\n\tb=nP9JYB8edaZ4TxuPyZwMw2yvVdea6rVB1WOImhnFnG4F64aMmHZs2DdEsKEoO2JXRY\n\t8ODt7v51dtITiNAku6b2/3WD3Zygr4N+Rm6HSXkqb60GMAi5l6T3PPoUfZtx5uF+UsH3\n\tL++53Wr1cX/i4/Ew1i5aiBICGmoS8y5nibUr5WtGhpVSq//mKm50/uzcPf8jj6u0OWob\n\t3kRw4aEUO/rRqpMbJ7MMhx4gGOajuX/DkJAvgzZBeAUzcDyMe/b/PZvNFkCbP9s8/cGl\n\tHJxCGGsVLokLfjfYhZrbFUpX9UqVMOc4c9DIBs3ITC50+1AbjwI5EbDMhOb9qcdzEOh9\n\tpoSg==","X-Gm-Message-State":"AHPjjUjkGJQrcYV+fP3WTDsKMvk4Y/tOaIqxPv8tC/qoxMMwWW4FCo3i\n\tbmDmQVmWBTv8wpgkM8NAbNj+Mlhw58M=","X-Google-Smtp-Source":"AOwi7QArk7t1/FbsISc5TYkr4UUnapL1bLFrDSygv7sMhMRNb7icbQPjkN1VnKSwL7aTtGhJMxpRvA==","X-Received":"by 10.98.7.212 with SMTP id 81mr6220537pfh.146.1506013637362;\n\tThu, 21 Sep 2017 10:07:17 -0700 (PDT)","From":"Allen Pais ","To":"netdev@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org, m.grzeschik@pengutronix.de,\n\tdmitry.tarnyagin@lockless.no, wg@grandegger.com,\n\tmkl@pengutronix.de, mark.einon@gmail.com, linux@armlinux.org.uk,\n\tpcnet32@frontier.com, f.fainelli@gmail.com,\n\tbcm-kernel-feedback-list@broadcom.com, venza@brownhat.org,\n\tajk@comnets.uni-bremen.de, jes@trained-monkey.org,\n\tromieu@fr.zoreil.com, khc@pm.waw.pl, simon@thekelleys.org.uk,\n\tdavem@davemloft.net, linux-can@vger.kernel.org,\n\tadi-buildroot-devel@lists.sourceforge.net,\n\tAllen Pais ","Subject":"[PATCH 15/64] drivers: net: sundance: use setup_timer() helper.","Date":"Thu, 21 Sep 2017 22:34:36 +0530","Message-Id":"<1506013525-29291-16-git-send-email-allen.lkml@gmail.com>","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1506013525-29291-1-git-send-email-allen.lkml@gmail.com>","References":"<1506013525-29291-1-git-send-email-allen.lkml@gmail.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Use setup_timer function instead of initializing timer with the\n function and data fields.\n\nSigned-off-by: Allen Pais \n---\n drivers/net/ethernet/dlink/sundance.c | 4 +---\n 1 file changed, 1 insertion(+), 3 deletions(-)","diff":"diff --git a/drivers/net/ethernet/dlink/sundance.c b/drivers/net/ethernet/dlink/sundance.c\nindex 2704bcf..6ca9e98 100644\n--- a/drivers/net/ethernet/dlink/sundance.c\n+++ b/drivers/net/ethernet/dlink/sundance.c\n@@ -913,10 +913,8 @@ static int netdev_open(struct net_device *dev)\n \t\t\t ioread16(ioaddr + MACCtrl1), ioread16(ioaddr + MACCtrl0));\n \n \t/* Set the timer to check for link beat. */\n-\tinit_timer(&np->timer);\n+\tsetup_timer(&np->timer, netdev_timer, (unsigned long)dev);\n \tnp->timer.expires = jiffies + 3*HZ;\n-\tnp->timer.data = (unsigned long)dev;\n-\tnp->timer.function = netdev_timer;\t\t\t\t/* timer handler */\n \tadd_timer(&np->timer);\n \n \t/* Enable interrupts by setting the interrupt mask. */\n","prefixes":["15/64"]}