{"id":817122,"url":"http://patchwork.ozlabs.org/api/patches/817122/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/1506013525-29291-19-git-send-email-allen.lkml@gmail.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1506013525-29291-19-git-send-email-allen.lkml@gmail.com>","list_archive_url":null,"date":"2017-09-21T17:04:39","name":"[18/64] drivers: net: cisco_hdlc: use setup_timer() helper.","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"1e86ea81829e486506f1f68b03688127a4ddcfa6","submitter":{"id":72354,"url":"http://patchwork.ozlabs.org/api/people/72354/?format=json","name":"Allen Pais","email":"allen.lkml@gmail.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1506013525-29291-19-git-send-email-allen.lkml@gmail.com/mbox/","series":[{"id":4448,"url":"http://patchwork.ozlabs.org/api/series/4448/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=4448","date":"2017-09-21T17:04:27","name":"use setup_timer() helper function.","version":1,"mbox":"http://patchwork.ozlabs.org/series/4448/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/817122/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/817122/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"IVvht6ya\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xykJC4LF6z9s3T\n\tfor ;\n\tFri, 22 Sep 2017 03:34:35 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752270AbdIURHk (ORCPT );\n\tThu, 21 Sep 2017 13:07:40 -0400","from mail-pg0-f67.google.com ([74.125.83.67]:34098 \"EHLO\n\tmail-pg0-f67.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752237AbdIURHg (ORCPT\n\t); Thu, 21 Sep 2017 13:07:36 -0400","by mail-pg0-f67.google.com with SMTP id u18so3752527pgo.1;\n\tThu, 21 Sep 2017 10:07:36 -0700 (PDT)","from localhost.localdomain ([103.42.74.194])\n\tby smtp.gmail.com with ESMTPSA id\n\tp12sm3174090pgn.90.2017.09.21.10.07.29\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tThu, 21 Sep 2017 10:07:34 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=txH9ta4dkIto1DeJBta9Cl7/NPIypD5DwvHU9mXdMg0=;\n\tb=IVvht6yasbD2jJ6aNc3jWQue+pLcv/zwgo9U0oyraS9JDtB6LdLazWoik3gcQz7sOC\n\t+3uJTZjiMOqnVH8OAUZKpKiWqK/hd4HbVLmNX5lmPCjY9NCwHr/K5ReuoQqt5NitSanm\n\tYXlas3RIv+elObLbkdvdDD9Q1xGF6p0OvHVvhFOmuhOBh4Mp1iY2RJ/jMT3OlmLYPcz5\n\tje07sLLu81DFoiYZKoIeRLw1pDtlaimlMWIRlQxh8pK7y0htMQ9IENfpRzp/sl7WDATF\n\ter5b2qFPqQa0mZIOOkGpW0B9WYlPfowy3t/i8p7rM8lRfssvoYtekHjSODiBoSkPD4uS\n\tcL6g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=txH9ta4dkIto1DeJBta9Cl7/NPIypD5DwvHU9mXdMg0=;\n\tb=nRXbb+GhKVR7oGtxyiFXb+TAdSBfp74YeEWxgNH+1sZ4KUxjPNgnEFWciTKPeKP1vj\n\tyXogRrtFrBKqLt2SSpu5GoySZoq4GlAEZhreo2faaJJMC6tEsUTaApt0wgoIjZXdP3ss\n\tlBfnOkOqvbsK54UsQ028zMTz0gdrNcWlYDu4AWiATJVf/vM0DOdBRV1cFDfY6vZiNiDo\n\t05qBs0LoaX07D4u+XuinxqFxiz8rSN1YsDpnn3OwNg68QqSQmWyjz+wwDlhBWRA1hea4\n\t27ZejyH8NUOszEkUIoNdYQlJXBnpacV+HwF/uz6i6FCtGaL9+xQ4JDl/Qwzvys2oe7s1\n\tjz0w==","X-Gm-Message-State":"AHPjjUgy3RuaTzw+VnzlKFnfCQiX/W2quOxhJAOHhk8lVy7QynufPoVw\n\tmlQtTsTDr6hlhcfSrh97QIx0yh2N","X-Google-Smtp-Source":"AOwi7QAYGAN76T7YJEJIdmeyAGfFj1jc/oESkollCGwuBF3GTVsvlO1b7WIdNUMPh/Lq2d3wvnzy2g==","X-Received":"by 10.98.209.9 with SMTP id z9mr6270536pfg.283.1506013656010;\n\tThu, 21 Sep 2017 10:07:36 -0700 (PDT)","From":"Allen Pais ","To":"netdev@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org, m.grzeschik@pengutronix.de,\n\tdmitry.tarnyagin@lockless.no, wg@grandegger.com,\n\tmkl@pengutronix.de, mark.einon@gmail.com, linux@armlinux.org.uk,\n\tpcnet32@frontier.com, f.fainelli@gmail.com,\n\tbcm-kernel-feedback-list@broadcom.com, venza@brownhat.org,\n\tajk@comnets.uni-bremen.de, jes@trained-monkey.org,\n\tromieu@fr.zoreil.com, khc@pm.waw.pl, simon@thekelleys.org.uk,\n\tdavem@davemloft.net, linux-can@vger.kernel.org,\n\tadi-buildroot-devel@lists.sourceforge.net,\n\tAllen Pais ","Subject":"[PATCH 18/64] drivers: net: cisco_hdlc: use setup_timer() helper.","Date":"Thu, 21 Sep 2017 22:34:39 +0530","Message-Id":"<1506013525-29291-19-git-send-email-allen.lkml@gmail.com>","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1506013525-29291-1-git-send-email-allen.lkml@gmail.com>","References":"<1506013525-29291-1-git-send-email-allen.lkml@gmail.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Use setup_timer function instead of initializing timer with the\n function and data fields.\n\nSigned-off-by: Allen Pais \n---\n drivers/net/wan/hdlc_cisco.c | 4 +---\n 1 file changed, 1 insertion(+), 3 deletions(-)","diff":"diff --git a/drivers/net/wan/hdlc_cisco.c b/drivers/net/wan/hdlc_cisco.c\nindex a408abc..c696d42 100644\n--- a/drivers/net/wan/hdlc_cisco.c\n+++ b/drivers/net/wan/hdlc_cisco.c\n@@ -293,10 +293,8 @@ static void cisco_start(struct net_device *dev)\n \tst->up = st->txseq = st->rxseq = 0;\n \tspin_unlock_irqrestore(&st->lock, flags);\n \n-\tinit_timer(&st->timer);\n+\tsetup_timer(&st->timer, cisco_timer, (unsigned long)dev);\n \tst->timer.expires = jiffies + HZ; /* First poll after 1 s */\n-\tst->timer.function = cisco_timer;\n-\tst->timer.data = (unsigned long)dev;\n \tadd_timer(&st->timer);\n }\n \n","prefixes":["18/64"]}