{"id":817120,"url":"http://patchwork.ozlabs.org/api/patches/817120/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/1506013525-29291-21-git-send-email-allen.lkml@gmail.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1506013525-29291-21-git-send-email-allen.lkml@gmail.com>","list_archive_url":null,"date":"2017-09-21T17:04:41","name":"[20/64] drivers: net: spider_net: use setup_timer() helper.","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"4af5899ac26b8735c4b64086c6b2bddd4df31cd3","submitter":{"id":72354,"url":"http://patchwork.ozlabs.org/api/people/72354/?format=json","name":"Allen Pais","email":"allen.lkml@gmail.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1506013525-29291-21-git-send-email-allen.lkml@gmail.com/mbox/","series":[{"id":4448,"url":"http://patchwork.ozlabs.org/api/series/4448/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=4448","date":"2017-09-21T17:04:27","name":"use setup_timer() helper function.","version":1,"mbox":"http://patchwork.ozlabs.org/series/4448/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/817120/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/817120/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"od03nSiz\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xykHj2nBNz9sRq\n\tfor ;\n\tFri, 22 Sep 2017 03:34:09 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752326AbdIURHx (ORCPT );\n\tThu, 21 Sep 2017 13:07:53 -0400","from mail-pg0-f68.google.com ([74.125.83.68]:35804 \"EHLO\n\tmail-pg0-f68.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752315AbdIURHt (ORCPT\n\t); Thu, 21 Sep 2017 13:07:49 -0400","by mail-pg0-f68.google.com with SMTP id j16so3745548pga.2;\n\tThu, 21 Sep 2017 10:07:49 -0700 (PDT)","from localhost.localdomain ([103.42.74.194])\n\tby smtp.gmail.com with ESMTPSA id\n\tp12sm3174090pgn.90.2017.09.21.10.07.42\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tThu, 21 Sep 2017 10:07:47 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=+X6u/MZvC0NFZBtXKVndxVVWCAZA4TX45gX4zKrXDLg=;\n\tb=od03nSizMvMybtYpQfY6Zr1A/Vb8kl0uVtW6/iIcCJVzxs495GKgdNdJE7UINd6eUj\n\tUPq41K0EDzcz6Vu+be+2aJZJ5sAdWyHGgZ+BxCYSzsRYeXEqICmKfmZsLWCatQBTuPfO\n\tLCb95ka1/HqTkd3EDvU1gkK7OxjeOqusOwTebQWsTOmdMj9Mpa6ELQOEND8OtI/mWX30\n\tcw+WbN5ylHXmsnbZz35lcS3Bbym7tMmQX5H9Thy3GcJheK+bkciJptsWfhNkYAOajfgp\n\t9jD4dGL93cCYXjfQ6iXYfUMrrrka6hB6hOVpOag02hdPHaTg9K2XjtuzJYND7Kzwncq6\n\tCCuA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=+X6u/MZvC0NFZBtXKVndxVVWCAZA4TX45gX4zKrXDLg=;\n\tb=q3tiSfrA5jhuOMv9FCED0ckH88S9bNdHL8EiUppyNxJKAj2789fbAw4wEaF6QjrRzt\n\tA+UcYbFnIMXRmmtECX7AaPru98Ln9Yxnk8/FUXF2a2kc0A75Ikg1fPd5K54h8aftPh7u\n\tVgaEiMKr5LhpDur4TxPln17LPS+Xd1GM9Uqq7pKggMjYnkrevzZ1wS2uJt/c9XBe40uO\n\tC52Cv61A2a/aPQZciW97dmOggHUJWBNCL9R0f8Lqmz2YB0A4DqdBW/qsI6qXMywhfPY2\n\tIRBsoc7hNYR3lnhx93ddJZZJNL2e5wAm9ca9YcW9xZ87UDeT6JR+BZN/Tt1koudcBgEn\n\trmxw==","X-Gm-Message-State":"AHPjjUgx2x10Ps4/cX67nEpIsKl4BLajpT2o24Xh+9RLsaWQttMjkUBX\n\t2M4hfWwqpG7TapN0HI+r5CTgbG8U","X-Google-Smtp-Source":"AOwi7QDntqlm92P2vBtsycWEIPVbDEGaqwVs3s57FEozKBdQcuDIFAfIb+JVr2uesTW6DtciASu9zw==","X-Received":"by 10.84.133.6 with SMTP id 6mr6047844plf.61.1506013668859;\n\tThu, 21 Sep 2017 10:07:48 -0700 (PDT)","From":"Allen Pais ","To":"netdev@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org, m.grzeschik@pengutronix.de,\n\tdmitry.tarnyagin@lockless.no, wg@grandegger.com,\n\tmkl@pengutronix.de, mark.einon@gmail.com, linux@armlinux.org.uk,\n\tpcnet32@frontier.com, f.fainelli@gmail.com,\n\tbcm-kernel-feedback-list@broadcom.com, venza@brownhat.org,\n\tajk@comnets.uni-bremen.de, jes@trained-monkey.org,\n\tromieu@fr.zoreil.com, khc@pm.waw.pl, simon@thekelleys.org.uk,\n\tdavem@davemloft.net, linux-can@vger.kernel.org,\n\tadi-buildroot-devel@lists.sourceforge.net,\n\tAllen Pais ","Subject":"[PATCH 20/64] drivers: net: spider_net: use setup_timer() helper.","Date":"Thu, 21 Sep 2017 22:34:41 +0530","Message-Id":"<1506013525-29291-21-git-send-email-allen.lkml@gmail.com>","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1506013525-29291-1-git-send-email-allen.lkml@gmail.com>","References":"<1506013525-29291-1-git-send-email-allen.lkml@gmail.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Use setup_timer function instead of initializing timer with the\n function and data fields.\n\nSigned-off-by: Allen Pais \n---\n drivers/net/ethernet/toshiba/spider_net.c | 12 +++++-------\n 1 file changed, 5 insertions(+), 7 deletions(-)","diff":"diff --git a/drivers/net/ethernet/toshiba/spider_net.c b/drivers/net/ethernet/toshiba/spider_net.c\nindex cec9e70..a913538 100644\n--- a/drivers/net/ethernet/toshiba/spider_net.c\n+++ b/drivers/net/ethernet/toshiba/spider_net.c\n@@ -2256,16 +2256,14 @@ spider_net_setup_netdev(struct spider_net_card *card)\n \n \tpci_set_drvdata(card->pdev, netdev);\n \n-\tinit_timer(&card->tx_timer);\n-\tcard->tx_timer.function =\n-\t\t(void (*)(unsigned long)) spider_net_cleanup_tx_ring;\n-\tcard->tx_timer.data = (unsigned long) card;\n+\tsetup_timer(&card->tx_timer,\n+\t\t (void(*)(unsigned long))spider_net_cleanup_tx_ring,\n+\t\t (unsigned long)card);\n \tnetdev->irq = card->pdev->irq;\n \n \tcard->aneg_count = 0;\n-\tinit_timer(&card->aneg_timer);\n-\tcard->aneg_timer.function = spider_net_link_phy;\n-\tcard->aneg_timer.data = (unsigned long) card;\n+\tsetup_timer(&card->aneg_timer, spider_net_link_phy,\n+\t\t (unsigned long)card);\n \n \tnetif_napi_add(netdev, &card->napi,\n \t\t spider_net_poll, SPIDER_NET_NAPI_WEIGHT);\n","prefixes":["20/64"]}