{"id":817116,"url":"http://patchwork.ozlabs.org/api/patches/817116/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/1506013525-29291-25-git-send-email-allen.lkml@gmail.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1506013525-29291-25-git-send-email-allen.lkml@gmail.com>","list_archive_url":null,"date":"2017-09-21T17:04:45","name":"[24/64] drivers: net: enic: use setup_timer() helper.","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"278652af388da7bed8a21fe076b9b378ea103b7d","submitter":{"id":72354,"url":"http://patchwork.ozlabs.org/api/people/72354/?format=json","name":"Allen Pais","email":"allen.lkml@gmail.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1506013525-29291-25-git-send-email-allen.lkml@gmail.com/mbox/","series":[{"id":4448,"url":"http://patchwork.ozlabs.org/api/series/4448/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=4448","date":"2017-09-21T17:04:27","name":"use setup_timer() helper function.","version":1,"mbox":"http://patchwork.ozlabs.org/series/4448/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/817116/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/817116/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"TsihKjph\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xykFy4gZ7z9s3T\n\tfor ;\n\tFri, 22 Sep 2017 03:32:38 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752439AbdIURIR (ORCPT );\n\tThu, 21 Sep 2017 13:08:17 -0400","from mail-pf0-f193.google.com ([209.85.192.193]:34636 \"EHLO\n\tmail-pf0-f193.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752427AbdIURIO (ORCPT\n\t); Thu, 21 Sep 2017 13:08:14 -0400","by mail-pf0-f193.google.com with SMTP id g65so2721823pfe.1;\n\tThu, 21 Sep 2017 10:08:14 -0700 (PDT)","from localhost.localdomain ([103.42.74.194])\n\tby smtp.gmail.com with ESMTPSA id\n\tp12sm3174090pgn.90.2017.09.21.10.08.07\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tThu, 21 Sep 2017 10:08:12 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=/VPj6YvMv7uCo7Nd9bgIBhR2TRv9i77kfeCYmjiy00k=;\n\tb=TsihKjph8rff+dFKuwssgoT39D2Za4RV6Lp0clZnYqNE81QiVLlvAaREmgL/TARIht\n\tA5cjdAvmGsC1LGX9pYrUxWdxtW/NxbU9uUVXiZd4XYnZRlwy+8GS0UJMo8h5fBy6Y6MN\n\tw+P7v949A6oHgSWAU8HWpNi5asvPkVz+wC2ZueLnScIP7rqfk2xWBJb9dF4krV5igD84\n\tnymLMyvau1cHA7cOV8sRERoLrNXSsGnfoke9hB/y12WI9rKLCQUuGMiSpAr3uhMk9dLO\n\tJGB3IXY35/U1sr904RrO+pf6yk/vzxDuOkp/Qam9bUdtXcJJNaySRV1Xco/xmzCDFN56\n\tjaEw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=/VPj6YvMv7uCo7Nd9bgIBhR2TRv9i77kfeCYmjiy00k=;\n\tb=cbLK9pKisIiSkZf8dWicfCZufdnXMShc2CC+xwjJQBvgvJ1x12eXKLfaIWgt/w63t3\n\tNuUgLwRme4WQ+6SmmY0SeFQOx2jZiwx/dwto92DKanr+2UJwSoxeFn6Q2xcofDmJcBJJ\n\tF7t8Csq5qET/AwMqWAbIpPfK9/cvRB2+WuL1k9kIHFc6mS8zEgfn+fEDm2jULy6cZn6D\n\tfvuGAPHrq/kh90LR1zt+tmmcFFD7rBOpS+8oxWQcjXRT+Baz4DnEX2lePEZR3hDLulG1\n\t54yWhdViF8+EQz8mCVDAOOr4pA9v1P+QFIb4NShvUVneoO+rhF/gcLUeSqXsj8bmy0oy\n\tPoSA==","X-Gm-Message-State":"AHPjjUhpawsu3v4w/WxWxtnBQcitBj+MYl8n71+jU0tTofNYvDIcMWR+\n\t77U1IutUn2jsah8OJW5GwXmCqCT3","X-Google-Smtp-Source":"AOwi7QA1oRiyWzzSq6CECF75fXHlGUL79yyZPOyp8yS0UEeNVnN25MC5OJ5iFw/oZCmrzRbVyi5DWg==","X-Received":"by 10.159.204.147 with SMTP id t19mr6190936plo.242.1506013693652;\n\tThu, 21 Sep 2017 10:08:13 -0700 (PDT)","From":"Allen Pais ","To":"netdev@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org, m.grzeschik@pengutronix.de,\n\tdmitry.tarnyagin@lockless.no, wg@grandegger.com,\n\tmkl@pengutronix.de, mark.einon@gmail.com, linux@armlinux.org.uk,\n\tpcnet32@frontier.com, f.fainelli@gmail.com,\n\tbcm-kernel-feedback-list@broadcom.com, venza@brownhat.org,\n\tajk@comnets.uni-bremen.de, jes@trained-monkey.org,\n\tromieu@fr.zoreil.com, khc@pm.waw.pl, simon@thekelleys.org.uk,\n\tdavem@davemloft.net, linux-can@vger.kernel.org,\n\tadi-buildroot-devel@lists.sourceforge.net,\n\tAllen Pais ","Subject":"[PATCH 24/64] drivers: net: enic: use setup_timer() helper.","Date":"Thu, 21 Sep 2017 22:34:45 +0530","Message-Id":"<1506013525-29291-25-git-send-email-allen.lkml@gmail.com>","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1506013525-29291-1-git-send-email-allen.lkml@gmail.com>","References":"<1506013525-29291-1-git-send-email-allen.lkml@gmail.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Use setup_timer function instead of initializing timer with the\n function and data fields.\n\nSigned-off-by: Allen Pais \n---\n drivers/net/ethernet/cisco/enic/enic_main.c | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)","diff":"diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net/ethernet/cisco/enic/enic_main.c\nindex d24ee1a..4a11baf 100644\n--- a/drivers/net/ethernet/cisco/enic/enic_main.c\n+++ b/drivers/net/ethernet/cisco/enic/enic_main.c\n@@ -2846,9 +2846,8 @@ static int enic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)\n \t/* Setup notification timer, HW reset task, and wq locks\n \t */\n \n-\tinit_timer(&enic->notify_timer);\n-\tenic->notify_timer.function = enic_notify_timer;\n-\tenic->notify_timer.data = (unsigned long)enic;\n+\tsetup_timer(&enic->notify_timer, enic_notify_timer,\n+\t\t (unsigned long)enic);\n \n \tenic_set_rx_coal_setting(enic);\n \tINIT_WORK(&enic->reset, enic_reset);\n","prefixes":["24/64"]}