{"id":817110,"url":"http://patchwork.ozlabs.org/api/patches/817110/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/1506013525-29291-32-git-send-email-allen.lkml@gmail.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1506013525-29291-32-git-send-email-allen.lkml@gmail.com>","list_archive_url":null,"date":"2017-09-21T17:04:52","name":"[31/64] drivers: net: e1000e: use setup_timer() helper.","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"09131044b3737919bdf4bf41a2433d3a24cae33c","submitter":{"id":72354,"url":"http://patchwork.ozlabs.org/api/people/72354/?format=json","name":"Allen Pais","email":"allen.lkml@gmail.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1506013525-29291-32-git-send-email-allen.lkml@gmail.com/mbox/","series":[{"id":4448,"url":"http://patchwork.ozlabs.org/api/series/4448/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=4448","date":"2017-09-21T17:04:27","name":"use setup_timer() helper function.","version":1,"mbox":"http://patchwork.ozlabs.org/series/4448/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/817110/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/817110/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Zl+5md90\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xykCX1N3vz9sRq\n\tfor ;\n\tFri, 22 Sep 2017 03:30:32 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752598AbdIURJD (ORCPT );\n\tThu, 21 Sep 2017 13:09:03 -0400","from mail-pf0-f196.google.com ([209.85.192.196]:38653 \"EHLO\n\tmail-pf0-f196.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751826AbdIURI7 (ORCPT\n\t); Thu, 21 Sep 2017 13:08:59 -0400","by mail-pf0-f196.google.com with SMTP id a7so2714185pfj.5;\n\tThu, 21 Sep 2017 10:08:59 -0700 (PDT)","from localhost.localdomain ([103.42.74.194])\n\tby smtp.gmail.com with ESMTPSA id\n\tp12sm3174090pgn.90.2017.09.21.10.08.51\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tThu, 21 Sep 2017 10:08:57 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=31SIwNCUTaCSyrpi68N+5aFo2mPHJKK+q7mKp+LAQq4=;\n\tb=Zl+5md90F8R4rFSgfhfUg4jDOl2tL0lcxfXvjD7bFxyBh1wk2mszzxaqSBtDWyToH/\n\tgWEMCzu50mU/0DwtUXnTISr3KipBGEsp7NEr+c28I0usKB9uLZ+tmwmSwwWAIKLCsUjK\n\tsAvP8Wol0Wsnhce1eXY/alFgZGU/uJ+eN3ema96HJVhXj0bmtFAAJFQeBZj41VVoC6sQ\n\tLrb23W26IOirG0uftglGDRP3L0/3uYrOw+2CYduteCQYpsJe3DZ/hi2Gp9nw3vovHNHI\n\tRDUyVIt0D9f8iNK9frVW0lGnpKLYI8dYFGUNdmw6T4X96mXvApgOWh8F4AGgxmxz4DC4\n\tH5Lg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=31SIwNCUTaCSyrpi68N+5aFo2mPHJKK+q7mKp+LAQq4=;\n\tb=kQagb2MG6I6Tj8j5808yCDZx4ZYghFt8Uy87e7ZpKLmf/7HNrqzlkMGI2mHiLp/GDN\n\tiwNqQox8OpQHg08N2BiuoiffIuAFyI+4WJ2xLkHtvZvlev356g8TBWwnlC5uj5Wgpigx\n\tQ2HItW3aRu4t4+sDOFzLd2LI6snNHC+I6/W5oa49OtkJaHV/RhPUYa/d3ABwddK1jPF3\n\tqcivm+FqdKUpSiKQN1VY87qazbY3bwUaEBpQq0ZpJseIQDtPiJXl4OrvmF13WLEztGC8\n\tKsJ9+XCTLN37ooNjMVVR5In0hdwR3PIIIE7WScLbL4R0bR6iXAX8MxtgtLS9QL/Pdkx8\n\t3FEw==","X-Gm-Message-State":"AHPjjUhbF9gdZHitjnHBphslhgXdlrEJ9DQIyGBVNgRHt3dVn8fAdRuM\n\tPQkJdg40wMqd3LRk+XrWeXBGTVaM","X-Google-Smtp-Source":"AOwi7QA9LEftRjnoveub1t9A8zg1gh1aO/fXiq9ZFj0r9O3s2Udt97OfgsbjciM4nIry9c4+EiviTA==","X-Received":"by 10.99.126.84 with SMTP id o20mr6412502pgn.133.1506013738529; \n\tThu, 21 Sep 2017 10:08:58 -0700 (PDT)","From":"Allen Pais ","To":"netdev@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org, m.grzeschik@pengutronix.de,\n\tdmitry.tarnyagin@lockless.no, wg@grandegger.com,\n\tmkl@pengutronix.de, mark.einon@gmail.com, linux@armlinux.org.uk,\n\tpcnet32@frontier.com, f.fainelli@gmail.com,\n\tbcm-kernel-feedback-list@broadcom.com, venza@brownhat.org,\n\tajk@comnets.uni-bremen.de, jes@trained-monkey.org,\n\tromieu@fr.zoreil.com, khc@pm.waw.pl, simon@thekelleys.org.uk,\n\tdavem@davemloft.net, linux-can@vger.kernel.org,\n\tadi-buildroot-devel@lists.sourceforge.net,\n\tAllen Pais ","Subject":"[PATCH 31/64] drivers: net: e1000e: use setup_timer() helper.","Date":"Thu, 21 Sep 2017 22:34:52 +0530","Message-Id":"<1506013525-29291-32-git-send-email-allen.lkml@gmail.com>","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1506013525-29291-1-git-send-email-allen.lkml@gmail.com>","References":"<1506013525-29291-1-git-send-email-allen.lkml@gmail.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Use setup_timer function instead of initializing timer with the\n function and data fields.\n\nSigned-off-by: Allen Pais \n---\n drivers/net/ethernet/intel/e1000e/netdev.c | 11 ++++-------\n 1 file changed, 4 insertions(+), 7 deletions(-)","diff":"diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c\nindex 327dfe5..8436c5f 100644\n--- a/drivers/net/ethernet/intel/e1000e/netdev.c\n+++ b/drivers/net/ethernet/intel/e1000e/netdev.c\n@@ -7252,13 +7252,10 @@ static int e1000_probe(struct pci_dev *pdev, const struct pci_device_id *ent)\n \t\tgoto err_eeprom;\n \t}\n \n-\tinit_timer(&adapter->watchdog_timer);\n-\tadapter->watchdog_timer.function = e1000_watchdog;\n-\tadapter->watchdog_timer.data = (unsigned long)adapter;\n-\n-\tinit_timer(&adapter->phy_info_timer);\n-\tadapter->phy_info_timer.function = e1000_update_phy_info;\n-\tadapter->phy_info_timer.data = (unsigned long)adapter;\n+\tsetup_timer(&adapter->watchdog_timer, e1000_watchdog,\n+\t\t (unsigned long)adapter);\n+\tsetup_timer(&adapter->phy_info_timer, e1000_update_phy_info,\n+\t\t (unsigned long)adapter);\n \n \tINIT_WORK(&adapter->reset_task, e1000_reset_task);\n \tINIT_WORK(&adapter->watchdog_task, e1000_watchdog_task);\n","prefixes":["31/64"]}