{"id":817109,"url":"http://patchwork.ozlabs.org/api/patches/817109/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/1506013525-29291-33-git-send-email-allen.lkml@gmail.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1506013525-29291-33-git-send-email-allen.lkml@gmail.com>","list_archive_url":null,"date":"2017-09-21T17:04:53","name":"[32/64] drivers: net: amd: use setup_timer() helper.","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"309fcd63676a55bfcfd142579b73253e0d6c6175","submitter":{"id":72354,"url":"http://patchwork.ozlabs.org/api/people/72354/?format=json","name":"Allen Pais","email":"allen.lkml@gmail.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1506013525-29291-33-git-send-email-allen.lkml@gmail.com/mbox/","series":[{"id":4448,"url":"http://patchwork.ozlabs.org/api/series/4448/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=4448","date":"2017-09-21T17:04:27","name":"use setup_timer() helper function.","version":1,"mbox":"http://patchwork.ozlabs.org/series/4448/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/817109/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/817109/checks/","tags":{},"related":[],"headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Icozp9zK\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xykCG2zyHz9sRq\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 22 Sep 2017 03:30:18 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752618AbdIURJI (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 21 Sep 2017 13:09:08 -0400","from mail-pf0-f193.google.com ([209.85.192.193]:34812 \"EHLO\n\tmail-pf0-f193.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751826AbdIURJF (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Thu, 21 Sep 2017 13:09:05 -0400","by mail-pf0-f193.google.com with SMTP id g65so2722762pfe.1;\n\tThu, 21 Sep 2017 10:09:05 -0700 (PDT)","from localhost.localdomain ([103.42.74.194])\n\tby smtp.gmail.com with ESMTPSA id\n\tp12sm3174090pgn.90.2017.09.21.10.08.58\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tThu, 21 Sep 2017 10:09:03 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=NNuTVmz4gODYqT1SCOa5To7KYrG3oKi4IGeQPgI53A0=;\n\tb=Icozp9zKQfjlRY4Se3Ew+00beT3EkB2m2cMs2089nRTNFgtWlcbtMex9TBRWdvtPTz\n\tUtHb0syJNLnVEw1x2LDuZjhQDQBbGdUcva3IjQoszAdX86Zv6ujx1fyyVNBDP9NGBpty\n\tj+l5DjY8Rus/I/Mg94A82kSKILyOIz2lF4HwwmAFkgNyi4zfDWfxbjejqyjKmyZVraW6\n\thMsy9vWdHiefBEaZg3UdpRnJ9cm5sDgNtsvd258d9LcA8e8ABAbp4Jkf8nPBhjve5LRw\n\t0YFI4iUq6X572i5HglP1jgrv2smwGfSRYv53FUWvhvhRgeGXnyLnxW4eL2Y8U1wSF/Wf\n\trTMQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=NNuTVmz4gODYqT1SCOa5To7KYrG3oKi4IGeQPgI53A0=;\n\tb=sJcdG/xMcHRw+uxT+bxO7gXq6+qx22Mf2EF7iUh2c4urlqAbXuELd5amfRTgQtuQO2\n\tZ45LFFym65j79Ck6L310vddOTEMB+io31aLTOoi8DQH3P6f1Quy+b6ndnjIjAIpLyu2H\n\tvQXmN8TiidU/P/ZY0bwkhb/vWFj7Voe5WAA13vyETlGt9SA/OCSM1cQGubABDql+lqvl\n\tJhzPxXRdWmZNvyubRZk1tk390pmnuKiluPpk/yduSOtyMVn1tfFTxmfA0Pr2t4VLxrtl\n\tMKXB6FD4/PNpKbKL+focDZmC0x+q+AagKISJZU3U8e5Q3u78pyZLtwRwfSVsy5+bLLAj\n\tideg==","X-Gm-Message-State":"AHPjjUi6JoeIkL00okewetjwu40EseLFYBGRnKK2MFMRMERI66/76z3j\n\tasgQw3wnjmhl7PDIa78vSVCnUhlw","X-Google-Smtp-Source":"AOwi7QDDcY8JZ4HfyWr4qc3SS6Nnbe4ZGRvO20yfJSHcQYCXOFIrXNflh7p4KU1Ehkw0g31Ozcsr8A==","X-Received":"by 10.84.234.140 with SMTP id n12mr6250245plk.209.1506013744626; \n\tThu, 21 Sep 2017 10:09:04 -0700 (PDT)","From":"Allen Pais <allen.lkml@gmail.com>","To":"netdev@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org, m.grzeschik@pengutronix.de,\n\tdmitry.tarnyagin@lockless.no, wg@grandegger.com,\n\tmkl@pengutronix.de, mark.einon@gmail.com, linux@armlinux.org.uk,\n\tpcnet32@frontier.com, f.fainelli@gmail.com,\n\tbcm-kernel-feedback-list@broadcom.com, venza@brownhat.org,\n\tajk@comnets.uni-bremen.de, jes@trained-monkey.org,\n\tromieu@fr.zoreil.com, khc@pm.waw.pl, simon@thekelleys.org.uk,\n\tdavem@davemloft.net, linux-can@vger.kernel.org,\n\tadi-buildroot-devel@lists.sourceforge.net,\n\tAllen Pais <allen.lkml@gmail.com>","Subject":"[PATCH 32/64] drivers: net: amd: use setup_timer() helper.","Date":"Thu, 21 Sep 2017 22:34:53 +0530","Message-Id":"<1506013525-29291-33-git-send-email-allen.lkml@gmail.com>","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1506013525-29291-1-git-send-email-allen.lkml@gmail.com>","References":"<1506013525-29291-1-git-send-email-allen.lkml@gmail.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Use setup_timer function instead of initializing timer with the\n    function and data fields.\n\nSigned-off-by: Allen Pais <allen.lkml@gmail.com>\n---\n drivers/net/ethernet/amd/sunlance.c | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)","diff":"diff --git a/drivers/net/ethernet/amd/sunlance.c b/drivers/net/ethernet/amd/sunlance.c\nindex 291ca51..0183ffb 100644\n--- a/drivers/net/ethernet/amd/sunlance.c\n+++ b/drivers/net/ethernet/amd/sunlance.c\n@@ -1459,9 +1459,8 @@ static int sparc_lance_probe_one(struct platform_device *op,\n \t * can occur from interrupts (ex. IPv6).  So we\n \t * use a timer to try again later when necessary. -DaveM\n \t */\n-\tinit_timer(&lp->multicast_timer);\n-\tlp->multicast_timer.data = (unsigned long) dev;\n-\tlp->multicast_timer.function = lance_set_multicast_retry;\n+\tsetup_timer(&lp->multicast_timer, lance_set_multicast_retry,\n+\t\t    (unsigned long)dev);\n \n \tif (register_netdev(dev)) {\n \t\tprintk(KERN_ERR \"SunLance: Cannot register device.\\n\");\n","prefixes":["32/64"]}