{"id":817105,"url":"http://patchwork.ozlabs.org/api/patches/817105/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/1506013525-29291-37-git-send-email-allen.lkml@gmail.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1506013525-29291-37-git-send-email-allen.lkml@gmail.com>","list_archive_url":null,"date":"2017-09-21T17:04:57","name":"[36/64] drivers: net: can: use setup_timer() helper.","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"c5a383dc39ccd88141f233557e497249e8154bf7","submitter":{"id":72354,"url":"http://patchwork.ozlabs.org/api/people/72354/?format=json","name":"Allen Pais","email":"allen.lkml@gmail.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1506013525-29291-37-git-send-email-allen.lkml@gmail.com/mbox/","series":[{"id":4448,"url":"http://patchwork.ozlabs.org/api/series/4448/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=4448","date":"2017-09-21T17:04:27","name":"use setup_timer() helper function.","version":1,"mbox":"http://patchwork.ozlabs.org/series/4448/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/817105/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/817105/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"KCeoORjq\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xykB86z11z9s3T\n\tfor ;\n\tFri, 22 Sep 2017 03:29:20 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752698AbdIURJe (ORCPT );\n\tThu, 21 Sep 2017 13:09:34 -0400","from mail-pf0-f196.google.com ([209.85.192.196]:36584 \"EHLO\n\tmail-pf0-f196.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752685AbdIURJb (ORCPT\n\t); Thu, 21 Sep 2017 13:09:31 -0400","by mail-pf0-f196.google.com with SMTP id f84so2720188pfj.3;\n\tThu, 21 Sep 2017 10:09:30 -0700 (PDT)","from localhost.localdomain ([103.42.74.194])\n\tby smtp.gmail.com with ESMTPSA id\n\tp12sm3174090pgn.90.2017.09.21.10.09.24\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tThu, 21 Sep 2017 10:09:29 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=WUnoTpqDjriEP9mHk9D5YqwEmb/1DwjVtPmLBu9NOOc=;\n\tb=KCeoORjqVS+IPEuBZdnutW4X5JSdLI60oMu74jy0zBmes/4DyYTuXB5YXkkUALJylu\n\tjTxpux180hSKJGECjFPnQgwuuqDb8E3icuyD8x/wp8l4Bz7B0wZqDeQop07wKiTG9Gzf\n\tlNGN2OHIeozBO0PQ1OOozIUt2lZ88FZgsQZe2ZAGuVZQaeG3VDnF1iu7qZITyTWlt8D8\n\t7tOOqbMCrPA084+2YnDm/kzFQ1/lLEeW9EJMH1ZCtSHWVhTrAsYjH5k7ed+WjAvrhzQQ\n\tiDii0nh5h1Jv7/1dDIGFTpzZY421sK1WB9hIMjD/++BdzOhm22FXRPQXp4ktqnQ1/947\n\tN29w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=WUnoTpqDjriEP9mHk9D5YqwEmb/1DwjVtPmLBu9NOOc=;\n\tb=qVaEkzjyfU0M/tlDI73khkzJGh9T2pmUVf6PH+gyEGIiiePj42agJQUHjNKd/bavaM\n\tBZSNHOEW9uJZe/jbH3M8meQE/l+LOMOQq99EVugWSJGykMXmGPAGp3xcCGuYVHn4p9W/\n\tljPQ+ktwDgz428d287XIV27M3a2wdnz/pS1xrenw5UqQ7H64g0ajXjJ1ET/zfaYBWFgr\n\tvcF7hk2iRAgdK48WfNjg5DlZI+x6LlekDSjPdJoGylEkSY6T9obUGroWwO9BMRnffw2P\n\ti779AhFuEOSZum1czM3xn6uH3HUHWFcU5/iHM8qSooo5cOC/lx9rYnS9cilBYZo2VXUk\n\tHdWA==","X-Gm-Message-State":"AHPjjUjgOWFDb1lrhWk1PMTp3zO0tPvXDMO31NIxsGoDHynXhfLcWz2w\n\t04TgKxSBUwxFzsloSCu90Ci3HxTZ","X-Google-Smtp-Source":"AOwi7QAdFEdVg607civT+tSF149bwm4QHr1Tuvk88ccjPtRQrQMPKhcf2V2hZtbUJLIGlAqerQZhqg==","X-Received":"by 10.99.126.84 with SMTP id o20mr6413982pgn.133.1506013770122; \n\tThu, 21 Sep 2017 10:09:30 -0700 (PDT)","From":"Allen Pais ","To":"netdev@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org, m.grzeschik@pengutronix.de,\n\tdmitry.tarnyagin@lockless.no, wg@grandegger.com,\n\tmkl@pengutronix.de, mark.einon@gmail.com, linux@armlinux.org.uk,\n\tpcnet32@frontier.com, f.fainelli@gmail.com,\n\tbcm-kernel-feedback-list@broadcom.com, venza@brownhat.org,\n\tajk@comnets.uni-bremen.de, jes@trained-monkey.org,\n\tromieu@fr.zoreil.com, khc@pm.waw.pl, simon@thekelleys.org.uk,\n\tdavem@davemloft.net, linux-can@vger.kernel.org,\n\tadi-buildroot-devel@lists.sourceforge.net,\n\tAllen Pais ","Subject":"[PATCH 36/64] drivers: net: can: use setup_timer() helper.","Date":"Thu, 21 Sep 2017 22:34:57 +0530","Message-Id":"<1506013525-29291-37-git-send-email-allen.lkml@gmail.com>","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1506013525-29291-1-git-send-email-allen.lkml@gmail.com>","References":"<1506013525-29291-1-git-send-email-allen.lkml@gmail.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Use setup_timer function instead of initializing timer with the\n function and data fields.\n\nSigned-off-by: Allen Pais \n---\n drivers/net/can/grcan.c | 10 ++++------\n 1 file changed, 4 insertions(+), 6 deletions(-)","diff":"diff --git a/drivers/net/can/grcan.c b/drivers/net/can/grcan.c\nindex a7be12d..8570cfd 100644\n--- a/drivers/net/can/grcan.c\n+++ b/drivers/net/can/grcan.c\n@@ -1626,13 +1626,11 @@ static int grcan_setup_netdev(struct platform_device *ofdev,\n \tspin_lock_init(&priv->lock);\n \n \tif (priv->need_txbug_workaround) {\n-\t\tinit_timer(&priv->rr_timer);\n-\t\tpriv->rr_timer.function = grcan_running_reset;\n-\t\tpriv->rr_timer.data = (unsigned long)dev;\n+\t\tsetup_timer(&priv->rr_timer, grcan_running_reset,\n+\t\t\t (unsigned long)dev);\n \n-\t\tinit_timer(&priv->hang_timer);\n-\t\tpriv->hang_timer.function = grcan_initiate_running_reset;\n-\t\tpriv->hang_timer.data = (unsigned long)dev;\n+\t\tsetup_timer(&priv->hang_timer, grcan_initiate_running_reset,\n+\t\t\t (unsigned long)dev);\n \t}\n \n \tnetif_napi_add(dev, &priv->napi, grcan_poll, GRCAN_NAPI_WEIGHT);\n","prefixes":["36/64"]}