{"id":817096,"url":"http://patchwork.ozlabs.org/api/patches/817096/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/1506013525-29291-42-git-send-email-allen.lkml@gmail.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1506013525-29291-42-git-send-email-allen.lkml@gmail.com>","list_archive_url":null,"date":"2017-09-21T17:05:02","name":"[41/64] drivers: net: packetengines: use setup_timer() helper.","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"b849e24be3200faf081db517aa244650949204a6","submitter":{"id":72354,"url":"http://patchwork.ozlabs.org/api/people/72354/?format=json","name":"Allen Pais","email":"allen.lkml@gmail.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1506013525-29291-42-git-send-email-allen.lkml@gmail.com/mbox/","series":[{"id":4448,"url":"http://patchwork.ozlabs.org/api/series/4448/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=4448","date":"2017-09-21T17:04:27","name":"use setup_timer() helper function.","version":1,"mbox":"http://patchwork.ozlabs.org/series/4448/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/817096/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/817096/checks/","tags":{},"related":[],"headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"nRpNqs5i\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyk3V6pKhz9sRq\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 22 Sep 2017 03:23:34 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752788AbdIURKE (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 21 Sep 2017 13:10:04 -0400","from mail-pg0-f68.google.com ([74.125.83.68]:35412 \"EHLO\n\tmail-pg0-f68.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751871AbdIURKC (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Thu, 21 Sep 2017 13:10:02 -0400","by mail-pg0-f68.google.com with SMTP id j16so3748379pga.2;\n\tThu, 21 Sep 2017 10:10:02 -0700 (PDT)","from localhost.localdomain ([103.42.74.194])\n\tby smtp.gmail.com with ESMTPSA id\n\tp12sm3174090pgn.90.2017.09.21.10.09.55\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tThu, 21 Sep 2017 10:10:00 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=RjAb/czIWjAiwiotUkN/63mwy3T7Cu1CfOAUnHw9Jb4=;\n\tb=nRpNqs5iq1RLHvYYj5wN0Rip6/ilkQlGnRlrPv+XIzKdt2dHuda7JcsX4usvptAcTm\n\tuBaIbRGHNxGq8KlbWzgDg0rfDc7Hh/dxZMMZuV+PuDbvVyAYgrizN7VFpXLBBhMC7BJ4\n\tAz2jA1QEEoB7HxJe9e/NdU/qd5gt2LWEugt5c+txPYI/CXI0H8IE4QRrq3xhi3mSC+X1\n\tmZC41qcyzskKAnEn5lPbJxOy8c/gbpW0mf6hAxkYriV6FBEoKAA4/XuG6OoBx7XQWUgU\n\tTv3pY0xpGpm+EUBITzXFw3toFN71BCTCt/fpARYae3x+4RmP3/jKBxByU3Yc1MrstY90\n\tXFlA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=RjAb/czIWjAiwiotUkN/63mwy3T7Cu1CfOAUnHw9Jb4=;\n\tb=Ns5lGVYNXr92XpzRvIqlICk9NmuZLuX9pnddMW2zJpZxrTxh68r5mrBW0yg6mHDIzH\n\tynD3yfUuJC/3rj6H82vNLoQgLwEUMxbITda/V05pWWeV8K4bs53qFvni618vfZ9Llk8n\n\tAX8u6P6wCMqWGaoKPpVNwnAwGyyNFC2dGpjdhb8MsmFm+SFbtI7YWF7lXPWyKMXu2iwm\n\tdRo2IVp9EnPwjlhgSRl6RDsTgnuEaTWEKPd3jjljsOH/mjeN4L1Lg75+f3Wm/gYQWfOu\n\t2aDGJ2C4+/5M2gSNfXTfAA7sQdUUXaJ9JylGV0/NEg/dkOkNZ2+RmsGZ5P9+aiDRO0je\n\tA6MA==","X-Gm-Message-State":"AHPjjUh2A8nxY9KjS96cz/w74zwHDGZcaV7bsN4RhE5pwcyR+KyfX7Hy\n\tvPF4PlPBstyXUH7miTyA5CI/9O/d","X-Google-Smtp-Source":"AOwi7QBpg9s8ajDyY46huFrBO9kEc6A/ppMiSD2ua2p3n/bvKadJe5v5j61hrUJmRr9HCkfJy+kqeg==","X-Received":"by 10.84.217.76 with SMTP id e12mr6184131plj.202.1506013801330; \n\tThu, 21 Sep 2017 10:10:01 -0700 (PDT)","From":"Allen Pais <allen.lkml@gmail.com>","To":"netdev@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org, m.grzeschik@pengutronix.de,\n\tdmitry.tarnyagin@lockless.no, wg@grandegger.com,\n\tmkl@pengutronix.de, mark.einon@gmail.com, linux@armlinux.org.uk,\n\tpcnet32@frontier.com, f.fainelli@gmail.com,\n\tbcm-kernel-feedback-list@broadcom.com, venza@brownhat.org,\n\tajk@comnets.uni-bremen.de, jes@trained-monkey.org,\n\tromieu@fr.zoreil.com, khc@pm.waw.pl, simon@thekelleys.org.uk,\n\tdavem@davemloft.net, linux-can@vger.kernel.org,\n\tadi-buildroot-devel@lists.sourceforge.net,\n\tAllen Pais <allen.lkml@gmail.com>","Subject":"[PATCH 41/64] drivers: net: packetengines: use setup_timer() helper.","Date":"Thu, 21 Sep 2017 22:35:02 +0530","Message-Id":"<1506013525-29291-42-git-send-email-allen.lkml@gmail.com>","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1506013525-29291-1-git-send-email-allen.lkml@gmail.com>","References":"<1506013525-29291-1-git-send-email-allen.lkml@gmail.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Use setup_timer function instead of initializing timer with the\n    function and data fields.\n\nSigned-off-by: Allen Pais <allen.lkml@gmail.com>\n---\n drivers/net/ethernet/packetengines/yellowfin.c | 4 +---\n 1 file changed, 1 insertion(+), 3 deletions(-)","diff":"diff --git a/drivers/net/ethernet/packetengines/yellowfin.c b/drivers/net/ethernet/packetengines/yellowfin.c\nindex fa7770d..33c241f 100644\n--- a/drivers/net/ethernet/packetengines/yellowfin.c\n+++ b/drivers/net/ethernet/packetengines/yellowfin.c\n@@ -632,10 +632,8 @@ static int yellowfin_open(struct net_device *dev)\n \t}\n \n \t/* Set the timer to check for link beat. */\n-\tinit_timer(&yp->timer);\n+\tsetup_timer(&yp->timer, yellowfin_timer, (unsigned long)dev);\n \typ->timer.expires = jiffies + 3*HZ;\n-\typ->timer.data = (unsigned long)dev;\n-\typ->timer.function = yellowfin_timer;\t\t\t\t/* timer handler */\n \tadd_timer(&yp->timer);\n out:\n \treturn rc;\n","prefixes":["41/64"]}