{"id":817089,"url":"http://patchwork.ozlabs.org/api/patches/817089/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/1506013525-29291-50-git-send-email-allen.lkml@gmail.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1506013525-29291-50-git-send-email-allen.lkml@gmail.com>","list_archive_url":null,"date":"2017-09-21T17:05:10","name":"[49/64] drivers: net: adi: use setup_timer() helper.","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"a28e0d7e9d72a7600a85643ee9a91ef179fb5c11","submitter":{"id":72354,"url":"http://patchwork.ozlabs.org/api/people/72354/?format=json","name":"Allen Pais","email":"allen.lkml@gmail.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1506013525-29291-50-git-send-email-allen.lkml@gmail.com/mbox/","series":[{"id":4448,"url":"http://patchwork.ozlabs.org/api/series/4448/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=4448","date":"2017-09-21T17:04:27","name":"use setup_timer() helper function.","version":1,"mbox":"http://patchwork.ozlabs.org/series/4448/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/817089/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/817089/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"gdTmKUGN\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyk055pMbz9sRq\n\tfor ;\n\tFri, 22 Sep 2017 03:20:37 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752968AbdIURK4 (ORCPT );\n\tThu, 21 Sep 2017 13:10:56 -0400","from mail-pf0-f193.google.com ([209.85.192.193]:36929 \"EHLO\n\tmail-pf0-f193.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752679AbdIURKx (ORCPT\n\t); Thu, 21 Sep 2017 13:10:53 -0400","by mail-pf0-f193.google.com with SMTP id e69so2715227pfg.4;\n\tThu, 21 Sep 2017 10:10:53 -0700 (PDT)","from localhost.localdomain ([103.42.74.194])\n\tby smtp.gmail.com with ESMTPSA id\n\tp12sm3174090pgn.90.2017.09.21.10.10.46\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tThu, 21 Sep 2017 10:10:51 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=54m/+7BavLlmK0iSn3WjHUsOhvcjnbVowF8yvesq6H8=;\n\tb=gdTmKUGNrdPkIuZw9Xzjum+vWctgHLAgNXTpl1Ddrc3qnxyhzyV9/WXasdGS0w8HmT\n\tCvbNFuDWyU1jwv08R+RRcBCwNkAP6tAyCRTSKR6wb02jRe23SRUef9NB1poAt30JqJIY\n\tugqEOU06BtNQIFC+dZvIyHoPcOxrL+1LWYXkjaOAohZ2xeKcdvd7/pXYdmpcJiVd+6ef\n\tp7hGz1X+FMQTlRSTvfvTDPEiJgSqeEdWPAwgwb+zltUM4FMbqDPdq7yw4BaLLXfTxY65\n\tatLoayk2WWIrcygkBf65Bdah7DBvIMLbsxJ0ROCPU+wPo313PoDpg5rtbWPi5r+4jd35\n\tSiVA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=54m/+7BavLlmK0iSn3WjHUsOhvcjnbVowF8yvesq6H8=;\n\tb=XmDThSAgvliebaxZqlLlaTS21+JnbQOZ4SibrkJIOrZU6oDk4zvXVzAVjEjCyM6krd\n\tZ3eQWzNisvvt5aM3Jfs/I8h4KfK5fn+Bf6p5TP7tac5fA3uNt5mMNgKRtCHaMtg94qoi\n\tJraNUy1TFELQqaf1sNtUhU95LOHD44XDFjJfNnIQvg/8jA2+a1YqHcSvbm0o/o8NIW6P\n\tpnA0uJvx5FUB3YYBsF7W2ZD+6pPJj9aw2XJIcW550o24t+G3JrcfZCaeBMASOnJ6jWXF\n\tfwna49TYzV6l/OpdESdEjuhYj7lL60j5uAPz/hUvJhWLX79gn0kv91honu4QzBI1Y5eS\n\tapXg==","X-Gm-Message-State":"AHPjjUj/mLCwn4MVrS8QKrNP+ooihvB4NfFx05IjSCoOuCKeFMfqeV6m\n\t/j0YgzAHLmWeCA4Ehl8mXKPAzGup","X-Google-Smtp-Source":"AOwi7QAt9EOi31YRvhWcAgejyf3XrOgmJ70Rl4g0OIoSh7w9AxoOnuVV9xITz7PsiuUIS7FKg+iQHg==","X-Received":"by 10.84.133.6 with SMTP id 6mr6056294plf.61.1506013852708;\n\tThu, 21 Sep 2017 10:10:52 -0700 (PDT)","From":"Allen Pais ","To":"netdev@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org, m.grzeschik@pengutronix.de,\n\tdmitry.tarnyagin@lockless.no, wg@grandegger.com,\n\tmkl@pengutronix.de, mark.einon@gmail.com, linux@armlinux.org.uk,\n\tpcnet32@frontier.com, f.fainelli@gmail.com,\n\tbcm-kernel-feedback-list@broadcom.com, venza@brownhat.org,\n\tajk@comnets.uni-bremen.de, jes@trained-monkey.org,\n\tromieu@fr.zoreil.com, khc@pm.waw.pl, simon@thekelleys.org.uk,\n\tdavem@davemloft.net, linux-can@vger.kernel.org,\n\tadi-buildroot-devel@lists.sourceforge.net,\n\tAllen Pais ","Subject":"[PATCH 49/64] drivers: net: adi: use setup_timer() helper.","Date":"Thu, 21 Sep 2017 22:35:10 +0530","Message-Id":"<1506013525-29291-50-git-send-email-allen.lkml@gmail.com>","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1506013525-29291-1-git-send-email-allen.lkml@gmail.com>","References":"<1506013525-29291-1-git-send-email-allen.lkml@gmail.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Use setup_timer function instead of initializing timer with the\n function and data fields.\n\nSigned-off-by: Allen Pais \n---\n drivers/net/ethernet/adi/bfin_mac.c | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)","diff":"diff --git a/drivers/net/ethernet/adi/bfin_mac.c b/drivers/net/ethernet/adi/bfin_mac.c\nindex a251de8..0658cde 100644\n--- a/drivers/net/ethernet/adi/bfin_mac.c\n+++ b/drivers/net/ethernet/adi/bfin_mac.c\n@@ -1650,9 +1650,8 @@ static int bfin_mac_probe(struct platform_device *pdev)\n \tndev->netdev_ops = &bfin_mac_netdev_ops;\n \tndev->ethtool_ops = &bfin_mac_ethtool_ops;\n \n-\tinit_timer(&lp->tx_reclaim_timer);\n-\tlp->tx_reclaim_timer.data = (unsigned long)lp;\n-\tlp->tx_reclaim_timer.function = tx_reclaim_skb_timeout;\n+\tsetup_timer(&lp->tx_reclaim_timer, tx_reclaim_skb_timeout,\n+\t\t (unsigned long)lp);\n \n \tlp->flags = 0;\n \tnetif_napi_add(ndev, &lp->napi, bfin_mac_poll, CONFIG_BFIN_RX_DESC_NUM);\n","prefixes":["49/64"]}