{"id":817084,"url":"http://patchwork.ozlabs.org/api/patches/817084/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/1506013525-29291-55-git-send-email-allen.lkml@gmail.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1506013525-29291-55-git-send-email-allen.lkml@gmail.com>","list_archive_url":null,"date":"2017-09-21T17:05:15","name":"[54/64] drivers: net: hdlc_ppp: use setup_timer() helper.","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"520fcd18dd1e17d972cd0876eda6824a85c5ee51","submitter":{"id":72354,"url":"http://patchwork.ozlabs.org/api/people/72354/?format=json","name":"Allen Pais","email":"allen.lkml@gmail.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1506013525-29291-55-git-send-email-allen.lkml@gmail.com/mbox/","series":[{"id":4448,"url":"http://patchwork.ozlabs.org/api/series/4448/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=4448","date":"2017-09-21T17:04:27","name":"use setup_timer() helper function.","version":1,"mbox":"http://patchwork.ozlabs.org/series/4448/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/817084/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/817084/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"b/zMu8jv\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyjy60DJgz9sRq\n\tfor ;\n\tFri, 22 Sep 2017 03:18:54 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753093AbdIURL1 (ORCPT );\n\tThu, 21 Sep 2017 13:11:27 -0400","from mail-pg0-f65.google.com ([74.125.83.65]:33627 \"EHLO\n\tmail-pg0-f65.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753083AbdIURLY (ORCPT\n\t); Thu, 21 Sep 2017 13:11:24 -0400","by mail-pg0-f65.google.com with SMTP id i130so3757163pgc.0;\n\tThu, 21 Sep 2017 10:11:24 -0700 (PDT)","from localhost.localdomain ([103.42.74.194])\n\tby smtp.gmail.com with ESMTPSA id\n\tp12sm3174090pgn.90.2017.09.21.10.11.18\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tThu, 21 Sep 2017 10:11:22 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=BeD2JTHezW543/+u2U2XROsJL1xesL+QbBFgZrlcFUc=;\n\tb=b/zMu8jvaO312A0K3wH8/WDok55lDqW0sbYIsz9Acr0CDUshs+j4yg+v7bm9OADJOM\n\tQuYKC5UMlNssgpczqpkbK43jfEFkPH7EyHDRt1/EAjKi43wgDhHJThI54o5knmK2+TrR\n\tpUkk8igTssuRqSvSWUSeiG5YxRGUG3skPuZtLE7X+PkFOiccf22axPlYltDi00tO664+\n\t+km0+FtkKMCIcuoJ1zY+7gLuV6mxXYPFcHnh3NeBAXIijILnOY/aHVtaxW51jgbD4wY6\n\tga8R8qFtOL7/S0Kesy6gTk7NV7tXuyphwoajQb9e8tCGOyK21Y3TrUFrHIRvY6V+pPFG\n\t3pvg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=BeD2JTHezW543/+u2U2XROsJL1xesL+QbBFgZrlcFUc=;\n\tb=lCKTZIbUvVajcbJ8UaeA2mbW4+x8LiGuy64dLFJm23NE/IxZ2w9KQTKhfZeNU+dJ4E\n\tZoSM2VRt5SU+tHimQ5dVZ6BDWCikhHZTgeH7DP1kN8wd22JfE174WPCnOQqfSW2SG0u5\n\tUZWlmG6kZhuaiPOoO+poVPk5313HVfBb1dkcaDxOE86vDIAyYom8iWHQjOMwDGZtWglR\n\tGmbU4Hn7x423nhuViKWJt7POpbrgRF2yVU+Un660vJZoMCDa1mjtRj6EHJlacSFThfjB\n\tmMz3iBd5uUlzC6uk1KFPmH3EjiqsYikhiXqVktrSw4152MRKtbs/7X/mz2B6pJQzaQqU\n\tM83g==","X-Gm-Message-State":"AHPjjUj/XTRQSf5SM4qad34cOc5c+J13PXaLsEM6hpNGsfPk3CFiNJPc\n\tWyc72LxSlVAZfrsjB6D8TdeD2P9N","X-Google-Smtp-Source":"AOwi7QC1pcz+m/aruVZM574TJfsyrUpv8cppgnw2oeyNJWLzMWX5SxmTqfm6AAeTB40BAQajQjP6xQ==","X-Received":"by 10.84.210.196 with SMTP id a62mr6195932pli.356.1506013884061; \n\tThu, 21 Sep 2017 10:11:24 -0700 (PDT)","From":"Allen Pais ","To":"netdev@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org, m.grzeschik@pengutronix.de,\n\tdmitry.tarnyagin@lockless.no, wg@grandegger.com,\n\tmkl@pengutronix.de, mark.einon@gmail.com, linux@armlinux.org.uk,\n\tpcnet32@frontier.com, f.fainelli@gmail.com,\n\tbcm-kernel-feedback-list@broadcom.com, venza@brownhat.org,\n\tajk@comnets.uni-bremen.de, jes@trained-monkey.org,\n\tromieu@fr.zoreil.com, khc@pm.waw.pl, simon@thekelleys.org.uk,\n\tdavem@davemloft.net, linux-can@vger.kernel.org,\n\tadi-buildroot-devel@lists.sourceforge.net,\n\tAllen Pais ","Subject":"[PATCH 54/64] drivers: net: hdlc_ppp: use setup_timer() helper.","Date":"Thu, 21 Sep 2017 22:35:15 +0530","Message-Id":"<1506013525-29291-55-git-send-email-allen.lkml@gmail.com>","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1506013525-29291-1-git-send-email-allen.lkml@gmail.com>","References":"<1506013525-29291-1-git-send-email-allen.lkml@gmail.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Use setup_timer function instead of initializing timer with the\n function and data fields.\n\nSigned-off-by: Allen Pais \n---\n drivers/net/wan/hdlc_ppp.c | 4 +---\n 1 file changed, 1 insertion(+), 3 deletions(-)","diff":"diff --git a/drivers/net/wan/hdlc_ppp.c b/drivers/net/wan/hdlc_ppp.c\nindex 0d2e00e..c7721c7 100644\n--- a/drivers/net/wan/hdlc_ppp.c\n+++ b/drivers/net/wan/hdlc_ppp.c\n@@ -610,9 +610,7 @@ static void ppp_start(struct net_device *dev)\n \tfor (i = 0; i < IDX_COUNT; i++) {\n \t\tstruct proto *proto = &ppp->protos[i];\n \t\tproto->dev = dev;\n-\t\tinit_timer(&proto->timer);\n-\t\tproto->timer.function = ppp_timer;\n-\t\tproto->timer.data = (unsigned long)proto;\n+\t\tsetup_timer(&proto->timer, ppp_timer, (unsigned long)proto);\n \t\tproto->state = CLOSED;\n \t}\n \tppp->protos[IDX_LCP].pid = PID_LCP;\n","prefixes":["54/64"]}