{"id":817076,"url":"http://patchwork.ozlabs.org/api/patches/817076/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/1506013525-29291-59-git-send-email-allen.lkml@gmail.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1506013525-29291-59-git-send-email-allen.lkml@gmail.com>","list_archive_url":null,"date":"2017-09-21T17:05:19","name":"[58/64] drivers: net: packetengines: use setup_timer() helper.","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"30a23413f2fd0ce2516d04d1b88b52f554bd883c","submitter":{"id":72354,"url":"http://patchwork.ozlabs.org/api/people/72354/?format=json","name":"Allen Pais","email":"allen.lkml@gmail.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1506013525-29291-59-git-send-email-allen.lkml@gmail.com/mbox/","series":[{"id":4448,"url":"http://patchwork.ozlabs.org/api/series/4448/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=4448","date":"2017-09-21T17:04:27","name":"use setup_timer() helper function.","version":1,"mbox":"http://patchwork.ozlabs.org/series/4448/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/817076/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/817076/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"I50fr3AF\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyjrb5xFyz9sRq\n\tfor ;\n\tFri, 22 Sep 2017 03:14:07 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753174AbdIURL5 (ORCPT );\n\tThu, 21 Sep 2017 13:11:57 -0400","from mail-pg0-f66.google.com ([74.125.83.66]:37263 \"EHLO\n\tmail-pg0-f66.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753164AbdIURLt (ORCPT\n\t); Thu, 21 Sep 2017 13:11:49 -0400","by mail-pg0-f66.google.com with SMTP id v5so3742628pgn.4;\n\tThu, 21 Sep 2017 10:11:49 -0700 (PDT)","from localhost.localdomain ([103.42.74.194])\n\tby smtp.gmail.com with ESMTPSA id\n\tp12sm3174090pgn.90.2017.09.21.10.11.42\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tThu, 21 Sep 2017 10:11:47 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=bxpWgOO3CSXMbpbdUx94H2ckesXBJ+skyAC/u2nyaPY=;\n\tb=I50fr3AFrl/MUQkBw/QaVb53sqwzsVKhat60Gpx8tYgzrgFiTbMvco0yIt6deV6LL/\n\tKlrDwMfKeNj04f2OErjnTzLP6QGl1TbY++DbFzwActUNYLuiR43uWorZMCWTJFgxRqNh\n\tjC0yiQoxte4OCbGiSo/jzxr0GNDTYQfXpgj59UZSlWTEeRZZ9wvCHqRqH5Qt5tgu499C\n\tWuIUxiXF7OA8Ig7rJZ8A1vxMdzwM7OiIuzKO7q347Ek+YQ/ifTQ7Bacpv0a5By4RsDgh\n\tVVHmPCcpnBx/5pecR4M2F3Fz1vf3jQoUEyAxo7fBfQ1AO4Hj8FzXyBTESpasKG+7N+sd\n\t+lSQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=bxpWgOO3CSXMbpbdUx94H2ckesXBJ+skyAC/u2nyaPY=;\n\tb=AiU8jrbE/ZVWZu1awYJ3IUayUEkeVu1/kr41MDXOc09tV1D8pNedQRvEKwlJtstSpU\n\tTPPbGaMrRO05ly7sARwhme0NASHdHA/JF5x1xRH2fJt59y6G6diYYR/tljv9062f1h7n\n\t5dzhzcQ2oHFV8C3GkeZpWhRZoGMPqz1PI1V5ItXJLIrUFCPiUW9QYcS/rspz2nklP6Wz\n\tZ0a5nOkcmQj3EEQPrjKtwo0Rp8FW4owkG6K4lJ6bQ4+uASuvzSJusZpmXZDt1ZQGeveK\n\twmML6BA1/hZz2C4LreZDQWfVvCv3yy7bOrPjyXUMzS4UmJ9T1cyfUAZyvPJnFEWFdUIf\n\tdWlA==","X-Gm-Message-State":"AHPjjUjxHC/EyEUsp0aL/deFsy7kIKt0o+iH0YmJv0WtU4EkeTND/Rig\n\tt4Nx4fnoeVrZkeUl7KM1Bib+oU+/","X-Google-Smtp-Source":"AOwi7QDddhz5plLt1Rh6ySYjU75rBtfiGpjymOzFNB8nrzg1oh6xRZVpoIhtzQOfohnLtWOr20xLrA==","X-Received":"by 10.99.53.206 with SMTP id c197mr6410008pga.440.1506013908852; \n\tThu, 21 Sep 2017 10:11:48 -0700 (PDT)","From":"Allen Pais ","To":"netdev@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org, m.grzeschik@pengutronix.de,\n\tdmitry.tarnyagin@lockless.no, wg@grandegger.com,\n\tmkl@pengutronix.de, mark.einon@gmail.com, linux@armlinux.org.uk,\n\tpcnet32@frontier.com, f.fainelli@gmail.com,\n\tbcm-kernel-feedback-list@broadcom.com, venza@brownhat.org,\n\tajk@comnets.uni-bremen.de, jes@trained-monkey.org,\n\tromieu@fr.zoreil.com, khc@pm.waw.pl, simon@thekelleys.org.uk,\n\tdavem@davemloft.net, linux-can@vger.kernel.org,\n\tadi-buildroot-devel@lists.sourceforge.net,\n\tAllen Pais ","Subject":"[PATCH 58/64] drivers: net: packetengines: use setup_timer() helper.","Date":"Thu, 21 Sep 2017 22:35:19 +0530","Message-Id":"<1506013525-29291-59-git-send-email-allen.lkml@gmail.com>","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1506013525-29291-1-git-send-email-allen.lkml@gmail.com>","References":"<1506013525-29291-1-git-send-email-allen.lkml@gmail.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Use setup_timer function instead of initializing timer with the\n function and data fields.\n\nSigned-off-by: Allen Pais \n---\n drivers/net/ethernet/packetengines/hamachi.c | 4 +---\n 1 file changed, 1 insertion(+), 3 deletions(-)","diff":"diff --git a/drivers/net/ethernet/packetengines/hamachi.c b/drivers/net/ethernet/packetengines/hamachi.c\nindex 482b85e..77bc7cc 100644\n--- a/drivers/net/ethernet/packetengines/hamachi.c\n+++ b/drivers/net/ethernet/packetengines/hamachi.c\n@@ -979,10 +979,8 @@ static int hamachi_open(struct net_device *dev)\n \t\t\t dev->name, readw(ioaddr + RxStatus), readw(ioaddr + TxStatus));\n \t}\n \t/* Set the timer to check for link beat. */\n-\tinit_timer(&hmp->timer);\n+\tsetup_timer(&hmp->timer, hamachi_timer, (unsigned long)dev);\n \thmp->timer.expires = RUN_AT((24*HZ)/10);\t\t\t/* 2.4 sec. */\n-\thmp->timer.data = (unsigned long)dev;\n-\thmp->timer.function = hamachi_timer;\t\t\t\t/* timer handler */\n \tadd_timer(&hmp->timer);\n \n \treturn 0;\n","prefixes":["58/64"]}