{"id":816981,"url":"http://patchwork.ozlabs.org/api/patches/816981/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/1506007346-10037-3-git-send-email-jjhiblot@ti.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1506007346-10037-3-git-send-email-jjhiblot@ti.com>","list_archive_url":null,"date":"2017-09-21T15:22:05","name":"[U-Boot,02/23] mmc: omap_hsmmc: cleanup omap_hsmmc_set_ios","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"cc2c1e21f4fdb184ab945fa0b0a6189352c1745d","submitter":{"id":70508,"url":"http://patchwork.ozlabs.org/api/people/70508/?format=json","name":"Jean-Jacques Hiblot","email":"jjhiblot@ti.com"},"delegate":{"id":3651,"url":"http://patchwork.ozlabs.org/api/users/3651/?format=json","username":"trini","first_name":"Tom","last_name":"Rini","email":"trini@ti.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/1506007346-10037-3-git-send-email-jjhiblot@ti.com/mbox/","series":[{"id":4414,"url":"http://patchwork.ozlabs.org/api/series/4414/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=4414","date":"2017-09-21T15:22:03","name":"mmc: omap5: Add support for UHS and HS200 modes","version":1,"mbox":"http://patchwork.ozlabs.org/series/4414/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/816981/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/816981/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ti.com header.i=@ti.com header.b=\"gpmgxUVM\";\n\tdkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xygjJ2hxgz9s06\n\tfor ;\n\tFri, 22 Sep 2017 01:37:40 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 2BB00C2211F; Thu, 21 Sep 2017 15:31:30 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 45C32C220AF;\n\tThu, 21 Sep 2017 15:31:28 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 48CAAC220C6; Thu, 21 Sep 2017 15:23:54 +0000 (UTC)","from fllnx209.ext.ti.com (fllnx209.ext.ti.com [198.47.19.16])\n\tby lists.denx.de (Postfix) with ESMTPS id 7DEBFC2203F\n\tfor ; Thu, 21 Sep 2017 15:23:49 +0000 (UTC)","from dflxv15.itg.ti.com ([128.247.5.124])\n\tby fllnx209.ext.ti.com (8.15.1/8.15.1) with ESMTP id v8LFMlOg009108; \n\tThu, 21 Sep 2017 10:22:47 -0500","from DFLE102.ent.ti.com (dfle102.ent.ti.com [10.64.6.23])\n\tby dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id v8LFMglr009300;\n\tThu, 21 Sep 2017 10:22:42 -0500","from DFLE114.ent.ti.com (10.64.6.35) by DFLE102.ent.ti.com\n\t(10.64.6.23) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.845.34;\n\tThu, 21 Sep 2017 10:22:41 -0500","from dflp33.itg.ti.com (10.64.6.16) by DFLE114.ent.ti.com\n\t(10.64.6.35) with Microsoft SMTP Server (version=TLS1_0,\n\tcipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.845.34 via Frontend\n\tTransport; Thu, 21 Sep 2017 10:22:41 -0500","from localhost (ileax41-snat.itg.ti.com [10.172.224.153])\n\tby dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id v8LFMexQ022763;\n\tThu, 21 Sep 2017 10:22:41 -0500"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tT_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com;\n\ts=ti-com-17Q1; t=1506007367;\n\tbh=bA3eRrfYnFlqv3dQ0mY4bDjBfPbx+MmR9uhvw60AiUE=;\n\th=From:To:CC:Subject:Date:In-Reply-To:References;\n\tb=gpmgxUVM1CtXOMwQgDLIiJ4wAAxdwRL54Rhs1bOD8ZNcWSuucdRoqUZ9GBYwMKYKE\n\t3v+x4z8Z+AcioI5ZIhYn8m3qchsxlQoSD/9Z7Oo8Wyn49/YDKZWIrJOM3z0VVT6HYj\n\tb0RzZmVuNMAJQwjdl3L5fYARxk5TWJ7zWKj9XcYk=","From":"Jean-Jacques Hiblot ","To":", , ,\n\t, ","Date":"Thu, 21 Sep 2017 17:22:05 +0200","Message-ID":"<1506007346-10037-3-git-send-email-jjhiblot@ti.com>","X-Mailer":"git-send-email 1.9.1","In-Reply-To":"<1506007346-10037-1-git-send-email-jjhiblot@ti.com>","References":"<1506007346-10037-1-git-send-email-jjhiblot@ti.com>","MIME-Version":"1.0","X-EXCLAIMER-MD-CONFIG":"e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180","Cc":"u-boot@lists.denx.de","Subject":"[U-Boot] [PATCH 02/23] mmc: omap_hsmmc: cleanup omap_hsmmc_set_ios","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "},"content":"From: Kishon Vijay Abraham I \n\nNo functional change. Move bus width configuration setting to a\nseparate function and invoke it only if there is a change in the\nbus width.\n\nSigned-off-by: Kishon Vijay Abraham I \nSigned-off-by: Jean-Jacques Hiblot \n---\n drivers/mmc/omap_hsmmc.c | 29 ++++++++++++++++++++---------\n 1 file changed, 20 insertions(+), 9 deletions(-)","diff":"diff --git a/drivers/mmc/omap_hsmmc.c b/drivers/mmc/omap_hsmmc.c\nindex 6ef8295..bab0cef 100644\n--- a/drivers/mmc/omap_hsmmc.c\n+++ b/drivers/mmc/omap_hsmmc.c\n@@ -62,6 +62,7 @@ struct omap_hsmmc_data {\n #if !CONFIG_IS_ENABLED(DM_MMC)\n \tstruct mmc_config cfg;\n #endif\n+\tuint bus_width;\n \tuint clock;\n #ifdef OMAP_HSMMC_USE_GPIO\n #if CONFIG_IS_ENABLED(DM_MMC)\n@@ -810,17 +811,9 @@ static void omap_hsmmc_set_clock(struct mmc *mmc)\n \tomap_hsmmc_start_clock(mmc_base);\n }\n \n-#if !CONFIG_IS_ENABLED(DM_MMC)\n-static int omap_hsmmc_set_ios(struct mmc *mmc)\n+static void omap_hsmmc_set_bus_width(struct mmc *mmc)\n {\n \tstruct omap_hsmmc_data *priv = omap_hsmmc_get_data(mmc);\n-#else\n-static int omap_hsmmc_set_ios(struct udevice *dev)\n-{\n-\tstruct omap_hsmmc_data *priv = dev_get_priv(dev);\n-\tstruct mmc_uclass_priv *upriv = dev_get_uclass_priv(dev);\n-\tstruct mmc *mmc = upriv->mmc;\n-#endif\n \tstruct hsmmc *mmc_base;\n \n \tmmc_base = priv->base_addr;\n@@ -847,6 +840,24 @@ static int omap_hsmmc_set_ios(struct udevice *dev)\n \t\tbreak;\n \t}\n \n+\tpriv->bus_width = mmc->bus_width;\n+}\n+\n+#if !CONFIG_IS_ENABLED(DM_MMC)\n+static int omap_hsmmc_set_ios(struct mmc *mmc)\n+{\n+\tstruct omap_hsmmc_data *priv = omap_hsmmc_get_data(mmc);\n+#else\n+static int omap_hsmmc_set_ios(struct udevice *dev)\n+{\n+\tstruct omap_hsmmc_data *priv = dev_get_priv(dev);\n+\tstruct mmc_uclass_priv *upriv = dev_get_uclass_priv(dev);\n+\tstruct mmc *mmc = upriv->mmc;\n+#endif\n+\n+\tif (priv->bus_width != mmc->bus_width)\n+\t\tomap_hsmmc_set_bus_width(mmc);\n+\n \tif (priv->clock != mmc->clock)\n \t\tomap_hsmmc_set_clock(mmc);\n \n","prefixes":["U-Boot","02/23"]}