{"id":816921,"url":"http://patchwork.ozlabs.org/api/patches/816921/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/1506004213-22620-13-git-send-email-jjhiblot@ti.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1506004213-22620-13-git-send-email-jjhiblot@ti.com>","list_archive_url":null,"date":"2017-09-21T14:29:59","name":"[U-Boot,v2,12/26] mmc: make mmc_set_ios() return status","commit_ref":"2a4d212f7110712f51ae8af73abbdb0ae2af0814","pull_url":null,"state":"accepted","archived":false,"hash":"06e2a9096c4d4a09a59340e7d979884fa0d9a2b6","submitter":{"id":70508,"url":"http://patchwork.ozlabs.org/api/people/70508/?format=json","name":"Jean-Jacques Hiblot","email":"jjhiblot@ti.com"},"delegate":{"id":12423,"url":"http://patchwork.ozlabs.org/api/users/12423/?format=json","username":"Jaehoon","first_name":"Jaehoon","last_name":"Chung","email":"jh80.chung@samsung.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/1506004213-22620-13-git-send-email-jjhiblot@ti.com/mbox/","series":[{"id":4400,"url":"http://patchwork.ozlabs.org/api/series/4400/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=4400","date":"2017-09-21T14:29:47","name":"mmc: Add support for HS200 and UHS modes","version":2,"mbox":"http://patchwork.ozlabs.org/series/4400/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/816921/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/816921/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ti.com header.i=@ti.com header.b=\"f27aPRqu\";\n\tdkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyfc620yrz9sP1\n\tfor ;\n\tFri, 22 Sep 2017 00:48:06 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 0ECD0C22092; Thu, 21 Sep 2017 14:37:16 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 83512C21FF9;\n\tThu, 21 Sep 2017 14:33:40 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 51237C21E41; Thu, 21 Sep 2017 14:31:55 +0000 (UTC)","from fllnx209.ext.ti.com (fllnx209.ext.ti.com [198.47.19.16])\n\tby lists.denx.de (Postfix) with ESMTPS id D3B59C21FEA\n\tfor ; Thu, 21 Sep 2017 14:31:51 +0000 (UTC)","from dflxv15.itg.ti.com ([128.247.5.124])\n\tby fllnx209.ext.ti.com (8.15.1/8.15.1) with ESMTP id v8LEUnrf032481; \n\tThu, 21 Sep 2017 09:30:49 -0500","from DFLE104.ent.ti.com (dfle104.ent.ti.com [10.64.6.25])\n\tby dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id v8LEUiAh028772;\n\tThu, 21 Sep 2017 09:30:44 -0500","from DFLE100.ent.ti.com (10.64.6.21) by DFLE104.ent.ti.com\n\t(10.64.6.25) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.845.34;\n\tThu, 21 Sep 2017 09:30:44 -0500","from dflp33.itg.ti.com (10.64.6.16) by DFLE100.ent.ti.com\n\t(10.64.6.21) with Microsoft SMTP Server (version=TLS1_0,\n\tcipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.845.34 via Frontend\n\tTransport; Thu, 21 Sep 2017 09:30:44 -0500","from localhost (ileax41-snat.itg.ti.com [10.172.224.153])\n\tby dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id v8LEUgt3000905;\n\tThu, 21 Sep 2017 09:30:43 -0500"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tT_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com;\n\ts=ti-com-17Q1; t=1506004249;\n\tbh=uGHpL8onwZDomzKprZnBokdV9n4cieq8NeeM7RszJy0=;\n\th=From:To:CC:Subject:Date:In-Reply-To:References;\n\tb=f27aPRquy28T/ZHbQ3UM0hnc9s1dvLuyWe3HA4CzyS8YrICwXIStGeW0MLcFOTN2d\n\tU9+Hnf3CTq4pQ6Do2T5+IvdSMo69xpk98/ax6FztF6xfXFYfHadwXnYBrY/eFofRch\n\toul3rpTdSchcChMtMNXNW452halosw/JttUnWWP0=","From":"Jean-Jacques Hiblot ","To":", , ,\n\t","Date":"Thu, 21 Sep 2017 16:29:59 +0200","Message-ID":"<1506004213-22620-13-git-send-email-jjhiblot@ti.com>","X-Mailer":"git-send-email 1.9.1","In-Reply-To":"<1506004213-22620-1-git-send-email-jjhiblot@ti.com>","References":"<1506004213-22620-1-git-send-email-jjhiblot@ti.com>","MIME-Version":"1.0","X-EXCLAIMER-MD-CONFIG":"e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180","Cc":"u-boot@lists.denx.de","Subject":"[U-Boot] [PATCH v2 12/26] mmc: make mmc_set_ios() return status","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "},"content":"From: Kishon Vijay Abraham I \n\nset_ios callback has a return value of 'int' but the mmc_set_ios()\nfunction ignore this. Modify mmc_set_ios() and the callers of mmc_set_ios() to\nto return the error status.\n\nSigned-off-by: Kishon Vijay Abraham I \nSigned-off-by: Jean-Jacques Hiblot \nReviewed-by: Simon Glass \n---\n drivers/mmc/mmc.c | 16 ++++++++++------\n include/mmc.h | 2 +-\n 2 files changed, 11 insertions(+), 7 deletions(-)","diff":"diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c\nindex 7361447..536cd7f 100644\n--- a/drivers/mmc/mmc.c\n+++ b/drivers/mmc/mmc.c\n@@ -1196,14 +1196,18 @@ static inline int bus_width(uint cap)\n }\n \n #if !CONFIG_IS_ENABLED(DM_MMC)\n-static void mmc_set_ios(struct mmc *mmc)\n+static int mmc_set_ios(struct mmc *mmc)\n {\n+\tint ret = 0;\n+\n \tif (mmc->cfg->ops->set_ios)\n-\t\tmmc->cfg->ops->set_ios(mmc);\n+\t\tret = mmc->cfg->ops->set_ios(mmc);\n+\n+\treturn ret;\n }\n #endif\n \n-void mmc_set_clock(struct mmc *mmc, uint clock)\n+int mmc_set_clock(struct mmc *mmc, uint clock)\n {\n \tif (clock > mmc->cfg->f_max)\n \t\tclock = mmc->cfg->f_max;\n@@ -1213,14 +1217,14 @@ void mmc_set_clock(struct mmc *mmc, uint clock)\n \n \tmmc->clock = clock;\n \n-\tmmc_set_ios(mmc);\n+\treturn mmc_set_ios(mmc);\n }\n \n-static void mmc_set_bus_width(struct mmc *mmc, uint width)\n+static int mmc_set_bus_width(struct mmc *mmc, uint width)\n {\n \tmmc->bus_width = width;\n \n-\tmmc_set_ios(mmc);\n+\treturn mmc_set_ios(mmc);\n }\n \n #if CONFIG_IS_ENABLED(MMC_VERBOSE) || defined(DEBUG)\ndiff --git a/include/mmc.h b/include/mmc.h\nindex 988bf17..3e57887 100644\n--- a/include/mmc.h\n+++ b/include/mmc.h\n@@ -549,7 +549,7 @@ int mmc_unbind(struct udevice *dev);\n int mmc_initialize(bd_t *bis);\n int mmc_init(struct mmc *mmc);\n int mmc_read(struct mmc *mmc, u64 src, uchar *dst, int size);\n-void mmc_set_clock(struct mmc *mmc, uint clock);\n+int mmc_set_clock(struct mmc *mmc, uint clock);\n struct mmc *find_mmc_device(int dev_num);\n int mmc_set_dev(int dev_num);\n void print_mmc_devices(char separator);\n","prefixes":["U-Boot","v2","12/26"]}