{"id":816718,"url":"http://patchwork.ozlabs.org/api/patches/816718/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20170921071634.16883-7-ubraun@linux.vnet.ibm.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170921071634.16883-7-ubraun@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-09-21T07:16:31","name":"[net,6/9] net/smc: longer delay for client link group removal","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"19b689e34638a57eeba27979b9da62826fda2dc0","submitter":{"id":2266,"url":"http://patchwork.ozlabs.org/api/people/2266/?format=json","name":"Ursula Braun","email":"ubraun@linux.vnet.ibm.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170921071634.16883-7-ubraun@linux.vnet.ibm.com/mbox/","series":[{"id":4314,"url":"http://patchwork.ozlabs.org/api/series/4314/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=4314","date":"2017-09-21T07:16:25","name":"net/smc: bug fixes 2017-09-20","version":1,"mbox":"http://patchwork.ozlabs.org/series/4314/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/816718/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/816718/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xySc15SdDz9sBZ\n\tfor ;\n\tThu, 21 Sep 2017 17:17:21 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751930AbdIUHRT (ORCPT );\n\tThu, 21 Sep 2017 03:17:19 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5]:40912 \"EHLO\n\tmx0a-001b2d01.pphosted.com\" rhost-flags-OK-OK-OK-FAIL)\n\tby vger.kernel.org with ESMTP id S1751875AbdIUHQu (ORCPT\n\t); Thu, 21 Sep 2017 03:16:50 -0400","from pps.filterd (m0098413.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8L7EEOx052863\n\tfor ; Thu, 21 Sep 2017 03:16:49 -0400","from e06smtp15.uk.ibm.com (e06smtp15.uk.ibm.com [195.75.94.111])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2d462ffae1-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Thu, 21 Sep 2017 03:16:49 -0400","from localhost\n\tby e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tThu, 21 Sep 2017 08:16:48 +0100","from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194)\n\tby e06smtp15.uk.ibm.com (192.168.101.145) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tThu, 21 Sep 2017 08:16:45 +0100","from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60])\n\tby b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8L7GiQD11403466; Thu, 21 Sep 2017 07:16:44 GMT","from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id E4F6C42045;\n\tThu, 21 Sep 2017 08:12:54 +0100 (BST)","from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 9C3B242042;\n\tThu, 21 Sep 2017 08:12:54 +0100 (BST)","from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9])\n\tby d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTPS;\n\tThu, 21 Sep 2017 08:12:54 +0100 (BST)"],"From":"Ursula Braun ","To":"davem@davemloft.net","Cc":"netdev@vger.kernel.org, linux-rdma@vger.kernel.org,\n\tlinux-s390@vger.kernel.org, jwi@linux.vnet.ibm.com,\n\tschwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,\n\traspl@linux.vnet.ibm.com, ubraun@linux.vnet.ibm.com","Subject":"[PATCH net 6/9] net/smc: longer delay for client link group removal","Date":"Thu, 21 Sep 2017 09:16:31 +0200","X-Mailer":"git-send-email 2.13.5","In-Reply-To":"<20170921071634.16883-1-ubraun@linux.vnet.ibm.com>","References":"<20170921071634.16883-1-ubraun@linux.vnet.ibm.com>","X-TM-AS-GCONF":"00","x-cbid":"17092107-0020-0000-0000-000003B9E352","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092107-0021-0000-0000-0000424BA11E","Message-Id":"<20170921071634.16883-7-ubraun@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-21_01:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=3\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709210099","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Client link group creation always follows the server linkgroup creation.\nIf peer creates a new server link group, client has to create a new\nclient link group. If peer reuses a server link group for a new\nconnection, client has to reuse its client link group as well. This\npatch introduces a longer delay for client link group removal to make\nsure this link group still exists, once the peer decides to reuse a\nserver link group. This avoids out-of-sync conditions for link groups.\nIf already scheduled, modify the delay.\n\nSigned-off-by: Ursula Braun \n---\n net/smc/smc_core.c | 16 ++++++++++++----\n 1 file changed, 12 insertions(+), 4 deletions(-)","diff":"diff --git a/net/smc/smc_core.c b/net/smc/smc_core.c\nindex 1a16d51e2330..20b66e79c5d6 100644\n--- a/net/smc/smc_core.c\n+++ b/net/smc/smc_core.c\n@@ -25,8 +25,9 @@\n #include \"smc_cdc.h\"\n #include \"smc_close.h\"\n \n-#define SMC_LGR_NUM_INCR\t256\n-#define SMC_LGR_FREE_DELAY\t(600 * HZ)\n+#define SMC_LGR_NUM_INCR\t\t256\n+#define SMC_LGR_FREE_DELAY_SERV\t\t(600 * HZ)\n+#define SMC_LGR_FREE_DELAY_CLNT\t\t(SMC_LGR_FREE_DELAY_SERV + 10)\n \n static u32 smc_lgr_num;\t\t\t/* unique link group number */\n \n@@ -107,8 +108,15 @@ static void smc_lgr_unregister_conn(struct smc_connection *conn)\n \t\t__smc_lgr_unregister_conn(conn);\n \t}\n \twrite_unlock_bh(&lgr->conns_lock);\n-\tif (reduced && !lgr->conns_num)\n-\t\tschedule_delayed_work(&lgr->free_work, SMC_LGR_FREE_DELAY);\n+\tif (!reduced || lgr->conns_num)\n+\t\treturn;\n+\t/* client link group creation always follows the server link group\n+\t * creation. For client use a somewhat higher removal delay time,\n+\t * otherwise there is a risk of out-of-sync link groups.\n+\t */\n+\tmod_delayed_work(system_wq, &lgr->free_work,\n+\t\t\t lgr->role == SMC_CLNT ? SMC_LGR_FREE_DELAY_CLNT :\n+\t\t\t\t\t\t SMC_LGR_FREE_DELAY_SERV);\n }\n \n static void smc_lgr_free_work(struct work_struct *work)\n","prefixes":["net","6/9"]}