{"id":816676,"url":"http://patchwork.ozlabs.org/api/patches/816676/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1505974414-6033-5-git-send-email-peterx@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1505974414-6033-5-git-send-email-peterx@redhat.com>","list_archive_url":null,"date":"2017-09-21T06:13:34","name":"[4/4] chardev: remove context in chr_update_read_handler","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"c6c2075c3cfeb9a0ddfe907605c51991ad2c73ae","submitter":{"id":67717,"url":"http://patchwork.ozlabs.org/api/people/67717/?format=json","name":"Peter Xu","email":"peterx@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1505974414-6033-5-git-send-email-peterx@redhat.com/mbox/","series":[{"id":4302,"url":"http://patchwork.ozlabs.org/api/series/4302/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=4302","date":"2017-09-21T06:13:30","name":"chardev: support non-default gcontext","version":1,"mbox":"http://patchwork.ozlabs.org/series/4302/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/816676/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/816676/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=peterx@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xyRHV44v3z9t3F\n\tfor ;\n\tThu, 21 Sep 2017 16:17:57 +1000 (AEST)","from localhost ([::1]:51980 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duuo6-0008Ru-2R\n\tfor incoming@patchwork.ozlabs.org; Thu, 21 Sep 2017 02:17:54 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:34179)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duukV-00060t-0n\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 02:14:12 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duukT-0008D2-UE\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 02:14:10 -0400","from mx1.redhat.com ([209.132.183.28]:37176)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1duukT-0008BN-MC\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 02:14:09 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id D5BA0356D6\n\tfor ; Thu, 21 Sep 2017 06:14:08 +0000 (UTC)","from pxdev.xzpeter.org.com (dhcp-15-224.nay.redhat.com\n\t[10.66.15.224])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 45EE35D6A4;\n\tThu, 21 Sep 2017 06:14:00 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com D5BA0356D6","From":"Peter Xu ","To":"qemu-devel@nongnu.org","Date":"Thu, 21 Sep 2017 14:13:34 +0800","Message-Id":"<1505974414-6033-5-git-send-email-peterx@redhat.com>","In-Reply-To":"<1505974414-6033-1-git-send-email-peterx@redhat.com>","References":"<1505974414-6033-1-git-send-email-peterx@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tThu, 21 Sep 2017 06:14:08 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH 4/4] chardev: remove context in\n\tchr_update_read_handler","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Juan Quintela , \"Dr . David Alan Gilbert\"\n\t, peterx@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_L?=\n\t=?utf-8?q?ureau?= ,\n\tPaolo Bonzini ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"We had a per-chardev cache for context, then we don't need this\nparameter to be passed in every time when chr_update_read_handler()\ncalled. As long as we are calling chr_update_read_handler() using\nqemu_chr_be_update_read_handlers() we'll be fine.\n\nSigned-off-by: Peter Xu \n---\n chardev/char-fd.c | 3 +--\n chardev/char-pty.c | 3 +--\n chardev/char-socket.c | 3 +--\n chardev/char-udp.c | 3 +--\n include/chardev/char.h | 2 +-\n 5 files changed, 5 insertions(+), 9 deletions(-)","diff":"diff --git a/chardev/char-fd.c b/chardev/char-fd.c\nindex 09fbb07..2c9b2ce 100644\n--- a/chardev/char-fd.c\n+++ b/chardev/char-fd.c\n@@ -84,8 +84,7 @@ static GSource *fd_chr_add_watch(Chardev *chr, GIOCondition cond)\n return qio_channel_create_watch(s->ioc_out, cond);\n }\n \n-static void fd_chr_update_read_handler(Chardev *chr,\n- GMainContext *context)\n+static void fd_chr_update_read_handler(Chardev *chr)\n {\n FDChardev *s = FD_CHARDEV(chr);\n \ndiff --git a/chardev/char-pty.c b/chardev/char-pty.c\nindex d239c04..761ae6d 100644\n--- a/chardev/char-pty.c\n+++ b/chardev/char-pty.c\n@@ -112,8 +112,7 @@ static void pty_chr_update_read_handler_locked(Chardev *chr)\n }\n }\n \n-static void pty_chr_update_read_handler(Chardev *chr,\n- GMainContext *context)\n+static void pty_chr_update_read_handler(Chardev *chr)\n {\n qemu_mutex_lock(&chr->chr_write_lock);\n pty_chr_update_read_handler_locked(chr);\ndiff --git a/chardev/char-socket.c b/chardev/char-socket.c\nindex ee71cbe..e65148f 100644\n--- a/chardev/char-socket.c\n+++ b/chardev/char-socket.c\n@@ -521,8 +521,7 @@ static void tcp_chr_connect(void *opaque)\n qemu_chr_be_event(chr, CHR_EVENT_OPENED);\n }\n \n-static void tcp_chr_update_read_handler(Chardev *chr,\n- GMainContext *context)\n+static void tcp_chr_update_read_handler(Chardev *chr)\n {\n SocketChardev *s = SOCKET_CHARDEV(chr);\n \ndiff --git a/chardev/char-udp.c b/chardev/char-udp.c\nindex 106dee1..d46ff7a 100644\n--- a/chardev/char-udp.c\n+++ b/chardev/char-udp.c\n@@ -100,8 +100,7 @@ static gboolean udp_chr_read(QIOChannel *chan, GIOCondition cond, void *opaque)\n return TRUE;\n }\n \n-static void udp_chr_update_read_handler(Chardev *chr,\n- GMainContext *context)\n+static void udp_chr_update_read_handler(Chardev *chr)\n {\n UdpChardev *s = UDP_CHARDEV(chr);\n \ndiff --git a/include/chardev/char.h b/include/chardev/char.h\nindex 84fb773..43aabcc 100644\n--- a/include/chardev/char.h\n+++ b/include/chardev/char.h\n@@ -238,7 +238,7 @@ typedef struct ChardevClass {\n int (*chr_write)(Chardev *s, const uint8_t *buf, int len);\n int (*chr_sync_read)(Chardev *s, const uint8_t *buf, int len);\n GSource *(*chr_add_watch)(Chardev *s, GIOCondition cond);\n- void (*chr_update_read_handler)(Chardev *s, GMainContext *context);\n+ void (*chr_update_read_handler)(Chardev *s);\n int (*chr_ioctl)(Chardev *s, int cmd, void *arg);\n int (*get_msgfds)(Chardev *s, int* fds, int num);\n int (*set_msgfds)(Chardev *s, int *fds, int num);\n","prefixes":["4/4"]}