{"id":816618,"url":"http://patchwork.ozlabs.org/api/patches/816618/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-mtd/patch/20170920224605.22030-12-ebiggers3@gmail.com/","project":{"id":3,"url":"http://patchwork.ozlabs.org/api/projects/3/?format=json","name":"Linux MTD development","link_name":"linux-mtd","list_id":"linux-mtd.lists.infradead.org","list_email":"linux-mtd@lists.infradead.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170920224605.22030-12-ebiggers3@gmail.com>","list_archive_url":null,"date":"2017-09-20T22:45:51","name":"[11/25] ext4: switch to fscrypt_file_open()","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"55457c9f204518c4dc16eb41c9bca43953948545","submitter":{"id":65202,"url":"http://patchwork.ozlabs.org/api/people/65202/?format=json","name":"Eric Biggers","email":"ebiggers3@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-mtd/patch/20170920224605.22030-12-ebiggers3@gmail.com/mbox/","series":[{"id":4250,"url":"http://patchwork.ozlabs.org/api/series/4250/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-mtd/list/?series=4250","date":"2017-09-20T22:45:45","name":"fscrypt: add some higher-level helper functions","version":1,"mbox":"http://patchwork.ozlabs.org/series/4250/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/816618/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/816618/checks/","tags":{},"related":[],"headers":{"Return-Path":"<linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"m9DIr8Uw\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=infradead.org header.i=@infradead.org\n\theader.b=\"y4Dco1aa\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"kLXBsgB/\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xyGjl6g0Sz9s7h\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 21 Sep 2017 09:51:39 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1duomF-0003l4-Q3; Wed, 20 Sep 2017 23:51:35 +0000","from merlin.infradead.org ([2001:8b0:10b:1231::1])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1duok6-0001Bu-Mr\n\tfor linux-mtd@bombadil.infradead.org; Wed, 20 Sep 2017 23:49:22 +0000","from mail-pg0-x243.google.com ([2607:f8b0:400e:c05::243])\n\tby merlin.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dunmC-00017O-QT\n\tfor linux-mtd@lists.infradead.org; Wed, 20 Sep 2017 22:47:29 +0000","by mail-pg0-x243.google.com with SMTP id m30so2366824pgn.5\n\tfor <linux-mtd@lists.infradead.org>;\n\tWed, 20 Sep 2017 15:47:05 -0700 (PDT)","from ebiggers-linuxstation.kir.corp.google.com ([100.66.174.81])\n\tby smtp.gmail.com with ESMTPSA id j2sm6249pgn.26.2017.09.20.15.47.02\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 20 Sep 2017 15:47:03 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References:\n\tIn-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Owner;\n\tbh=Mq6OznoBzyHNd04QK7qC70r891FEAApJZXO3oZYzH8g=;\n\tb=m9DIr8Uwej/knFc+a0yPlFF+V0\n\tqxYgOji6LOG5EW/8W09R+nz5JYsyCMAv9bmk4Yz1v3n+MKfsP7C2zpZrYhkZjOzLt3j2Eeo3Wq53J\n\t+BMhTemUb8P/qQPYjS/sHU3zvqwa/7WSJ55bSuZ7JEQLrV2rt0jCxyyxDSRUt4V7poZLD5cF7Z6m3\n\teqdfopHpPGmVLc8q7Wp/N8fnydUWt6n9wLw0X+hQrCQLAMWBtDojLTr6a6oMU/OMfcHb2LmekvZGb\n\tFXdi8ys5X3Xe1q6zHS1o7T6EXakOy3kAmTwp6CfMB0PaMLjE/FYqv3zjLj+1drHcnehwoUagTKMQS\n\tThq1WChA==;","v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=infradead.org; s=merlin.20170209;\n\th=References:In-Reply-To:Message-Id:Date:\n\tSubject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type:\n\tContent-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:\n\tList-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;\n\tbh=WkaWCp5pR1c59n1k9Hk5rcxNp21Vt5Cmt3ZJ6yMdHpg=;\n\tb=y4Dco1aai2WqZ3jgNPKuiYYVH\n\tvq69hMl2QH+d8+ZY7YfphC9Zsd7dfRKASiBxpUrLP4I2mq3jwKKTNezCMIm5f8A+DDFUbbXehdSki\n\t1K8UdUCZCfsN8G8YcD92rOwTD8t+wqP1mZuSkB5UzignlsmWVE/vRqBxDj7+RIFlxuIRTyjmZlisn\n\tI6PWWvIXinbj8TGwAjXf0fpenApYAG2KS4RVls76X5knxpio1Wv4zDtxdhuGGY/z3e1ccmLn6Lb+K\n\t1ct1+PFxpPdn2oi60OcYn0Rxar8IKAzKuZXRhpEA652+q9sJcg83EfCfmJCt007jGhXzSFUo3uQzc\n\tpqAReT2bw==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=WkaWCp5pR1c59n1k9Hk5rcxNp21Vt5Cmt3ZJ6yMdHpg=;\n\tb=kLXBsgB/KIfRmHIqIuxnfkunzMEUBshljntVnRWppmlvFvnCqE9uyePCu/uDvcrqXC\n\tmzOjBc67AoIS1Rw/HzG95KbZNWKhre/94h9xe2Q5leEZt6YFGYuTk2JN3i/Yj05ZrFoW\n\teC1ZDdc1OZ9UEYsfu6SwB+QQ4/sSqNrs48j/xGkCj9/OmONZmiWFTwRH4ClToC7+gFux\n\tX+7y/hBDRISv5gUJUoQ9X/u5Z+xz7QXZVRwlSsPMC79uKT1hNciWmx0Xx4bTwBYmsdeK\n\tLsEjYBS8LxYVYOnFK2VtCztbwG3jP84yZ5uAnJZK0IyiYIzze826phYFAjY69pkXxEMr\n\tR54g=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=WkaWCp5pR1c59n1k9Hk5rcxNp21Vt5Cmt3ZJ6yMdHpg=;\n\tb=J3tw1Oj2/c/GuiJkfHubxSGqeKMSI9ykSj2OpaHkjZVVSrEGKz4IitrQhHFznZyTBa\n\ttyON9kzIe4KB3UXYLaUGLRAXEW1vnTxx7qU9pLcGMkoBkgmD6gfInMk3X4RUKuoHeAnG\n\t9G+IFxiECq/BuQwMYlJVzLzOwfnzHTgxdCT22tK0tmox5ggvm5quVb1pGt+LtCNZRcZi\n\tRHDG69d1mnr4kbpWUJpwvkO2DyrujGK9M6aN3HAwjuFVtiubP8llxBXCONcHLwhEELaD\n\tigmTZPkBvrbIpv3in1EMOP64QrHrzc58elcXaQr5nzmFTj+NqA5FvoA3bOu2s5TUnANL\n\twXtg==","X-Gm-Message-State":"AHPjjUgHRsES7Xl/jDatP1bxHQdFjKJTrbMj1E+ybO2nPc9cv+zHR1O3\n\tjmL+b/iNkr4yTuH0YApAJZcA3IxUrus=","X-Google-Smtp-Source":"AOwi7QA1vfrMiRTSlpSYAT012BUIs2xUqd4Ah8lXY7/pjuw6Nn4/CBBg5+NwmSjxeVIX4w/6gywkvQ==","X-Received":"by 10.99.168.1 with SMTP id o1mr3640561pgf.72.1505947623552;\n\tWed, 20 Sep 2017 15:47:03 -0700 (PDT)","From":"Eric Biggers <ebiggers3@gmail.com>","To":"linux-fscrypt@vger.kernel.org","Subject":"[PATCH 11/25] ext4: switch to fscrypt_file_open()","Date":"Wed, 20 Sep 2017 15:45:51 -0700","Message-Id":"<20170920224605.22030-12-ebiggers3@gmail.com>","X-Mailer":"git-send-email 2.14.1.821.g8fa685d3b7-goog","In-Reply-To":"<20170920224605.22030-1-ebiggers3@gmail.com>","References":"<20170920224605.22030-1-ebiggers3@gmail.com>","X-Spam-Note":"CRM114 invocation failed","X-Spam-Score":"-1.8 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on merlin.infradead.org summary:\n\tContent analysis details:   (-1.8 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2607:f8b0:400e:c05:0:0:0:243 listed in] [list.dnswl.org]\n\t0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends\n\tin digit (ebiggers3[at]gmail.com)\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (ebiggers3[at]gmail.com)\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t0.1 DKIM_SIGNED            Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-mtd>,\n\t<mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-mtd/>","List-Post":"<mailto:linux-mtd@lists.infradead.org>","List-Help":"<mailto:linux-mtd-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-mtd>,\n\t<mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>","Cc":"\"Theodore Y . Ts'o\" <tytso@mit.edu>, Eric Biggers <ebiggers@google.com>, \n\tMichael Halcrow <mhalcrow@google.com>,\n\tlinux-f2fs-devel@lists.sourceforge.net, \n\tlinux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org,\n\tJaegeuk Kim <jaegeuk@kernel.org>, linux-ext4@vger.kernel.org","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" <linux-mtd-bounces@lists.infradead.org>","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"From: Eric Biggers <ebiggers@google.com>\n\nSigned-off-by: Eric Biggers <ebiggers@google.com>\n---\n fs/ext4/file.c | 23 ++++-------------------\n 1 file changed, 4 insertions(+), 19 deletions(-)","diff":"diff --git a/fs/ext4/file.c b/fs/ext4/file.c\nindex b1da660ac3bc..ffe9144088f8 100644\n--- a/fs/ext4/file.c\n+++ b/fs/ext4/file.c\n@@ -364,7 +364,6 @@ static int ext4_file_open(struct inode * inode, struct file * filp)\n \tstruct super_block *sb = inode->i_sb;\n \tstruct ext4_sb_info *sbi = EXT4_SB(inode->i_sb);\n \tstruct vfsmount *mnt = filp->f_path.mnt;\n-\tstruct dentry *dir;\n \tstruct path path;\n \tchar buf[64], *cp;\n \tint ret;\n@@ -404,25 +403,11 @@ static int ext4_file_open(struct inode * inode, struct file * filp)\n \t\t\text4_journal_stop(handle);\n \t\t}\n \t}\n-\tif (ext4_encrypted_inode(inode)) {\n-\t\tret = fscrypt_get_encryption_info(inode);\n-\t\tif (ret)\n-\t\t\treturn -EACCES;\n-\t\tif (!fscrypt_has_encryption_key(inode))\n-\t\t\treturn -ENOKEY;\n-\t}\n \n-\tdir = dget_parent(file_dentry(filp));\n-\tif (ext4_encrypted_inode(d_inode(dir)) &&\n-\t\t\t!fscrypt_has_permitted_context(d_inode(dir), inode)) {\n-\t\text4_warning(inode->i_sb,\n-\t\t\t     \"Inconsistent encryption contexts: %lu/%lu\",\n-\t\t\t     (unsigned long) d_inode(dir)->i_ino,\n-\t\t\t     (unsigned long) inode->i_ino);\n-\t\tdput(dir);\n-\t\treturn -EPERM;\n-\t}\n-\tdput(dir);\n+\tret = fscrypt_file_open(inode, filp);\n+\tif (ret)\n+\t\treturn ret;\n+\n \t/*\n \t * Set up the jbd2_inode if we are opening the inode for\n \t * writing and the journal is present\n","prefixes":["11/25"]}