{"id":816616,"url":"http://patchwork.ozlabs.org/api/patches/816616/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-mtd/patch/20170920224605.22030-19-ebiggers3@gmail.com/","project":{"id":3,"url":"http://patchwork.ozlabs.org/api/projects/3/?format=json","name":"Linux MTD development","link_name":"linux-mtd","list_id":"linux-mtd.lists.infradead.org","list_email":"linux-mtd@lists.infradead.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170920224605.22030-19-ebiggers3@gmail.com>","list_archive_url":null,"date":"2017-09-20T22:45:58","name":"[18/25] f2fs: switch to fscrypt_prepare_rename()","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"3868432b178d3f0843da2005a2418127e2740c4a","submitter":{"id":65202,"url":"http://patchwork.ozlabs.org/api/people/65202/?format=json","name":"Eric Biggers","email":"ebiggers3@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-mtd/patch/20170920224605.22030-19-ebiggers3@gmail.com/mbox/","series":[{"id":4250,"url":"http://patchwork.ozlabs.org/api/series/4250/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-mtd/list/?series=4250","date":"2017-09-20T22:45:45","name":"fscrypt: add some higher-level helper functions","version":1,"mbox":"http://patchwork.ozlabs.org/series/4250/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/816616/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/816616/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"MZHrlWAz\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=infradead.org header.i=@infradead.org\n\theader.b=\"gro3b2OH\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"cpblON3+\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xyGhx5gywz9sNr\n\tfor ;\n\tThu, 21 Sep 2017 09:50:57 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1duolT-0003BD-RM; Wed, 20 Sep 2017 23:50:47 +0000","from merlin.infradead.org ([2001:8b0:10b:1231::1])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1duok3-0001Bu-24\n\tfor linux-mtd@bombadil.infradead.org; Wed, 20 Sep 2017 23:49:19 +0000","from mail-pf0-x241.google.com ([2607:f8b0:400e:c00::241])\n\tby merlin.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dunmF-00017e-OI\n\tfor linux-mtd@lists.infradead.org; Wed, 20 Sep 2017 22:47:32 +0000","by mail-pf0-x241.google.com with SMTP id e69so1716526pfg.4\n\tfor ;\n\tWed, 20 Sep 2017 15:47:12 -0700 (PDT)","from ebiggers-linuxstation.kir.corp.google.com ([100.66.174.81])\n\tby smtp.gmail.com with ESMTPSA id j2sm6249pgn.26.2017.09.20.15.47.09\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 20 Sep 2017 15:47:10 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References:\n\tIn-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Owner;\n\tbh=z/8AFhEIqCWXay4+d6rmpvEVDuFWPrnUWEVSiKqJsSU=;\n\tb=MZHrlWAzK6ERvmcDn82uRbK9dg\n\tse8qFaH6USX6uEopeN3ko+ypBgSm9vxn6AA/PPpWlH3JgAmZ/JlEeHEbGtf1K334OgntzVFm0WgGk\n\tlpkoN6l6b5N0t7YLjtrR4FvjEizs+qt3O8layRofB8yFeGcCEcDDowhqfNvgrVkcKRgSt0MDG+EIS\n\tQmWft5y3yZ9YiYtzsXaM+VBmktIKO/tlqZc1lgJox2pidQmPz3mjQN9mgV8jsSYHeLnetlUwXUmUE\n\twkuJm0Hzo/PXy58mFFnKhNHsFUGzOHZWuefBn7WdXJI7NcfWZ68gEExT6edi4UE0lE4MlLpjoI1DP\n\tEolgqAJg==;","v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=infradead.org; s=merlin.20170209;\n\th=References:In-Reply-To:Message-Id:Date:\n\tSubject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type:\n\tContent-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:\n\tList-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;\n\tbh=gxgNvumxJG5UwVuKFZNruBWfCDgQCgm7TqKy9BGQaxs=;\n\tb=gro3b2OH6vy+aAhHge/IYbe+Z\n\td1xQ/kF5gz0Zoy5uYhP+AW9VkYculwBCQEf+QG54nAfQMU3DQulMo1C8MsY3Cz9kORZtUn4i5jrLK\n\t4GWpHM/o2OWxbiASaHx7KAk9u3Q0EgoRBjhSbVYHrTv7FChCQFoYrsBTkUMS1jkUkCXeRjyahNffv\n\t2n9lww3xRvkN7suf98ga3IC2xIj3OxA/R2d2duusF8aB91bWQnzG3du5LnC3m1b1w3VaDUgbW3K6j\n\twM1O/rnA3GBdLjL1aueyO3QQN4USFiSTSlwQ4jGAiW52KqJLWhBYoXU8216DuR9nWD06QJT8KOlis\n\tIxG285t+g==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=gxgNvumxJG5UwVuKFZNruBWfCDgQCgm7TqKy9BGQaxs=;\n\tb=cpblON3++MUNGT0cpXapFnrlewX2SNUVM5d981MO0wzGIJKN3S4TU/V90fP0RMJ1U6\n\tH3TDtidEC/+woPb0RYNcbWwH3aOloJBnYjxAUA64AthED0QZMkJWet/+CeL4Ysw8v6Yr\n\txYVLu6xJ12h4IyVV1ywyZ5pEPoC/6YQbraOPE8HXX9uyH9PH2ZZ++8Dr3//6gzk+jvo+\n\t8SYIqDJLwxDuBYwuzs6WSModh4cDj6qDytHMghU1WFB+MWKE1518BXgf2oyo69XsCz3P\n\tuSuGif6dW8nm0OW9kowaCvVuAptI6eUTd8lWi8ZBs7E1QRV308ZT4dyb4BWsRylOTq/m\n\t5RaQ=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=gxgNvumxJG5UwVuKFZNruBWfCDgQCgm7TqKy9BGQaxs=;\n\tb=GTpcuhdd/9J07zrwAWR6XbhSfghl1YezUPArKFHR8LdoJdcQdChXFYrYcgAQz9IypA\n\tKwD0STfXLDV0p280506lqQ6chZ1Puk4iKSzezL2SXuitY7qxpRmmhxifdDMMIMhxCok7\n\tGb2Ee8Tyaog2cRScXyP88Likd7pGLY/dah45bx6/XHtHA/G1b7bL/h4RzYS1MH1WFcxN\n\tLI21juXZWS/KdJ7G2rH+p6vFOqrq4B4YTih+WQb7jIahX96vJvYGrQ9B8UW40A95puAI\n\tzyarbf2tCWmFbRCvX/M/UwjFe6L5ZQ0e0FanqkBlBjO3FOUaKMFf83jpZZK6rMJ6U2bR\n\tlkfQ==","X-Gm-Message-State":"AHPjjUgdzPNwzA/PwzcbhNFg2B9Qag6bzjzTs/2C1rGmiLvZe612YVVh\n\tY4yKToOnZxVa4ok5rEP4wMI=","X-Google-Smtp-Source":"AOwi7QCdxAMGKHk3stdDkAPZbeyac5aMI6I43R1YGzPIaBN0tg1mvnqe5aup5OkFBsFQpRYEnszSpw==","X-Received":"by 10.98.135.194 with SMTP id i185mr3619483pfe.330.1505947630513;\n\tWed, 20 Sep 2017 15:47:10 -0700 (PDT)","From":"Eric Biggers ","To":"linux-fscrypt@vger.kernel.org","Subject":"[PATCH 18/25] f2fs: switch to fscrypt_prepare_rename()","Date":"Wed, 20 Sep 2017 15:45:58 -0700","Message-Id":"<20170920224605.22030-19-ebiggers3@gmail.com>","X-Mailer":"git-send-email 2.14.1.821.g8fa685d3b7-goog","In-Reply-To":"<20170920224605.22030-1-ebiggers3@gmail.com>","References":"<20170920224605.22030-1-ebiggers3@gmail.com>","X-Spam-Note":"CRM114 invocation failed","X-Spam-Score":"-1.8 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on merlin.infradead.org summary:\n\tContent analysis details: (-1.8 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2607:f8b0:400e:c00:0:0:0:241 listed in] [list.dnswl.org]\n\t0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends\n\tin digit (ebiggers3[at]gmail.com)\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (ebiggers3[at]gmail.com)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"\"Theodore Y . Ts'o\" , Eric Biggers , \n\tMichael Halcrow ,\n\tlinux-f2fs-devel@lists.sourceforge.net, \n\tlinux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org,\n\tJaegeuk Kim , linux-ext4@vger.kernel.org","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"From: Eric Biggers \n\nSigned-off-by: Eric Biggers \n---\n fs/f2fs/namei.c | 31 +++++++------------------------\n 1 file changed, 7 insertions(+), 24 deletions(-)","diff":"diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c\nindex cf4e4294e450..80bcf2185fd8 100644\n--- a/fs/f2fs/namei.c\n+++ b/fs/f2fs/namei.c\n@@ -742,18 +742,6 @@ static int f2fs_rename(struct inode *old_dir, struct dentry *old_dentry,\n \tbool is_old_inline = f2fs_has_inline_dentry(old_dir);\n \tint err = -ENOENT;\n \n-\tif ((f2fs_encrypted_inode(old_dir) &&\n-\t\t\t!fscrypt_has_encryption_key(old_dir)) ||\n-\t\t\t(f2fs_encrypted_inode(new_dir) &&\n-\t\t\t!fscrypt_has_encryption_key(new_dir)))\n-\t\treturn -ENOKEY;\n-\n-\tif ((old_dir != new_dir) && f2fs_encrypted_inode(new_dir) &&\n-\t\t\t!fscrypt_has_permitted_context(new_dir, old_inode)) {\n-\t\terr = -EPERM;\n-\t\tgoto out;\n-\t}\n-\n \tif (is_inode_flag_set(new_dir, FI_PROJ_INHERIT) &&\n \t\t\t(!projid_eq(F2FS_I(new_dir)->i_projid,\n \t\t\tF2FS_I(old_dentry->d_inode)->i_projid)))\n@@ -935,18 +923,6 @@ static int f2fs_cross_rename(struct inode *old_dir, struct dentry *old_dentry,\n \tint old_nlink = 0, new_nlink = 0;\n \tint err = -ENOENT;\n \n-\tif ((f2fs_encrypted_inode(old_dir) &&\n-\t\t\t!fscrypt_has_encryption_key(old_dir)) ||\n-\t\t\t(f2fs_encrypted_inode(new_dir) &&\n-\t\t\t!fscrypt_has_encryption_key(new_dir)))\n-\t\treturn -ENOKEY;\n-\n-\tif ((f2fs_encrypted_inode(old_dir) || f2fs_encrypted_inode(new_dir)) &&\n-\t\t\t(old_dir != new_dir) &&\n-\t\t\t(!fscrypt_has_permitted_context(new_dir, old_inode) ||\n-\t\t\t !fscrypt_has_permitted_context(old_dir, new_inode)))\n-\t\treturn -EPERM;\n-\n \tif ((is_inode_flag_set(new_dir, FI_PROJ_INHERIT) &&\n \t\t\t!projid_eq(F2FS_I(new_dir)->i_projid,\n \t\t\tF2FS_I(old_dentry->d_inode)->i_projid)) ||\n@@ -1086,9 +1062,16 @@ static int f2fs_rename2(struct inode *old_dir, struct dentry *old_dentry,\n \t\t\tstruct inode *new_dir, struct dentry *new_dentry,\n \t\t\tunsigned int flags)\n {\n+\tint err;\n+\n \tif (flags & ~(RENAME_NOREPLACE | RENAME_EXCHANGE | RENAME_WHITEOUT))\n \t\treturn -EINVAL;\n \n+\terr = fscrypt_prepare_rename(old_dir, old_dentry, new_dir, new_dentry,\n+\t\t\t\t flags);\n+\tif (err)\n+\t\treturn err;\n+\n \tif (flags & RENAME_EXCHANGE) {\n \t\treturn f2fs_cross_rename(old_dir, old_dentry,\n \t\t\t\t\t new_dir, new_dentry);\n","prefixes":["18/25"]}