{"id":816590,"url":"http://patchwork.ozlabs.org/api/patches/816590/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-mtd/patch/20170920224605.22030-26-ebiggers3@gmail.com/","project":{"id":3,"url":"http://patchwork.ozlabs.org/api/projects/3/?format=json","name":"Linux MTD development","link_name":"linux-mtd","list_id":"linux-mtd.lists.infradead.org","list_email":"linux-mtd@lists.infradead.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170920224605.22030-26-ebiggers3@gmail.com>","list_archive_url":null,"date":"2017-09-20T22:46:05","name":"[25/25] ubifs: switch to fscrypt_prepare_setattr()","commit_ref":null,"pull_url":null,"state":"deferred","archived":false,"hash":"53cdaf7a7e898faa705a246ee7f732d68abdaafc","submitter":{"id":65202,"url":"http://patchwork.ozlabs.org/api/people/65202/?format=json","name":"Eric Biggers","email":"ebiggers3@gmail.com"},"delegate":{"id":54851,"url":"http://patchwork.ozlabs.org/api/users/54851/?format=json","username":"rw","first_name":"Richard","last_name":"Weinberger","email":"richard@nod.at"},"mbox":"http://patchwork.ozlabs.org/project/linux-mtd/patch/20170920224605.22030-26-ebiggers3@gmail.com/mbox/","series":[{"id":4250,"url":"http://patchwork.ozlabs.org/api/series/4250/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-mtd/list/?series=4250","date":"2017-09-20T22:45:45","name":"fscrypt: add some higher-level helper functions","version":1,"mbox":"http://patchwork.ozlabs.org/series/4250/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/816590/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/816590/checks/","tags":{},"related":[],"headers":{"Return-Path":"<linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"flcfXWE3\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"D7tzOiAI\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xyFWF46S4z9sBZ\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 21 Sep 2017 08:57:29 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dunvo-00079E-SB; Wed, 20 Sep 2017 22:57:24 +0000","from mail-pg0-f67.google.com ([74.125.83.67])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dunmN-000586-HH\n\tfor linux-mtd@lists.infradead.org; Wed, 20 Sep 2017 22:47:46 +0000","by mail-pg0-f67.google.com with SMTP id v5so2365634pgn.4\n\tfor <linux-mtd@lists.infradead.org>;\n\tWed, 20 Sep 2017 15:47:18 -0700 (PDT)","from ebiggers-linuxstation.kir.corp.google.com ([100.66.174.81])\n\tby smtp.gmail.com with ESMTPSA id j2sm6249pgn.26.2017.09.20.15.47.17\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 20 Sep 2017 15:47:17 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References:\n\tIn-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Owner;\n\tbh=zUe6S76jpq9iM715YXcfGFG1ZJXt86K/ZU/TIY1SWlQ=;\n\tb=flcfXWE3xYfF9y4u73Vc/CI7lk\n\t/Zq/FwsbPHEY4wFRlOxUXWZMO1CAyZuHfCQw6+Cpa8zDi1RSV8ENnUpQTcZ5Ij5RvXWC8GjeRvmSx\n\tFwKscY1RuQlKWFTUUDzWWQgn+mnK+kO1sVAAxdnuTW6xDDoc9uABzSYVQhyIpPK3WnHebBkInNxAV\n\tf4GcowcEEj4NvZXlkDzQ1t/yPqS/kzToh6Dc+DT1dpzyc1ooF9T+wgU5AKsrctk3dcpxlVpZnx9rz\n\tUzZW+HZwf3qSmTTv2rNwxcG2aI3h7zHS3szmCvTS2F8fDM2JCoguY6upGYZU/NR6MXboiIQcaaufN\n\tU5hUsO9Q==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=XznOxbscM+Guz7zyOXZEtQLXMiA7EjYNtJ+c92S6E2g=;\n\tb=D7tzOiAIDtv8O95WdUO+BrCXDAqYvOu/MKUWr37+QByGJrRobenputFeMHEpiaySTl\n\t7TLsHNYVt47q/lOQNhZXqh3gKoh7aKBQZprHH5mh0tcqg00qWbtsALNb1HWDU7cazncd\n\txTlQdxPoCX+RLwN8BeZ01amwu9pEh8KCvv7N/HxC454CErpqQ5X5JhqDXPDvr4356a+e\n\t0nahPMHmsXWTsQBPIzi4RQbIQMg9sNCJBbXJY8+2DGjsLjlX0YDWxaIg6a/uhrRlEdvi\n\t1Wueop06sTeqrEA3+lDz/mCTsoefwLN5idbCiTzF9zdj9acZ08PFZFHUF1AElMPquEBg\n\tcVRQ=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=XznOxbscM+Guz7zyOXZEtQLXMiA7EjYNtJ+c92S6E2g=;\n\tb=Iu2rK68POEXhedFGwF59Us/ca5XXPTp6A+atCUCgBjSo5cue5B/UU6rOOsD3cQM8CI\n\tm7EHxGapPi4VgQj4VT36BAmbBen1AMAocSR3MW5b0D2DnsSNjNZfDnl3OCcHs2JTg38F\n\txhPPTt6qe6aZw9UnCfeo+YMDSYeFMsnsU6P6VAjfxIDYOGYExDhgXu8ac8XaX9U0yUed\n\tj8eiZyRChRn8xO6vIGtaW1o40L06inQQUi/uKd9g2+2PyFTSQWLpzxYzINUxjoPTkuJe\n\tLdDIa1qMaIBup7QjGcSzzPrVJYmqBSSKBG566H95BppnTqMfG+X0MPjPfMtRRuuK/E3T\n\twZiA==","X-Gm-Message-State":"AHPjjUhaE76Vg2iwPGjBzuhHAuMIp2AXTwXnvnOVTFxAXVdMg6FZ5x4O\n\tznxK5pOvm5f5/aLD8ACBToI=","X-Google-Smtp-Source":"AOwi7QCsWbwbVr0eemv3tcaQWLmjvNRB+oCcrRAR5Ouepwi5z66gjMJabzhiWBxFghiiLSXtrqrPHQ==","X-Received":"by 10.84.143.165 with SMTP id 34mr3393170plz.91.1505947638274;\n\tWed, 20 Sep 2017 15:47:18 -0700 (PDT)","From":"Eric Biggers <ebiggers3@gmail.com>","To":"linux-fscrypt@vger.kernel.org","Subject":"[PATCH 25/25] ubifs: switch to fscrypt_prepare_setattr()","Date":"Wed, 20 Sep 2017 15:46:05 -0700","Message-Id":"<20170920224605.22030-26-ebiggers3@gmail.com>","X-Mailer":"git-send-email 2.14.1.821.g8fa685d3b7-goog","In-Reply-To":"<20170920224605.22030-1-ebiggers3@gmail.com>","References":"<20170920224605.22030-1-ebiggers3@gmail.com>","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170920_154740_885413_5FA90FB4 ","X-CRM114-Status":"UNSURE (   9.42  )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-1.3 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-1.3 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t0.5 RCVD_IN_SORBS_SPAM     RBL: SORBS: sender is a spam source\n\t[74.125.83.67 listed in dnsbl.sorbs.net]\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno trust [74.125.83.67 listed in list.dnswl.org]\n\t-0.0 RCVD_IN_MSPIKE_H3      RBL: Good reputation (+3)\n\t[74.125.83.67 listed in wl.mailspike.net]\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends\n\tin digit (ebiggers3[at]gmail.com)\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (ebiggers3[at]gmail.com)\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED            Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's\n\tdomain -0.0 RCVD_IN_MSPIKE_WL      Mailspike good senders","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-mtd>,\n\t<mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-mtd/>","List-Post":"<mailto:linux-mtd@lists.infradead.org>","List-Help":"<mailto:linux-mtd-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-mtd>,\n\t<mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>","Cc":"\"Theodore Y . Ts'o\" <tytso@mit.edu>, Eric Biggers <ebiggers@google.com>, \n\tMichael Halcrow <mhalcrow@google.com>,\n\tlinux-f2fs-devel@lists.sourceforge.net, \n\tlinux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org,\n\tJaegeuk Kim <jaegeuk@kernel.org>, linux-ext4@vger.kernel.org","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" <linux-mtd-bounces@lists.infradead.org>","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"From: Eric Biggers <ebiggers@google.com>\n\nSigned-off-by: Eric Biggers <ebiggers@google.com>\n---\n fs/ubifs/file.c | 10 +++-------\n 1 file changed, 3 insertions(+), 7 deletions(-)","diff":"diff --git a/fs/ubifs/file.c b/fs/ubifs/file.c\nindex 31dc632a52fc..f5578f1bd170 100644\n--- a/fs/ubifs/file.c\n+++ b/fs/ubifs/file.c\n@@ -1284,13 +1284,9 @@ int ubifs_setattr(struct dentry *dentry, struct iattr *attr)\n \tif (err)\n \t\treturn err;\n \n-\tif (ubifs_crypt_is_encrypted(inode) && (attr->ia_valid & ATTR_SIZE)) {\n-\t\terr = fscrypt_get_encryption_info(inode);\n-\t\tif (err)\n-\t\t\treturn err;\n-\t\tif (!fscrypt_has_encryption_key(inode))\n-\t\t\treturn -ENOKEY;\n-\t}\n+\terr = fscrypt_prepare_setattr(dentry, attr);\n+\tif (err)\n+\t\treturn err;\n \n \tif ((attr->ia_valid & ATTR_SIZE) && attr->ia_size < inode->i_size)\n \t\t/* Truncation to a smaller size */\n","prefixes":["25/25"]}