{"id":816567,"url":"http://patchwork.ozlabs.org/api/patches/816567/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-mtd/patch/20170920224605.22030-5-ebiggers3@gmail.com/","project":{"id":3,"url":"http://patchwork.ozlabs.org/api/projects/3/?format=json","name":"Linux MTD development","link_name":"linux-mtd","list_id":"linux-mtd.lists.infradead.org","list_email":"linux-mtd@lists.infradead.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170920224605.22030-5-ebiggers3@gmail.com>","list_archive_url":null,"date":"2017-09-20T22:45:44","name":"[04/25] fscrypt: remove unneeded empty fscrypt_operations structs","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"47dab89e4983eae3848d49c6373225257a419d97","submitter":{"id":65202,"url":"http://patchwork.ozlabs.org/api/people/65202/?format=json","name":"Eric Biggers","email":"ebiggers3@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-mtd/patch/20170920224605.22030-5-ebiggers3@gmail.com/mbox/","series":[{"id":4250,"url":"http://patchwork.ozlabs.org/api/series/4250/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-mtd/list/?series=4250","date":"2017-09-20T22:45:45","name":"fscrypt: add some higher-level helper functions","version":1,"mbox":"http://patchwork.ozlabs.org/series/4250/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/816567/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/816567/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"NuQjh8ti\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"T1MN2p+Q\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xyFL66FxFz9sNr\n\tfor ;\n\tThu, 21 Sep 2017 08:49:31 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1duno2-0006Z2-49; Wed, 20 Sep 2017 22:49:22 +0000","from mail-pf0-x244.google.com ([2607:f8b0:400e:c00::244])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dunm0-0004wk-1V\n\tfor linux-mtd@lists.infradead.org; Wed, 20 Sep 2017 22:47:26 +0000","by mail-pf0-x244.google.com with SMTP id a7so1717632pfj.5\n\tfor ;\n\tWed, 20 Sep 2017 15:46:56 -0700 (PDT)","from ebiggers-linuxstation.kir.corp.google.com ([100.66.174.81])\n\tby smtp.gmail.com with ESMTPSA id j2sm6249pgn.26.2017.09.20.15.46.54\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 20 Sep 2017 15:46:55 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References:\n\tIn-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Owner;\n\tbh=oxpLtdmIz0cDJZh8zO/WwYJPnQ6+O8O2VobWLyIA3DA=;\n\tb=NuQjh8ti08/CP82J/Ala9/OB81\n\tJjoBOU9rA0O6f/Pul77BelTYH52cTtlng3UHrZycCQnwA6vpLzQbjGDbB2ufUtPAqn/Y/Aciuihpk\n\tv6G23JtlvEBVCBPMJBOGv6/1WgElzXvVm5ka5D1l7Rm5mx7UrT/mR2iUN+Irh7hu4T/T4IvQwOeXd\n\td8r90ptnRK3z6LvoSmdol0w6VZnLfyYnyqtxU0jCf5kKGpuDPbgs5LBndX9K4fxmWrQ6mfHMHZS4k\n\tOXpj90D3fxdgWuVpcxH2E2tJDgkLuod8ybzossgLUAhfeCAekQMM3293mXPKyM3O0pkNwdNkSexhj\n\tilwami5Q==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=MFzqJPTBM9fATpbCj1G1R6q2eqPueC9M9keqxOOH+CI=;\n\tb=T1MN2p+QWVqe7J199P+C/wgLIrUGBCcIOGaHif7LdWVwAC/5GkJfn9rDi6kCh9ko1G\n\tWgewNp62f1e2n790usAbMfq4PLNlZoMeKuaQWK2Y/L3uO3h3ZAh+11NkiQmxQXsamugi\n\trz7EUV2Vld49iAYMpzc1Df/yHB19iGjGMUtcf+lYIbbHwuSDiQaJ8xFVMcSWzPs4UNBV\n\t9zgA6zoY6RnmzQQg97Ga2O9T1xgBDUqzppIBds6eOfXKBLUG192exMH+ar+ARqFRPRyN\n\tcj7rZECyWEBQQsjvo3enZZ0Q3ew7DX2pr4pTjtuPCkF1FdPI26lm9LNR0ljhVNdXGQza\n\tkE0g=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=MFzqJPTBM9fATpbCj1G1R6q2eqPueC9M9keqxOOH+CI=;\n\tb=F6jY058zmMJ+FsHrlWyysE96AHqH14yf+VAw8mX7CZqkxJUDbKT9sFKCwr1C6m0jjc\n\tWOWCYWwtQPvWxh4JTnId1yQ5H/5Wa9gzaMpcgf5Ckt5KqKJyxDIGQ65f8Bj75Z7bcenS\n\t3uz90bRHi7IeYUgc5IKXq1ytMGPdMU623QuUKACenUy7CTFUMFrQjCynZTZCFPOtqSx5\n\tngKwfzDKcnxrDfY2trMFukCATm02x0WwWfUGQKB6Affl76AtMY8ZJTIH103ymdf7cMWZ\n\tyQt+yN8relCvNyRcxpXY8cYc9XIzXytdCNjKeXr6BBpm741dBgcikr6T0asjssHv5tXm\n\tdV6Q==","X-Gm-Message-State":"AHPjjUgf/CCgX5cZoJVoCMEhZ6L7LIypB+843AAGkRmf1ZqxU6B3vXBg\n\tJsakSXSFw6dgviYHWj8R9Bc=","X-Google-Smtp-Source":"AOwi7QBvaEXywaWbPrbZC2q4FHGeQS7Li62DVLnS06ZS2mDKr0CJJekqsKjGtEx+kBuln+hJ+uFAFQ==","X-Received":"by 10.159.216.146 with SMTP id s18mr3499414plp.451.1505947615604;\n\tWed, 20 Sep 2017 15:46:55 -0700 (PDT)","From":"Eric Biggers ","To":"linux-fscrypt@vger.kernel.org","Subject":"[PATCH 04/25] fscrypt: remove unneeded empty fscrypt_operations\n\tstructs","Date":"Wed, 20 Sep 2017 15:45:44 -0700","Message-Id":"<20170920224605.22030-5-ebiggers3@gmail.com>","X-Mailer":"git-send-email 2.14.1.821.g8fa685d3b7-goog","In-Reply-To":"<20170920224605.22030-1-ebiggers3@gmail.com>","References":"<20170920224605.22030-1-ebiggers3@gmail.com>","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170920_154716_292147_B0143467 ","X-CRM114-Status":"GOOD ( 10.60 )","X-Spam-Score":"-1.8 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.8 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2607:f8b0:400e:c00:0:0:0:244 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends\n\tin digit (ebiggers3[at]gmail.com)\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (ebiggers3[at]gmail.com)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"\"Theodore Y . Ts'o\" , Eric Biggers , \n\tMichael Halcrow ,\n\tlinux-f2fs-devel@lists.sourceforge.net, \n\tlinux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org,\n\tJaegeuk Kim , linux-ext4@vger.kernel.org","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"From: Eric Biggers \n\nIn the case where a filesystem has been configured without encryption\nsupport, there is no longer any need to initialize ->s_cop at all, since\nnone of the methods are ever called.\n\nSigned-off-by: Eric Biggers \n---\n fs/ext4/super.c | 5 ++---\n fs/f2fs/super.c | 5 ++---\n fs/ubifs/super.c | 7 ++-----\n 3 files changed, 6 insertions(+), 11 deletions(-)","diff":"diff --git a/fs/ext4/super.c b/fs/ext4/super.c\nindex bc63cdf194e3..04f3670748e7 100644\n--- a/fs/ext4/super.c\n+++ b/fs/ext4/super.c\n@@ -1244,9 +1244,6 @@ static const struct fscrypt_operations ext4_cryptops = {\n \t.empty_dir\t\t= ext4_empty_dir,\n \t.max_namelen\t\t= ext4_max_namelen,\n };\n-#else\n-static const struct fscrypt_operations ext4_cryptops = {\n-};\n #endif\n \n #ifdef CONFIG_QUOTA\n@@ -3998,7 +3995,9 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)\n \tsb->s_op = &ext4_sops;\n \tsb->s_export_op = &ext4_export_ops;\n \tsb->s_xattr = ext4_xattr_handlers;\n+#ifdef CONFIG_EXT4_FS_ENCRYPTION\n \tsb->s_cop = &ext4_cryptops;\n+#endif\n #ifdef CONFIG_QUOTA\n \tsb->dq_op = &ext4_quota_operations;\n \tif (ext4_has_feature_quota(sb))\ndiff --git a/fs/f2fs/super.c b/fs/f2fs/super.c\nindex 1cb41f711ab8..c1c7183b3527 100644\n--- a/fs/f2fs/super.c\n+++ b/fs/f2fs/super.c\n@@ -1597,9 +1597,6 @@ static const struct fscrypt_operations f2fs_cryptops = {\n \t.empty_dir\t= f2fs_empty_dir,\n \t.max_namelen\t= f2fs_max_namelen,\n };\n-#else\n-static const struct fscrypt_operations f2fs_cryptops = {\n-};\n #endif\n \n static struct inode *f2fs_nfs_get_inode(struct super_block *sb,\n@@ -2318,7 +2315,9 @@ static int f2fs_fill_super(struct super_block *sb, void *data, int silent)\n #endif\n \n \tsb->s_op = &f2fs_sops;\n+#ifdef CONFIG_F2FS_FS_ENCRYPTION\n \tsb->s_cop = &f2fs_cryptops;\n+#endif\n \tsb->s_xattr = f2fs_xattr_handlers;\n \tsb->s_export_op = &f2fs_export_ops;\n \tsb->s_magic = F2FS_SUPER_MAGIC;\ndiff --git a/fs/ubifs/super.c b/fs/ubifs/super.c\nindex adaca6088836..7503e7cdf870 100644\n--- a/fs/ubifs/super.c\n+++ b/fs/ubifs/super.c\n@@ -2007,11 +2007,6 @@ static struct ubifs_info *alloc_ubifs_info(struct ubi_volume_desc *ubi)\n \treturn c;\n }\n \n-#ifndef CONFIG_UBIFS_FS_ENCRYPTION\n-const struct fscrypt_operations ubifs_crypt_operations = {\n-};\n-#endif\n-\n static int ubifs_fill_super(struct super_block *sb, void *data, int silent)\n {\n \tstruct ubifs_info *c = sb->s_fs_info;\n@@ -2054,7 +2049,9 @@ static int ubifs_fill_super(struct super_block *sb, void *data, int silent)\n \t\tsb->s_maxbytes = c->max_inode_sz = MAX_LFS_FILESIZE;\n \tsb->s_op = &ubifs_super_operations;\n \tsb->s_xattr = ubifs_xattr_handlers;\n+#ifdef CONFIG_UBIFS_FS_ENCRYPTION\n \tsb->s_cop = &ubifs_crypt_operations;\n+#endif\n \n \tmutex_lock(&c->umount_mutex);\n \terr = mount_ubifs(c);\n","prefixes":["04/25"]}