{"id":816453,"url":"http://patchwork.ozlabs.org/api/patches/816453/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20170920201714.19817-5-pasha.tatashin@oracle.com/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<20170920201714.19817-5-pasha.tatashin@oracle.com>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/20170920201714.19817-5-pasha.tatashin@oracle.com/","date":"2017-09-20T20:17:06","name":"[v9,04/12] sparc64: simplify vmemmap_populate","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"0c078a5f0fc69521f1f577e4987c38edab41164b","submitter":{"id":71010,"url":"http://patchwork.ozlabs.org/api/people/71010/?format=json","name":"Pavel Tatashin","email":"pasha.tatashin@oracle.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20170920201714.19817-5-pasha.tatashin@oracle.com/mbox/","series":[{"id":4225,"url":"http://patchwork.ozlabs.org/api/series/4225/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=4225","date":"2017-09-20T20:17:06","name":"complete deferred page initialization","version":9,"mbox":"http://patchwork.ozlabs.org/series/4225/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/816453/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/816453/checks/","tags":{},"related":[],"headers":{"Return-Path":"<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xyB2N129Vz9sPm\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu, 21 Sep 2017 06:20:44 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xyB2L0mShzDqSL\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu, 21 Sep 2017 06:20:42 +1000 (AEST)","from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xy9zp2bzvzDqSL\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tThu, 21 Sep 2017 06:18:29 +1000 (AEST)","from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234])\n\tby aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2)\n\twith ESMTP id v8KKHR1O011377\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Wed, 20 Sep 2017 20:17:28 GMT","from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75])\n\tby aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id v8KKHRi9021156\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Wed, 20 Sep 2017 20:17:27 GMT","from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14])\n\tby userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id\n\tv8KKHQ2q011250; Wed, 20 Sep 2017 20:17:26 GMT","from xakep.us.oracle.com (/10.154.127.176)\n\tby default (Oracle Beehive Gateway v4.0)\n\twith ESMTP ; Wed, 20 Sep 2017 13:17:25 -0700"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=oracle.com\n\t(client-ip=141.146.126.69; helo=aserp1040.oracle.com;\n\tenvelope-from=pasha.tatashin@oracle.com; receiver=<UNKNOWN>)","From":"Pavel Tatashin <pasha.tatashin@oracle.com>","To":"linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org,\n\tlinux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org,\n\tlinux-s390@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tx86@kernel.org, kasan-dev@googlegroups.com, borntraeger@de.ibm.com,\n\theiko.carstens@de.ibm.com, davem@davemloft.net, willy@infradead.org, \n\tmhocko@kernel.org, ard.biesheuvel@linaro.org, mark.rutland@arm.com,\n\twill.deacon@arm.com, catalin.marinas@arm.com, sam@ravnborg.org,\n\tmgorman@techsingularity.net, steven.sistare@oracle.com,\n\tdaniel.m.jordan@oracle.com, bob.picco@oracle.com","Subject":"[PATCH v9 04/12] sparc64: simplify vmemmap_populate","Date":"Wed, 20 Sep 2017 16:17:06 -0400","Message-Id":"<20170920201714.19817-5-pasha.tatashin@oracle.com>","X-Mailer":"git-send-email 2.14.1","In-Reply-To":"<20170920201714.19817-1-pasha.tatashin@oracle.com>","References":"<20170920201714.19817-1-pasha.tatashin@oracle.com>","X-Source-IP":"aserv0022.oracle.com [141.146.126.234]","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>","List-Unsubscribe":"<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>","List-Archive":"<http://lists.ozlabs.org/pipermail/linuxppc-dev/>","List-Post":"<mailto:linuxppc-dev@lists.ozlabs.org>","List-Help":"<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>","List-Subscribe":"<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>"},"content":"Remove duplicating code by using common functions\nvmemmap_pud_populate and vmemmap_pgd_populate.\n\nSigned-off-by: Pavel Tatashin <pasha.tatashin@oracle.com>\nReviewed-by: Steven Sistare <steven.sistare@oracle.com>\nReviewed-by: Daniel Jordan <daniel.m.jordan@oracle.com>\nReviewed-by: Bob Picco <bob.picco@oracle.com>\nAcked-by: David S. Miller <davem@davemloft.net>\n---\n arch/sparc/mm/init_64.c | 23 ++++++-----------------\n 1 file changed, 6 insertions(+), 17 deletions(-)","diff":"diff --git a/arch/sparc/mm/init_64.c b/arch/sparc/mm/init_64.c\nindex 310c6754bcaa..99aea4d15a5f 100644\n--- a/arch/sparc/mm/init_64.c\n+++ b/arch/sparc/mm/init_64.c\n@@ -2651,30 +2651,19 @@ int __meminit vmemmap_populate(unsigned long vstart, unsigned long vend,\n \tvstart = vstart & PMD_MASK;\n \tvend = ALIGN(vend, PMD_SIZE);\n \tfor (; vstart < vend; vstart += PMD_SIZE) {\n-\t\tpgd_t *pgd = pgd_offset_k(vstart);\n+\t\tpgd_t *pgd = vmemmap_pgd_populate(vstart, node);\n \t\tunsigned long pte;\n \t\tpud_t *pud;\n \t\tpmd_t *pmd;\n \n-\t\tif (pgd_none(*pgd)) {\n-\t\t\tpud_t *new = vmemmap_alloc_block(PAGE_SIZE, node);\n+\t\tif (!pgd)\n+\t\t\treturn -ENOMEM;\n \n-\t\t\tif (!new)\n-\t\t\t\treturn -ENOMEM;\n-\t\t\tpgd_populate(&init_mm, pgd, new);\n-\t\t}\n-\n-\t\tpud = pud_offset(pgd, vstart);\n-\t\tif (pud_none(*pud)) {\n-\t\t\tpmd_t *new = vmemmap_alloc_block(PAGE_SIZE, node);\n-\n-\t\t\tif (!new)\n-\t\t\t\treturn -ENOMEM;\n-\t\t\tpud_populate(&init_mm, pud, new);\n-\t\t}\n+\t\tpud = vmemmap_pud_populate(pgd, vstart, node);\n+\t\tif (!pud)\n+\t\t\treturn -ENOMEM;\n \n \t\tpmd = pmd_offset(pud, vstart);\n-\n \t\tpte = pmd_val(*pmd);\n \t\tif (!(pte & _PAGE_VALID)) {\n \t\t\tvoid *block = vmemmap_alloc_block(PMD_SIZE, node);\n","prefixes":["v9","04/12"]}