{"id":816387,"url":"http://patchwork.ozlabs.org/api/patches/816387/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20170920173436.20221-2-phil@nwl.cc/","project":{"id":26,"url":"http://patchwork.ozlabs.org/api/projects/26/?format=json","name":"Netfilter Development","link_name":"netfilter-devel","list_id":"netfilter-devel.vger.kernel.org","list_email":"netfilter-devel@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170920173436.20221-2-phil@nwl.cc>","list_archive_url":null,"date":"2017-09-20T17:34:35","name":"[iptables,1/2] ip{,6}tables-restore: Don't ignore missing wait-interval value","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"1aab7ddb999bd9e6c3cb89425ecb223b63d68a13","submitter":{"id":4285,"url":"http://patchwork.ozlabs.org/api/people/4285/?format=json","name":"Phil Sutter","email":"phil@nwl.cc"},"delegate":{"id":6139,"url":"http://patchwork.ozlabs.org/api/users/6139/?format=json","username":"pablo","first_name":"Pablo","last_name":"Neira","email":"pablo@netfilter.org"},"mbox":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20170920173436.20221-2-phil@nwl.cc/mbox/","series":[{"id":4186,"url":"http://patchwork.ozlabs.org/api/series/4186/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=4186","date":"2017-09-20T17:34:34","name":"ip{,6}tables-restore: Fix wait-interval parsing","version":1,"mbox":"http://patchwork.ozlabs.org/series/4186/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/816387/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/816387/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netfilter-devel-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xy6M66fCyz9s0g\n\tfor ;\n\tThu, 21 Sep 2017 03:34:58 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751740AbdITRe6 (ORCPT );\n\tWed, 20 Sep 2017 13:34:58 -0400","from orbyte.nwl.cc ([151.80.46.58]:41534 \"EHLO orbyte.nwl.cc\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751723AbdITRe6 (ORCPT );\n\tWed, 20 Sep 2017 13:34:58 -0400","from localhost ([::1]:36076 helo=xsao)\n\tby orbyte.nwl.cc with esmtp (Exim 4.89)\n\t(envelope-from )\n\tid 1duitl-00069a-6l; Wed, 20 Sep 2017 19:34:57 +0200"],"From":"Phil Sutter ","To":"Pablo Neira Ayuso ","Cc":"netfilter-devel@vger.kernel.org","Subject":"[iptables PATCH 1/2] ip{,\n\t6}tables-restore: Don't ignore missing wait-interval value","Date":"Wed, 20 Sep 2017 19:34:35 +0200","Message-Id":"<20170920173436.20221-2-phil@nwl.cc>","X-Mailer":"git-send-email 2.13.1","In-Reply-To":"<20170920173436.20221-1-phil@nwl.cc>","References":"<20170920173436.20221-1-phil@nwl.cc>","Sender":"netfilter-devel-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netfilter-devel@vger.kernel.org"},"content":"Passing -W without a value doesn't make sense so bail out if none was\ngiven.\n\nSigned-off-by: Phil Sutter \n---\n iptables/xshared.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/iptables/xshared.c b/iptables/xshared.c\nindex 825479c338214..06db72d427e21 100644\n--- a/iptables/xshared.c\n+++ b/iptables/xshared.c\n@@ -343,7 +343,7 @@ void parse_wait_interval(int argc, char *argv[], struct timeval *wait_interval)\n \telse if (xs_has_arg(argc, argv))\n \t\targ = argv[optind++];\n \telse\n-\t\treturn;\n+\t\txtables_error(PARAMETER_PROBLEM, \"wait interval value required\");\n \n \tret = sscanf(arg, \"%u\", &usec);\n \tif (ret == 1) {\n","prefixes":["iptables","1/2"]}