{"id":816323,"url":"http://patchwork.ozlabs.org/api/patches/816323/?format=json","web_url":"http://patchwork.ozlabs.org/project/ubuntu-kernel/patch/ffa5c4c4d019bd2dbca11b10ff2e4f50bd381721.1505921988.git.joseph.salisbury@canonical.com/","project":{"id":15,"url":"http://patchwork.ozlabs.org/api/projects/15/?format=json","name":"Ubuntu Kernel","link_name":"ubuntu-kernel","list_id":"kernel-team.lists.ubuntu.com","list_email":"kernel-team@lists.ubuntu.com","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"","list_archive_url":null,"date":"2017-09-20T15:47:50","name":"[SRU,Zesty,1/1] scsi: cxlflash: Fix vlun resize failure in the shrink path","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"089d19eaa341726bfac4422c60a14f4d9cf05286","submitter":{"id":7793,"url":"http://patchwork.ozlabs.org/api/people/7793/?format=json","name":"Joseph Salisbury","email":"joseph.salisbury@canonical.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/ubuntu-kernel/patch/ffa5c4c4d019bd2dbca11b10ff2e4f50bd381721.1505921988.git.joseph.salisbury@canonical.com/mbox/","series":[{"id":4155,"url":"http://patchwork.ozlabs.org/api/series/4155/?format=json","web_url":"http://patchwork.ozlabs.org/project/ubuntu-kernel/list/?series=4155","date":"2017-09-20T15:47:50","name":"scsi: cxlflash: Fix vlun resize failure in the shrink path","version":1,"mbox":"http://patchwork.ozlabs.org/series/4155/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/816323/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/816323/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=kernel-team-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xy3zd3LmVz9s7c;\n\tThu, 21 Sep 2017 01:47:57 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1duhE8-0002ov-Ky; Wed, 20 Sep 2017 15:47:52 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1duhE7-0002oa-Hu\n\tfor kernel-team@lists.ubuntu.com; Wed, 20 Sep 2017 15:47:51 +0000","from 1.general.jsalisbury.us.vpn ([10.172.67.212] helo=salisbury)\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.76) (envelope-from )\n\tid 1duhE7-000433-8A\n\tfor kernel-team@lists.ubuntu.com; Wed, 20 Sep 2017 15:47:51 +0000","by salisbury (Postfix, from userid 1000)\n\tid 3FE697E280A; Wed, 20 Sep 2017 11:47:50 -0400 (EDT)"],"From":"Joseph Salisbury ","To":"kernel-team@lists.ubuntu.com","Subject":"[SRU][Zesty][PATCH 1/1] scsi: cxlflash: Fix vlun resize failure in\n\tthe shrink path","Date":"Wed, 20 Sep 2017 11:47:50 -0400","Message-Id":"","X-Mailer":"git-send-email 2.7.4","In-Reply-To":["",""],"References":["",""],"X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" "},"content":"From: Uma Krishnan \n\nBugLink: http://bugs.launchpad.net/bugs/1713575\n\nThe ioctl DK_CAPI_VLUN_RESIZE can fail if the allocated vlun size is\nreduced from almost maximum capacity and then increased again.\n\nThe shrink_lxt() routine is currently using the SISL_ASTATUS_MASK to\nmask the higher 48 bits of the lxt entry. This is unnecessary and\nincorrect as it uses a mask designed for the asynchronous interrupt\nstatus register. When the 4 port support was added to cxlflash, the\nSISL_ASTATUS_MASK was updated to reflect the status bits for all 4\nports. This change indirectly affected the shrink_lxt() code path.\n\nTo extract the base, simply shift the bits without masking.\n\nFixes: 565180723294 (\"scsi: cxlflash: SISlite updates to support 4 ports\")\nSigned-off-by: Uma Krishnan \nSigned-off-by: Martin K. Petersen \n(cherry picked from commit 07a191f762a7b8d0db13c38036380927116e29bb)\nSigned-off-by: Joseph Salisbury \n---\n drivers/scsi/cxlflash/vlun.c | 6 +-----\n 1 file changed, 1 insertion(+), 5 deletions(-)","diff":"diff --git a/drivers/scsi/cxlflash/vlun.c b/drivers/scsi/cxlflash/vlun.c\nindex 6c4cd3f..8de6a80 100644\n--- a/drivers/scsi/cxlflash/vlun.c\n+++ b/drivers/scsi/cxlflash/vlun.c\n@@ -694,11 +694,7 @@ static int shrink_lxt(struct afu *afu,\n \t/* Free LBAs allocated to freed chunks */\n \tmutex_lock(&blka->mutex);\n \tfor (i = delta - 1; i >= 0; i--) {\n-\t\t/* Mask the higher 48 bits before shifting, even though\n-\t\t * it is a noop\n-\t\t */\n-\t\taun = (lxt_old[my_new_size + i].rlba_base & SISL_ASTATUS_MASK);\n-\t\taun = (aun >> MC_CHUNK_SHIFT);\n+\t\taun = lxt_old[my_new_size + i].rlba_base >> MC_CHUNK_SHIFT;\n \t\tif (needs_ws)\n \t\t\twrite_same16(sdev, aun, MC_CHUNK_SIZE);\n \t\tba_free(&blka->ba_lun, aun);\n","prefixes":["SRU","Zesty","1/1"]}