{"id":816313,"url":"http://patchwork.ozlabs.org/api/patches/816313/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170920145025.19403-1-david@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170920145025.19403-1-david@redhat.com>","list_archive_url":null,"date":"2017-09-20T14:50:25","name":"[v1] kvm: drop wrong assertion creating problems with pflash","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"7e8a86e82999972bd12379a714aea5cb5dc85a6b","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/?format=json","name":"David Hildenbrand","email":"david@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170920145025.19403-1-david@redhat.com/mbox/","series":[{"id":4151,"url":"http://patchwork.ozlabs.org/api/series/4151/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=4151","date":"2017-09-20T14:50:25","name":"[v1] kvm: drop wrong assertion creating problems with pflash","version":1,"mbox":"http://patchwork.ozlabs.org/series/4151/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/816313/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/816313/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xy3gp2Dy5z9sPt\n\tfor ;\n\tThu, 21 Sep 2017 01:34:14 +1000 (AEST)","from localhost ([::1]:48918 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duh0u-0002IU-83\n\tfor incoming@patchwork.ozlabs.org; Wed, 20 Sep 2017 11:34:12 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:37034)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dugKo-0003DQ-7x\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 10:50:43 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dugKl-0002Sb-4s\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 10:50:42 -0400","from mx1.redhat.com ([209.132.183.28]:38798)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dugKk-0002RV-QZ\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 10:50:39 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 76BC07E426;\n\tWed, 20 Sep 2017 14:50:35 +0000 (UTC)","from t460s.redhat.com (ovpn-116-82.ams2.redhat.com [10.36.116.82])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 6A9526060A;\n\tWed, 20 Sep 2017 14:50:26 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 76BC07E426","From":"David Hildenbrand ","To":"qemu-devel@nongnu.org","Date":"Wed, 20 Sep 2017 16:50:25 +0200","Message-Id":"<20170920145025.19403-1-david@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tWed, 20 Sep 2017 14:50:35 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v1] kvm: drop wrong assertion creating problems\n\twith pflash","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Paolo Bonzini , david@redhat.com, Gerd Hoffmann\n\t, kvm@vger.kernel.org, =?utf-8?q?Radim_Kr=C4=8Dm?=\n\t=?utf-8?b?w6HFmQ==?= ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"pflash toggles mr->romd_mode. So this assert does not always hold.\n\n1) a device was added with !mr->romd_mode, therefore effectively not\n creating a kvm slot as we want to trap every access (add = false).\n2) mr->romd_mode was toggled on before remove it. There is now\n actually no slot to remove and the asser is wrong.\n\nSo let's just drop the assert.\n\nReported-by: Gerd Hoffmann \nSigned-off-by: David Hildenbrand \n---\n accel/kvm/kvm-all.c | 1 -\n 1 file changed, 1 deletion(-)","diff":"diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c\nindex b0181d7220..4f1997deec 100644\n--- a/accel/kvm/kvm-all.c\n+++ b/accel/kvm/kvm-all.c\n@@ -722,7 +722,6 @@ static void kvm_set_phys_mem(KVMMemoryListener *kml,\n mem = kvm_lookup_matching_slot(kml, start_addr, size);\n if (!add) {\n if (!mem) {\n- g_assert(!memory_region_is_ram(mr) && !writeable && !mr->romd_mode);\n return;\n }\n if (mem->flags & KVM_MEM_LOG_DIRTY_PAGES) {\n","prefixes":["v1"]}