{"id":816287,"url":"http://patchwork.ozlabs.org/api/patches/816287/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170920135833.20472-2-pbutsykin@virtuozzo.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170920135833.20472-2-pbutsykin@virtuozzo.com>","list_archive_url":null,"date":"2017-09-20T13:58:32","name":"[1/2] qcow2: fix return error code in qcow2_truncate()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"b144d356360ef951b30006ed84edbd82e47714f8","submitter":{"id":67271,"url":"http://patchwork.ozlabs.org/api/people/67271/?format=json","name":"Pavel Butsykin","email":"pbutsykin@virtuozzo.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170920135833.20472-2-pbutsykin@virtuozzo.com/mbox/","series":[{"id":4142,"url":"http://patchwork.ozlabs.org/api/series/4142/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=4142","date":"2017-09-20T13:58:33","name":"Truncate the tail of the image file in qcow2 shrinking","version":1,"mbox":"http://patchwork.ozlabs.org/series/4142/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/816287/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/816287/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=virtuozzo.com header.i=@virtuozzo.com\n\theader.b=\"eYM01Lx0\"; dkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=pbutsykin@virtuozzo.com; "],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xy2zg0wqvz9sNr\n\tfor ;\n\tThu, 21 Sep 2017 01:02:54 +1000 (AEST)","from localhost ([::1]:48681 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dugWa-0008A6-Rx\n\tfor incoming@patchwork.ozlabs.org; Wed, 20 Sep 2017 11:02:52 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:51265)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dufWk-0005AH-AG\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 09:59:02 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dufWe-0006wo-Hj\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 09:58:58 -0400","from mail-db5eur01on0090.outbound.protection.outlook.com\n\t([104.47.2.90]:29273\n\thelo=EUR01-DB5-obe.outbound.protection.outlook.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dufWY-0006uU-LN; Wed, 20 Sep 2017 09:58:46 -0400","from pavelb-Z68P-DS3.sw.ru (195.214.232.6) by\n\tHE1PR0802MB2554.eurprd08.prod.outlook.com (2603:10a6:3:e1::19) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.11;\n\tWed, 20 Sep 2017 13:58:43 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com;\n\ts=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=/B2dAAsShdHR31DUSCEiQk1ixgidQ4DkiVHr+R/6N4c=;\n\tb=eYM01Lx0USVRCjmxyZgKA7cxMJlz6IOgr6/Z9VjXwkK8y3eSq53CKa9706HEUuYqTrB8wSA+EaopIuSEaunv2O9ncqgpxsIv8bxeBQkwE6Q4ZsZ9LNR2Anf+TXmgsWLtToLMkdQqSRLnLA0hONJwJV0bdY+52BiQYCXLajWp4Vs=","From":"Pavel Butsykin ","To":"qemu-block@nongnu.org,\n\tqemu-devel@nongnu.org","Date":"Wed, 20 Sep 2017 16:58:32 +0300","Message-Id":"<20170920135833.20472-2-pbutsykin@virtuozzo.com>","X-Mailer":"git-send-email 2.14.1","In-Reply-To":"<20170920135833.20472-1-pbutsykin@virtuozzo.com>","References":"<20170920135833.20472-1-pbutsykin@virtuozzo.com>","MIME-Version":"1.0","Content-Type":"text/plain","X-Originating-IP":"[195.214.232.6]","X-ClientProxiedBy":"AM5PR0602CA0024.eurprd06.prod.outlook.com\n\t(2603:10a6:203:a3::34) To HE1PR0802MB2554.eurprd08.prod.outlook.com\n\t(2603:10a6:3:e1::19)","X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"0e058cb5-bc78-4a44-de93-08d5002fb4c2","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:HE1PR0802MB2554; ","X-Microsoft-Exchange-Diagnostics":["1; HE1PR0802MB2554;\n\t3:iA8Rm6fFk5IjSQ5zSX9+9EOMigNNq8JsQ8R4Bp3uJFmvm9uCdjty6H+srWpuVtEmaJZWsfYZeNclklrlQxyNRvZfCnlsfk9RZCwp10+sSyMEbdCAaIvWn2CsNHv9FZzp12DDI79IpbFvfKMxMM5teZ+u3Gpg5TvRtEn7mtPTlygWJfM17RLs6zZIxwJv6J9XeZOkTLqmkQEMjXjD2prezLIhws6F10QEgfv4AzlyqmDtWPlE6oUljYqMpwcL1WPy;\n\t25:pzzRbd/WEOIH5mfVWZ9Pkkx1rt7HWE3oWaqgAsNIIXhBCjYNeHg/gMRTNfRQxnv09sS5bBBcRrzQ4fJgPz3ItiD6Clc8hYndHvia4pybuhKotbDDJuTb0Uq+i7Q10XdvhtWrF5R+uS6pZJfl36/6+drDZkYG7orZrkUt1cm2h8WnXsMPvzWZbY5NZpRtLjquLf2//NgkFFRadivXbSQ23Zc/vyoOJZ1Ih000V8KjwmnvXdP+47j6IkEBIWD9w6pAaYqhj9Z+ctmmOwy0HpmWWPHuRPC5YvBYiWQKS84ADaxIYFUx8cwTuSdwIw4iQq1E1NwASK9fm4lvAAMF8zu3wA==;\n\t31:Pw73RaebJMvnaxB+yX/9Aj1x7KwwB0ZjjmZHlOUXOXl3ynkq7/JL8Wn0sD4iqxfRskV3Nchr+taHiaf6bNgTqPn9tIfyqwqmzd5JxZlmeVP0Wk2TpYM12jZqCCnc+gut31TvsEaiHX/59iGjfMAuperhxT/c49DefEJUAQs4UmiHWNugW1Aw904CdWtmKMqwBkyTRxOzW2koaZ6YaSzTTWJVd7J6NxqLEpp8qh6nggs=","1; HE1PR0802MB2554;\n\t20:IakgE6va5mEY6sJX9zPWUzLIT0OoOHS7/ANsG7oxywv+OGDY1RzxCr/oLC8L5VMjyRP6EaG9xozNOMj2+ZmO0LAR5bRPBR1vwF0UuwuQvxZ3l9ZvAgUBMNln7NoAr8MJPTI7oQ20OaPZQbjjfm5e+MsaJVkOcqW31wc8QNoHW4SwHwIFRgyiHWjlkvHlrmOAcuxQpPH/cxdSJWzqyt4HV9O6bFSxd1bl3R5uD9I+fn5ZiLfPWEsuGxIIv0+AdsnDkuWJKKRSMbs+PPlCYLpxLolWeW4bo0r8Eo5gw9PtbcJYfxTu3trkb6lpE2405R2dTiKiMJ+/tnYLTmiXtOf5oPeFUanHxLo33QvbCTUeEHS9hrR1QndPWlQ0L7HNn2PZgqeNQwxqKVckf2xAyuHQ9tk3X6Tvb0yWMc8BqntJjfA=;\n\t4:BERp1ou4HvMgTeXEVT2kryUBZ4i+DwTdkOhiOcX1PaGP3WUSEBXoJTDGiRfINPm0zOVYpN7s+vPYX4uThpBK7bCjJBcqVJKRPLL/Ni7hoEzXlWvAy0+rjrHRZiJbWu3sWKbD/FTm4TWMXlmAE6iyIJcwXZR5mIzU6iclTV8xzO4ToIZ+MkFdnh5YNHMwQ4zv+kC/grosD71FQQGo/P8LBUl/Z/lGVJg6FHH/j10x6r5cKsQ647xj3PbXIdZdrxfZ","=?us-ascii?Q?1; HE1PR0802MB2554;\n\t23:9O7+YY6c9vy5eR2Ai0JZOtgT0lChjzHEAeO5Mxv?=\n\trd9tRzPvPHhALmedGPgwEkQRIQaNz+89n1jm/wa7nDX1gHAIojqpGGxotRqJBRPv5Sva8KSpYeWY4CbH4Gt/WHIa0VqPey8xXN1bio9vvKZqyT/53JVF40HmiFq+pWZh5/NwvImHO/UIJaAaA87AB7VZalkvAZ5KrKPByau1pHHZCctmN1FGhNahxruLQ1Jfy5wM6C/2kzuuiziZI4/+yQJODpquIR830wcgI39+zebUv5ZXVAKe9cXUei/MIudMqBDnotmfTnRw6DlSJuNbsNaaVv25OA01CyXc6AcObYkUPOJg+/XAVbVmlj0muBQEZUCOMNp917bw4cm9VWxcDqMXOOD/MymfWSI/LMOVKvKMoHPj+vTF3tyu1+DPwk2Jqrft2X/t57h+ggWR6IMgCzzrHZSZmLvXRPWIhoTpndAHtrcCGmgVxH97f8hNiFfgrLhWMJIxs7Fsl6BgZJh9dArV402a2j9Lw3cEQpvYtmn5FRBmw4C1QJ3ZlcVCpp0yyMUsFFMmBR8vxPoRAcVuxukXNZEBjyp+T6ULYYmJmwVvz3raxmS770BwUJeuQvn3xUx7QrPVzhQhXxAcHbTz/idkU8/DQyWYG+Y/uFy3LmIReaZv2DOoFpMHuJq/SQg3Er4zm5+97EBXGXfwE/ajna1rJlpAZ8LCeR5/mYCHI4rC/TH/H4hniKcOoDRe6DMG8w4JJ9zk26lFOAOn+LrRaH31Y3PMvCzMXycotY44Ag7XS1kDYj1N7zGXGKvi7MyD7QVfM5MqC4R2b17hDlbY7pYV0QVhWQkfqvL2pg/HsOU89xqLhE71vhZhZ4YutvOMCv9H6muYnsQMkN3RJgTHgc/bypE0TAy1EvUvfTDQSCDdkSyORq9axAHdW95uEf4v1uG1y6iQyKyIRw68y1VDO+UehmjMtszE/f37AN6E6tnobMAOF2kEqCVXEnHWBgWM5J+wNU+vHrRs/skIuYYslbz/RbDPcfT4O36xqR1N0rVwNOd5NQsAPjdLnjXyYpmmDtOl6y809bM61ex5J+fTo1MZWFNdFNw3OIGoeEgPPpQyaVovRZgD4E+n1hhXjpOUxKnW2ZZIXYimMXiLXv9LaBJD3M14Jhkltvpa5Jf5Fy6kwfkFhdZaV3B7mC0tmslrmcQc=","1; HE1PR0802MB2554;\n\t6:o6a7xrWONHoD5Hnh196eLLOiI3PQcvZDP/VaDO7AP0/ERs3L54l67bSBQN2/EewlpnRE13jy/xad2CPFvUS9SyY2zAYyq0taahXRkQ/ou14vkKrX009JVU9JFAPuCeUrBC8X5HCEkk95t1A7WVjVPOEy/3WB1rN+1If1jwAl+vP2aPAwpKItvgc0/vc/0E+YaW/ntq7cwXZygLpauRa/IfMa7v4jmubZ3t5A0Y+Fg8u1xEJYN1qVgbc048ySp27WVW/W7Mu3pzm/34aVhCeAVf48scgA/yCxKE6RFQMuTT0wfKMbiEbaiI682HY4c0SfHfbGnMbVte/10rZsdzOnBQ==;\n\t5:4wgxvkhHgcqtgXJalds9D4L9MgE5tBsh6QYtuY/cxjDP50YjHOSi+9Ba8GC1B8PhCUxMKXZ17GuI2hX3UwFOIojnk0/cMRL7oQ8e+7bjleZ1HAj1QJKJJcQIiBnBMU+gpc+jU5VqvRh19oo+ovCO5g==;\n\t24:1okiD/iCnJYVTu35gf9CKotZsLOFkBIflQqw8p35ExhH5sa2UgiHWwgEx6UnkZUyYpVQaATR+jKRw5QLUxb5O5/m2vVCaU5yPhaS8MIH4R8=;\n\t7:hc8gYWmr02ZCrDVNUPqjgqM50HBVON1wSG3UU0BCBt+7BDYgrdovu82Z6bCjrHZ2imoHc9tVBrR8Cd8GjOSmN8v025GN5kCBc961slU9dLz7okUS5tcjJVuHkN3ciJmSKCUytLTdNc4Iy6OL+pDvl0LjQEaOGICuOBU5SS3odyFFATPLoP//kb7bYJZTpLJiSdJbYOY4MavjmEVFwQ6BzQW8kpXLDsX0ua1seCSyKDs=","1; HE1PR0802MB2554;\n\t20:R0MGUAc4lNtlWTNENVj5XTM5bL1SotzgKQ6xqjCzPa5bhRbN2t3ahXRs19Scd0XDTzvRYcL/V5PqKvnay23gD8tOqltvkxAnufLqmHO5SiJ+tBBO2ht4+IVfVYF30OZqpfQintCFZU1vI8dHHBgHM85CYjTxXJ3HY6po6K+nGJQ="],"X-MS-TrafficTypeDiagnostic":"HE1PR0802MB2554:","X-Exchange-Antispam-Report-Test":"UriScan:;","X-Microsoft-Antispam-PRVS":"","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(100000703101)(100105400095)(3002001)(93006095)(93001095)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123555025)(20161123560025)(20161123564025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:HE1PR0802MB2554; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:HE1PR0802MB2554; ","X-Forefront-PRVS":"04362AC73B","X-Forefront-Antispam-Report":"SFV:NSPM;\n\tSFS:(10019020)(7370300001)(4630300001)(6009001)(346002)(376002)(199003)(189002)(4326008)(2906002)(5003940100001)(33646002)(81156014)(16526017)(50986999)(8676002)(86362001)(76176999)(81166006)(101416001)(50226002)(97736004)(53936002)(68736007)(189998001)(16586007)(107886003)(6512007)(305945005)(7736002)(316002)(478600001)(25786009)(36756003)(5660300001)(69596002)(47776003)(50466002)(66066001)(48376002)(7350300001)(6116002)(3846002)(105586002)(1076002)(53416004)(2950100002)(6486002)(6666003)(106356001)(6506006);\n\tDIR:OUT; SFP:1102; SCL:1; SRVR:HE1PR0802MB2554;\n\tH:pavelb-Z68P-DS3.sw.ru; FPR:; SPF:None; PTR:InfoNoRecords; A:1;\n\tMX:1; LANG:en; ","Received-SPF":"None (protection.outlook.com: virtuozzo.com does not designate\n\tpermitted sender hosts)","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-OriginatorOrg":"virtuozzo.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"20 Sep 2017 13:58:43.2051\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"HE1PR0802MB2554","X-detected-operating-system":"by eggs.gnu.org: Windows 7 or 8 [fuzzy]","X-Received-From":"104.47.2.90","Subject":"[Qemu-devel] [PATCH 1/2] qcow2: fix return error code in\n\tqcow2_truncate()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kwolf@redhat.com, den@openvz.org, mreitz@redhat.com,\n\tpbutsykin@virtuozzo.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"Signed-off-by: Pavel Butsykin \n---\n block/qcow2.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/block/qcow2.c b/block/qcow2.c\nindex 2174a84d1f..8a4311d338 100644\n--- a/block/qcow2.c\n+++ b/block/qcow2.c\n@@ -3166,7 +3166,7 @@ static int qcow2_truncate(BlockDriverState *bs, int64_t offset,\n if (old_file_size < 0) {\n error_setg_errno(errp, -old_file_size,\n \"Failed to inquire current file length\");\n- return ret;\n+ return old_file_size;\n }\n \n nb_new_data_clusters = DIV_ROUND_UP(offset - old_length,\n@@ -3195,7 +3195,7 @@ static int qcow2_truncate(BlockDriverState *bs, int64_t offset,\n if (allocation_start < 0) {\n error_setg_errno(errp, -allocation_start,\n \"Failed to resize refcount structures\");\n- return -allocation_start;\n+ return allocation_start;\n }\n \n clusters_allocated = qcow2_alloc_clusters_at(bs, allocation_start,\n","prefixes":["1/2"]}