{"id":816266,"url":"http://patchwork.ozlabs.org/api/patches/816266/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170920114310.13080-3-el13635@mail.ntua.gr/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170920114310.13080-3-el13635@mail.ntua.gr>","list_archive_url":null,"date":"2017-09-20T11:43:10","name":"[2/2] block/block-backend.c: remove blk_pread_unthrottled()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"8bb40d1980b0ffeba565bebca1fd728c8f25aa40","submitter":{"id":71571,"url":"http://patchwork.ozlabs.org/api/people/71571/?format=json","name":"Manos Pitsidianakis","email":"el13635@mail.ntua.gr"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170920114310.13080-3-el13635@mail.ntua.gr/mbox/","series":[{"id":4125,"url":"http://patchwork.ozlabs.org/api/series/4125/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=4125","date":"2017-09-20T11:43:09","name":"remove blk_pread_unthrottled()","version":1,"mbox":"http://patchwork.ozlabs.org/series/4125/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/816266/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/816266/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xy26g5B50z9s82\n\tfor ;\n\tThu, 21 Sep 2017 00:23:55 +1000 (AEST)","from localhost ([::1]:48424 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dufur-0002Td-OB\n\tfor incoming@patchwork.ozlabs.org; Wed, 20 Sep 2017 10:23:53 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:41569)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dufAP-0001xs-1n\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 09:35:54 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dufAO-0000yz-5j\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 09:35:53 -0400","from smtp1.ntua.gr ([2001:648:2000:de::183]:20570)\n\tby eggs.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1dufAK-0000sM-Tp; Wed, 20 Sep 2017 09:35:49 -0400","from mail.ntua.gr (carp0.noc.ntua.gr [147.102.222.60])\n\t(authenticated bits=0)\n\tby smtp1.ntua.gr (8.15.2/8.15.2) with ESMTPSA id v8KBhZ69074337\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=NOT); Wed, 20 Sep 2017 14:43:35 +0300 (EEST)\n\t(envelope-from el13635@mail.ntua.gr)"],"X-Authentication-Warning":"smtp1.ntua.gr: Host carp0.noc.ntua.gr\n\t[147.102.222.60] claimed to be mail.ntua.gr","From":"Manos Pitsidianakis ","To":"qemu-devel ","Date":"Wed, 20 Sep 2017 14:43:10 +0300","Message-Id":"<20170920114310.13080-3-el13635@mail.ntua.gr>","X-Mailer":"git-send-email 2.11.0","In-Reply-To":"<20170920114310.13080-1-el13635@mail.ntua.gr>","References":"<20170920114310.13080-1-el13635@mail.ntua.gr>","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2001:648:2000:de::183","Subject":"[Qemu-devel] [PATCH 2/2] block/block-backend.c: remove\n\tblk_pread_unthrottled()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kevin Wolf , John Snow ,\n\tqemu-block , Max Reitz ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"blk_pread_unthrottled was used to bypass I/O throttling on the BlockBackend in\nthe case of async I/O. This is not needed anymore and we can just call\nblk_pread() directly.\n\nSigned-off-by: Manos Pitsidianakis \n---\n include/sysemu/block-backend.h | 2 --\n block/block-backend.c | 16 ----------------\n hw/block/hd-geometry.c | 7 +------\n 3 files changed, 1 insertion(+), 24 deletions(-)","diff":"diff --git a/include/sysemu/block-backend.h b/include/sysemu/block-backend.h\nindex c4e52a5fa3..c881bfdfe4 100644\n--- a/include/sysemu/block-backend.h\n+++ b/include/sysemu/block-backend.h\n@@ -117,8 +117,6 @@ char *blk_get_attached_dev_id(BlockBackend *blk);\n BlockBackend *blk_by_dev(void *dev);\n BlockBackend *blk_by_qdev_id(const char *id, Error **errp);\n void blk_set_dev_ops(BlockBackend *blk, const BlockDevOps *ops, void *opaque);\n-int blk_pread_unthrottled(BlockBackend *blk, int64_t offset, uint8_t *buf,\n- int bytes);\n int coroutine_fn blk_co_preadv(BlockBackend *blk, int64_t offset,\n unsigned int bytes, QEMUIOVector *qiov,\n BdrvRequestFlags flags);\ndiff --git a/block/block-backend.c b/block/block-backend.c\nindex 110a52d5b1..83329fce15 100644\n--- a/block/block-backend.c\n+++ b/block/block-backend.c\n@@ -1145,22 +1145,6 @@ static int blk_prw(BlockBackend *blk, int64_t offset, uint8_t *buf,\n return rwco.ret;\n }\n \n-int blk_pread_unthrottled(BlockBackend *blk, int64_t offset, uint8_t *buf,\n- int count)\n-{\n- int ret;\n-\n- ret = blk_check_byte_request(blk, offset, count);\n- if (ret < 0) {\n- return ret;\n- }\n-\n- blk_root_drained_begin(blk->root);\n- ret = blk_pread(blk, offset, buf, count);\n- blk_root_drained_end(blk->root);\n- return ret;\n-}\n-\n int blk_pwrite_zeroes(BlockBackend *blk, int64_t offset,\n int bytes, BdrvRequestFlags flags)\n {\ndiff --git a/hw/block/hd-geometry.c b/hw/block/hd-geometry.c\nindex 57ad5012a7..211307f73f 100644\n--- a/hw/block/hd-geometry.c\n+++ b/hw/block/hd-geometry.c\n@@ -62,12 +62,7 @@ static int guess_disk_lchs(BlockBackend *blk,\n \n blk_get_geometry(blk, &nb_sectors);\n \n- /**\n- * The function will be invoked during startup not only in sync I/O mode,\n- * but also in async I/O mode. So the I/O throttling function has to\n- * be disabled temporarily here, not permanently.\n- */\n- if (blk_pread_unthrottled(blk, 0, buf, BDRV_SECTOR_SIZE) < 0) {\n+ if (blk_pread(blk, 0, buf, BDRV_SECTOR_SIZE) < 0) {\n return -1;\n }\n /* test msdos magic */\n","prefixes":["2/2"]}