{"id":816256,"url":"http://patchwork.ozlabs.org/api/patches/816256/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20170920141516.1402-11-jiri@resnulli.us/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170920141516.1402-11-jiri@resnulli.us>","list_archive_url":null,"date":"2017-09-20T14:15:10","name":"[net-next,10/16] mlxsw: spectrum_switchdev: Use generic mc flood function","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"a63348da87087b2b69c74c0ea07ca25e88f60033","submitter":{"id":15321,"url":"http://patchwork.ozlabs.org/api/people/15321/?format=json","name":"Jiri Pirko","email":"jiri@resnulli.us"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170920141516.1402-11-jiri@resnulli.us/mbox/","series":[{"id":4129,"url":"http://patchwork.ozlabs.org/api/series/4129/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=4129","date":"2017-09-20T14:15:00","name":"mlxsw: Multicast flood update","version":1,"mbox":"http://patchwork.ozlabs.org/series/4129/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/816256/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/816256/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=resnulli-us.20150623.gappssmtp.com\n\theader.i=@resnulli-us.20150623.gappssmtp.com\n\theader.b=\"YZGrFFNd\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xy1xd25wtz9sNr\n\tfor ;\n\tThu, 21 Sep 2017 00:16:05 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751815AbdITOQD (ORCPT );\n\tWed, 20 Sep 2017 10:16:03 -0400","from mail-wm0-f66.google.com ([74.125.82.66]:38369 \"EHLO\n\tmail-wm0-f66.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751463AbdITOP1 (ORCPT\n\t); Wed, 20 Sep 2017 10:15:27 -0400","by mail-wm0-f66.google.com with SMTP id x17so2560679wmd.5\n\tfor ; Wed, 20 Sep 2017 07:15:27 -0700 (PDT)","from localhost (ip-89-177-125-82.net.upcbroadband.cz.\n\t[89.177.125.82]) by smtp.gmail.com with ESMTPSA id\n\tv2sm1719518wmf.8.2017.09.20.07.15.25\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 20 Sep 2017 07:15:26 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=resnulli-us.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=VLpN2wRLzbOjOxpc78i21RCc71TA3XW2J4im/ukuIec=;\n\tb=YZGrFFNdtsYHedJ5GCviY8p6sRmlyWliq7LWhJzaPRMi52oeT2vID2FLLPpDCOsWGg\n\tR+aEoyuFceHF10DtoNtuympuQakIBW6wpMPt6oAmBrGx9paCdwS1dRfEs8GE2MaytXYg\n\tfjOPj+h7imSbUA/QvlWnbgH9dvSmtOi6dUzMZpJ8u8odKO5jd7IxVKclWItyJ5C38Qqt\n\t8uno4OYBtTlVTpJZLuL+ky1kv8G1Br1pX2K0Sh8vzdCWn//pNX6pDqY0BoSwDA0OCm67\n\tPbUypGR3UzPPziwUj8mZhfKV0REGPcw7ePA0U1GBEBhrm6oKNpui+YXzOhUVmdymgnWd\n\tnKbQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=VLpN2wRLzbOjOxpc78i21RCc71TA3XW2J4im/ukuIec=;\n\tb=cuVM+h4wiJ1HnyNQPoqrPT+GUvGLWC/MXBptn9u9gTYQ+rbaaV0DcBI86+EaEd0HpC\n\twYlvXuSzLfRyE/fDhLl+ryccybQ9l3FRx56/pPu+uDU6zjRaz67NSS9T1Rpu96jHnsqh\n\t49kiHZz9kHnsoJ48rDzoI9kbht0h7gJhsvVaDPzi+Kd7Y5VDmTtNMalJ7M9G6fr8uliL\n\t8GABC8PBhl6ktufdbAle4tzGKPMCMcmR8drpjkeVOb19mi8zAvZbTsv4WfCMc3SsPjbc\n\tACxU53K2FmWQGBWLN3LVjRihtnlR8WZqkaUQ5ihHVEYhcmVzuermww5kcFwtKPjhmQQG\n\tEcmw==","X-Gm-Message-State":"AHPjjUhq6f5F9ryWmObytFvg86sRhExpV4j817ZYioCMwSGD9x1ry9u3\n\tgYPVm/BoPyaYtgICWzGseeuL/7wf","X-Google-Smtp-Source":"AOwi7QBFR1pSWr6hY7NlywyLvHfPyrRUHrd6mI8fqEAD5D0/kKSuGktpqVWcD8XhSwUTb00m8E4fnA==","X-Received":"by 10.28.60.8 with SMTP id j8mr3897196wma.16.1505916926442;\n\tWed, 20 Sep 2017 07:15:26 -0700 (PDT)","From":"Jiri Pirko ","To":"netdev@vger.kernel.org","Cc":"davem@davemloft.net, nogahf@mellanox.com, idosch@mellanox.com,\n\tmlxsw@mellanox.com","Subject":"[patch net-next 10/16] mlxsw: spectrum_switchdev: Use generic mc\n\tflood function","Date":"Wed, 20 Sep 2017 16:15:10 +0200","Message-Id":"<20170920141516.1402-11-jiri@resnulli.us>","X-Mailer":"git-send-email 2.9.5","In-Reply-To":"<20170920141516.1402-1-jiri@resnulli.us>","References":"<20170920141516.1402-1-jiri@resnulli.us>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"From: Nogah Frankel \n\nUse the generic mc flood function to decide whether to flood mc to a port\nwhen mc is being enabled / disabled.\nMove this function in the file to avoid forward declaration.\n\nSigned-off-by: Nogah Frankel \nSigned-off-by: Jiri Pirko \n---\n .../net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 18 +++++++++---------\n 1 file changed, 9 insertions(+), 9 deletions(-)","diff":"diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c\nindex 79806af..19ac206 100644\n--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c\n+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c\n@@ -742,6 +742,14 @@ static int mlxsw_sp_port_attr_mrouter_set(struct mlxsw_sp_port *mlxsw_sp_port,\n \treturn 0;\n }\n \n+static bool mlxsw_sp_mc_flood(const struct mlxsw_sp_bridge_port *bridge_port)\n+{\n+\tconst struct mlxsw_sp_bridge_device *bridge_device;\n+\n+\tbridge_device = bridge_port->bridge_device;\n+\treturn !bridge_device->multicast_enabled ? true : bridge_port->mrouter;\n+}\n+\n static int mlxsw_sp_port_mc_disabled_set(struct mlxsw_sp_port *mlxsw_sp_port,\n \t\t\t\t\t struct switchdev_trans *trans,\n \t\t\t\t\t struct net_device *orig_dev,\n@@ -770,7 +778,7 @@ static int mlxsw_sp_port_mc_disabled_set(struct mlxsw_sp_port *mlxsw_sp_port,\n \n \tlist_for_each_entry(bridge_port, &bridge_device->ports_list, list) {\n \t\tenum mlxsw_sp_flood_type packet_type = MLXSW_SP_FLOOD_TYPE_MC;\n-\t\tbool member = mc_disabled ? true : bridge_port->mrouter;\n+\t\tbool member = mlxsw_sp_mc_flood(bridge_port);\n \n \t\terr = mlxsw_sp_bridge_port_flood_table_set(mlxsw_sp_port,\n \t\t\t\t\t\t\t bridge_port,\n@@ -829,14 +837,6 @@ static int mlxsw_sp_port_attr_set(struct net_device *dev,\n \treturn err;\n }\n \n-static bool mlxsw_sp_mc_flood(const struct mlxsw_sp_bridge_port *bridge_port)\n-{\n-\tconst struct mlxsw_sp_bridge_device *bridge_device;\n-\n-\tbridge_device = bridge_port->bridge_device;\n-\treturn !bridge_device->multicast_enabled ? true : bridge_port->mrouter;\n-}\n-\n static int\n mlxsw_sp_port_vlan_fid_join(struct mlxsw_sp_port_vlan *mlxsw_sp_port_vlan,\n \t\t\t struct mlxsw_sp_bridge_port *bridge_port)\n","prefixes":["net-next","10/16"]}