{"id":816255,"url":"http://patchwork.ozlabs.org/api/patches/816255/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20170920141516.1402-13-jiri@resnulli.us/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170920141516.1402-13-jiri@resnulli.us>","list_archive_url":null,"date":"2017-09-20T14:15:12","name":"[net-next,12/16] mlxsw: spectrum_switchdev: Flush the mdb when a port is being removed","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"cb60ce32565e30529d469b9cee2837af7c63b0d5","submitter":{"id":15321,"url":"http://patchwork.ozlabs.org/api/people/15321/?format=json","name":"Jiri Pirko","email":"jiri@resnulli.us"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170920141516.1402-13-jiri@resnulli.us/mbox/","series":[{"id":4129,"url":"http://patchwork.ozlabs.org/api/series/4129/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=4129","date":"2017-09-20T14:15:00","name":"mlxsw: Multicast flood update","version":1,"mbox":"http://patchwork.ozlabs.org/series/4129/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/816255/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/816255/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=resnulli-us.20150623.gappssmtp.com\n\theader.i=@resnulli-us.20150623.gappssmtp.com\n\theader.b=\"iQRNnRVL\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xy1xV0rJyz9s82\n\tfor ;\n\tThu, 21 Sep 2017 00:15:58 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751806AbdITOP4 (ORCPT );\n\tWed, 20 Sep 2017 10:15:56 -0400","from mail-wr0-f193.google.com ([209.85.128.193]:34415 \"EHLO\n\tmail-wr0-f193.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751750AbdITOP3 (ORCPT\n\t); Wed, 20 Sep 2017 10:15:29 -0400","by mail-wr0-f193.google.com with SMTP id k20so1585432wre.1\n\tfor ; Wed, 20 Sep 2017 07:15:29 -0700 (PDT)","from localhost (ip-89-177-125-82.net.upcbroadband.cz.\n\t[89.177.125.82]) by smtp.gmail.com with ESMTPSA id\n\to138sm1757651wmg.36.2017.09.20.07.15.27\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 20 Sep 2017 07:15:28 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=resnulli-us.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=UsBn2TBX+aOHamxTahBSEe1e3verYYMiGLJgOdmhXiw=;\n\tb=iQRNnRVLY6myp/4STEbmcEca2TTVGQ6tmv7YlQOslHDMUJEPRdzTSDmAhJGywwaKUn\n\tZGK8TZpGoB+XgkK/eRxUrkhXob9bE1f6w4REYJ1g96bkZzwh4qyifbijFPl/YRDuOBBW\n\tlxCmbnVHZgEK+BeWn+DU/XSqKegJqVAwmwqE+AhmuENPhejwj+Siw8b7HV+YTnFIq+VZ\n\tw3BJrI4oUWUQtM9cBB5WlJr/NLbMzKsCebOCAlS7Geut3pXeFe8c9wKdwWdRlVLEAH3d\n\tYUln2SBtjDpVsZjoPV1yDytg//T8J7OUPVNa1RPyjB4uAwds9DEk+0nIxPidRLB76JT3\n\tSgdw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=UsBn2TBX+aOHamxTahBSEe1e3verYYMiGLJgOdmhXiw=;\n\tb=L38jpD3WK7ASTQlslcNemDCTDyHPkFrDNM2zy7SKQ33RF+1lVJkjPIm0TxZyt1pz4E\n\tOue9UuZjHIFTQH5Ogy/LFbIEQ8RQX9YlHpV1mQn45IN42X8uEVEIqwK2VOMhBrxVLPQY\n\twCfQax0Ltx5lP4DrqXJYN86KFtVQjfk9aR2V2hj1uIfemAxzLfLjHfD8LXwU7dEAL/If\n\tsIsXhurp21Cv1Jx2UOIo9idxyRijm6xYrEkmuNQ8ndbz/zLm4DMSoDvcn5XaZq0JvzeV\n\t89OD8MpoGO4kIFlW3rm1LuemeD2CNqaufwD0xLnP0P8SfQJY1+s1KVmO/0Oie29XJPIf\n\t76cQ==","X-Gm-Message-State":"AHPjjUi9sip64TjSE6Qge4L2IqencuqH6FiK7cZVbLDJkDuEbmm8W9Qa\n\tSZAPU8BQ0LnIOMepUrRPCWotg1zk","X-Google-Smtp-Source":"AOwi7QA34GVxgwpI6hh/IYdiQATsGaCIPKkjvuQ8fiKWuT5Rv9n+jKLjYNuIdftswACp3SXtJ13WaQ==","X-Received":"by 10.223.166.21 with SMTP id k21mr4437941wrc.261.1505916928327; \n\tWed, 20 Sep 2017 07:15:28 -0700 (PDT)","From":"Jiri Pirko ","To":"netdev@vger.kernel.org","Cc":"davem@davemloft.net, nogahf@mellanox.com, idosch@mellanox.com,\n\tmlxsw@mellanox.com","Subject":"[patch net-next 12/16] mlxsw: spectrum_switchdev: Flush the mdb\n\twhen a port is being removed","Date":"Wed, 20 Sep 2017 16:15:12 +0200","Message-Id":"<20170920141516.1402-13-jiri@resnulli.us>","X-Mailer":"git-send-email 2.9.5","In-Reply-To":"<20170920141516.1402-1-jiri@resnulli.us>","References":"<20170920141516.1402-1-jiri@resnulli.us>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"From: Nogah Frankel \n\nWhen a port is being removed from a bridge, flush the bridge mdb to remove\nthe mids of that port.\n\nSigned-off-by: Nogah Frankel \nSigned-off-by: Jiri Pirko \n---\n .../ethernet/mellanox/mlxsw/spectrum_switchdev.c | 39 ++++++++++++++++------\n 1 file changed, 29 insertions(+), 10 deletions(-)","diff":"diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c\nindex 50c4d7c..bc07873 100644\n--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c\n+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c\n@@ -122,6 +122,10 @@ mlxsw_sp_bridge_port_fdb_flush(struct mlxsw_sp *mlxsw_sp,\n \t\t\t u16 fid_index);\n \n static void\n+mlxsw_sp_bridge_port_mdb_flush(struct mlxsw_sp_port *mlxsw_sp_port,\n+\t\t\t struct mlxsw_sp_bridge_port *bridge_port);\n+\n+static void\n mlxsw_sp_bridge_mdb_mc_enable_sync(struct mlxsw_sp_port *mlxsw_sp_port,\n \t\t\t\t struct mlxsw_sp_bridge_device\n \t\t\t\t *bridge_device);\n@@ -176,17 +180,11 @@ static void\n mlxsw_sp_bridge_device_destroy(struct mlxsw_sp_bridge *bridge,\n \t\t\t struct mlxsw_sp_bridge_device *bridge_device)\n {\n-\tstruct mlxsw_sp_mid *mid, *tmp;\n-\n \tlist_del(&bridge_device->list);\n \tif (bridge_device->vlan_enabled)\n \t\tbridge->vlan_enabled_exists = false;\n \tWARN_ON(!list_empty(&bridge_device->ports_list));\n-\tlist_for_each_entry_safe(mid, tmp, &bridge_device->mids_list, list) {\n-\t\tlist_del(&mid->list);\n-\t\tclear_bit(mid->mid, bridge->mids_bitmap);\n-\t\tkfree(mid);\n-\t}\n+\tWARN_ON(!list_empty(&bridge_device->mids_list));\n \tkfree(bridge_device);\n }\n \n@@ -987,24 +985,28 @@ mlxsw_sp_port_vlan_bridge_leave(struct mlxsw_sp_port_vlan *mlxsw_sp_port_vlan)\n \tstruct mlxsw_sp_bridge_vlan *bridge_vlan;\n \tstruct mlxsw_sp_bridge_port *bridge_port;\n \tu16 vid = mlxsw_sp_port_vlan->vid;\n-\tbool last;\n+\tbool last_port, last_vlan;\n \n \tif (WARN_ON(mlxsw_sp_fid_type(fid) != MLXSW_SP_FID_TYPE_8021Q &&\n \t\t mlxsw_sp_fid_type(fid) != MLXSW_SP_FID_TYPE_8021D))\n \t\treturn;\n \n \tbridge_port = mlxsw_sp_port_vlan->bridge_port;\n+\tlast_vlan = list_is_singular(&bridge_port->vlans_list);\n \tbridge_vlan = mlxsw_sp_bridge_vlan_find(bridge_port, vid);\n-\tlast = list_is_singular(&bridge_vlan->port_vlan_list);\n+\tlast_port = list_is_singular(&bridge_vlan->port_vlan_list);\n \n \tlist_del(&mlxsw_sp_port_vlan->bridge_vlan_node);\n \tmlxsw_sp_bridge_vlan_put(bridge_vlan);\n \tmlxsw_sp_port_vid_stp_set(mlxsw_sp_port, vid, BR_STATE_DISABLED);\n \tmlxsw_sp_port_vid_learning_set(mlxsw_sp_port, vid, false);\n-\tif (last)\n+\tif (last_port)\n \t\tmlxsw_sp_bridge_port_fdb_flush(mlxsw_sp_port->mlxsw_sp,\n \t\t\t\t\t bridge_port,\n \t\t\t\t\t mlxsw_sp_fid_index(fid));\n+\tif (last_vlan)\n+\t\tmlxsw_sp_bridge_port_mdb_flush(mlxsw_sp_port, bridge_port);\n+\n \tmlxsw_sp_port_vlan_fid_leave(mlxsw_sp_port_vlan);\n \n \tmlxsw_sp_bridge_port_put(mlxsw_sp_port->mlxsw_sp->bridge, bridge_port);\n@@ -1580,6 +1582,23 @@ static int mlxsw_sp_port_mdb_del(struct mlxsw_sp_port *mlxsw_sp_port,\n \treturn __mlxsw_sp_port_mdb_del(mlxsw_sp_port, bridge_port, mid);\n }\n \n+static void\n+mlxsw_sp_bridge_port_mdb_flush(struct mlxsw_sp_port *mlxsw_sp_port,\n+\t\t\t struct mlxsw_sp_bridge_port *bridge_port)\n+{\n+\tstruct mlxsw_sp_bridge_device *bridge_device;\n+\tstruct mlxsw_sp_mid *mid, *tmp;\n+\n+\tbridge_device = bridge_port->bridge_device;\n+\n+\tlist_for_each_entry_safe(mid, tmp, &bridge_device->mids_list, list) {\n+\t\tif (test_bit(mlxsw_sp_port->local_port, mid->ports_in_mid)) {\n+\t\t\t__mlxsw_sp_port_mdb_del(mlxsw_sp_port, bridge_port,\n+\t\t\t\t\t\tmid);\n+\t\t}\n+\t}\n+}\n+\n static int mlxsw_sp_port_obj_del(struct net_device *dev,\n \t\t\t\t const struct switchdev_obj *obj)\n {\n","prefixes":["net-next","12/16"]}