{"id":816250,"url":"http://patchwork.ozlabs.org/api/patches/816250/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20170920141516.1402-12-jiri@resnulli.us/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170920141516.1402-12-jiri@resnulli.us>","list_archive_url":null,"date":"2017-09-20T14:15:11","name":"[net-next,11/16] mlxsw: spectrum_switchdev: Flood mc when mc is disabled by user flag","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"4225739a556e593facdd3f82d0e93972a55f7940","submitter":{"id":15321,"url":"http://patchwork.ozlabs.org/api/people/15321/?format=json","name":"Jiri Pirko","email":"jiri@resnulli.us"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170920141516.1402-12-jiri@resnulli.us/mbox/","series":[{"id":4129,"url":"http://patchwork.ozlabs.org/api/series/4129/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=4129","date":"2017-09-20T14:15:00","name":"mlxsw: Multicast flood update","version":1,"mbox":"http://patchwork.ozlabs.org/series/4129/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/816250/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/816250/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=resnulli-us.20150623.gappssmtp.com\n\theader.i=@resnulli-us.20150623.gappssmtp.com\n\theader.b=\"pAMVTd7O\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xy1x14r4jz9s82\n\tfor ;\n\tThu, 21 Sep 2017 00:15:33 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751781AbdITOPb (ORCPT );\n\tWed, 20 Sep 2017 10:15:31 -0400","from mail-wm0-f68.google.com ([74.125.82.68]:36114 \"EHLO\n\tmail-wm0-f68.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751752AbdITOP2 (ORCPT\n\t); Wed, 20 Sep 2017 10:15:28 -0400","by mail-wm0-f68.google.com with SMTP id r136so2577740wmf.3\n\tfor ; Wed, 20 Sep 2017 07:15:28 -0700 (PDT)","from localhost (ip-89-177-125-82.net.upcbroadband.cz.\n\t[89.177.125.82]) by smtp.gmail.com with ESMTPSA id\n\tl15sm1753494wmd.23.2017.09.20.07.15.26\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 20 Sep 2017 07:15:27 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=resnulli-us.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=oYt6/+DiNs8LoY4yyEX4rnwLNlWCgx5Ac/YSV+5JTOo=;\n\tb=pAMVTd7OHpvoXx5xdZMWc3S9Bc8To7rT+24WnRFWMJP5YHyN1bzZQq+GT+eTcDZnBm\n\tJmU+VNZQqOTDifqZwRcUs7aXbs4klwZM+oaSeymrf8mK9sIKJPWuDk5DW7t/OLjfVZl1\n\tNLS3k+fug4RCjrrjpIR0TGYEApbk1YiQD1wJndfX5HnasDhNF4eF4U8KvbhES7twdlht\n\tuVtfJ/lJhzjRz3oXqA0b+uIx+Bk3iBr+HDOThb0euE5jmxPrNMbGA7XMDb3HPVrS9gFz\n\tBY71V+A+JrGJBNo0IStIN1nXEXQTqzi1ZvUB7xsbW9Wc7a3r13rEbhoxywNG+hH86d4s\n\t1XRQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=oYt6/+DiNs8LoY4yyEX4rnwLNlWCgx5Ac/YSV+5JTOo=;\n\tb=TJR6Q3QGKiT2b8S2nq3csSnDGEhia3raQJtE4i/XrtnxVpv0GivzlS2nZNKC7amw7i\n\tKLISmxasKkdNghiZ9Jwyb77wG7HeHBR9mWa+Rx4FVUKm9FRjdy9rXazkf5k0XGM9Wm7M\n\t2wTn8U05aakim3YcU9cbZbLeFy+eNUeDKADPsrBwAnfTEuJgEWFV2O+6oo1gvjjAvQ91\n\tUowJoolBu+OGvOtSrndWXJHTvvaxtaK289sTNhfXaJStGypoeBMFqhFmc5X6RwLVFHkK\n\tOPMrV2EOnlOZdhmT9NB9MZPYNeUZa2DGRvDguO8XdILNHuDmbaHNOWkv1PE1cftwFAEi\n\tFbnw==","X-Gm-Message-State":"AHPjjUgp4ftsb5av6LewJ4ZW/PNFcSUtfKtLh18vBGAQT+iTUOWZziUI\n\tdSl54Hnzh/ysNsJcsKhMMPzsvc10","X-Google-Smtp-Source":"AOwi7QD2vy0Wn/6raSL9dwDdpZqehdz9Ba+fZAXol1PGX4Y43yMxUclp0OUd8MmTLUxZuScsjWRMTw==","X-Received":"by 10.28.94.138 with SMTP id s132mr3908265wmb.0.1505916927403;\n\tWed, 20 Sep 2017 07:15:27 -0700 (PDT)","From":"Jiri Pirko ","To":"netdev@vger.kernel.org","Cc":"davem@davemloft.net, nogahf@mellanox.com, idosch@mellanox.com,\n\tmlxsw@mellanox.com","Subject":"[patch net-next 11/16] mlxsw: spectrum_switchdev: Flood mc when mc\n\tis disabled by user flag","Date":"Wed, 20 Sep 2017 16:15:11 +0200","Message-Id":"<20170920141516.1402-12-jiri@resnulli.us>","X-Mailer":"git-send-email 2.9.5","In-Reply-To":"<20170920141516.1402-1-jiri@resnulli.us>","References":"<20170920141516.1402-1-jiri@resnulli.us>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"From: Nogah Frankel \n\nWhen multicast is disabled, flood mc packets only to port that are marked\nBR_MCAST_FLOOD (instead to all).\n\nSigned-off-by: Nogah Frankel \nSigned-off-by: Jiri Pirko \n---\n .../ethernet/mellanox/mlxsw/spectrum_switchdev.c | 21 +++++++++++++++++----\n 1 file changed, 17 insertions(+), 4 deletions(-)","diff":"diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c\nindex 19ac206..50c4d7c 100644\n--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c\n+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c\n@@ -262,7 +262,8 @@ mlxsw_sp_bridge_port_create(struct mlxsw_sp_bridge_device *bridge_device,\n \tbridge_port->dev = brport_dev;\n \tbridge_port->bridge_device = bridge_device;\n \tbridge_port->stp_state = BR_STATE_DISABLED;\n-\tbridge_port->flags = BR_LEARNING | BR_FLOOD | BR_LEARNING_SYNC;\n+\tbridge_port->flags = BR_LEARNING | BR_FLOOD | BR_LEARNING_SYNC |\n+\t\t\t BR_MCAST_FLOOD;\n \tINIT_LIST_HEAD(&bridge_port->vlans_list);\n \tlist_add(&bridge_port->list, &bridge_device->ports_list);\n \tbridge_port->ref_count = 1;\n@@ -468,7 +469,8 @@ static int mlxsw_sp_port_attr_get(struct net_device *dev,\n \t\t\t\t\t &attr->u.brport_flags);\n \t\tbreak;\n \tcase SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS_SUPPORT:\n-\t\tattr->u.brport_flags_support = BR_LEARNING | BR_FLOOD;\n+\t\tattr->u.brport_flags_support = BR_LEARNING | BR_FLOOD |\n+\t\t\t\t\t BR_MCAST_FLOOD;\n \t\tbreak;\n \tdefault:\n \t\treturn -EOPNOTSUPP;\n@@ -653,8 +655,18 @@ static int mlxsw_sp_port_attr_br_flags_set(struct mlxsw_sp_port *mlxsw_sp_port,\n \tif (err)\n \t\treturn err;\n \n-\tmemcpy(&bridge_port->flags, &brport_flags, sizeof(brport_flags));\n+\tif (bridge_port->bridge_device->multicast_enabled)\n+\t\tgoto out;\n \n+\terr = mlxsw_sp_bridge_port_flood_table_set(mlxsw_sp_port, bridge_port,\n+\t\t\t\t\t\t MLXSW_SP_FLOOD_TYPE_MC,\n+\t\t\t\t\t\t brport_flags &\n+\t\t\t\t\t\t BR_MCAST_FLOOD);\n+\tif (err)\n+\t\treturn err;\n+\n+out:\n+\tmemcpy(&bridge_port->flags, &brport_flags, sizeof(brport_flags));\n \treturn 0;\n }\n \n@@ -747,7 +759,8 @@ static bool mlxsw_sp_mc_flood(const struct mlxsw_sp_bridge_port *bridge_port)\n \tconst struct mlxsw_sp_bridge_device *bridge_device;\n \n \tbridge_device = bridge_port->bridge_device;\n-\treturn !bridge_device->multicast_enabled ? true : bridge_port->mrouter;\n+\treturn bridge_device->multicast_enabled ? bridge_port->mrouter :\n+\t\t\t\t\tbridge_port->flags & BR_MCAST_FLOOD;\n }\n \n static int mlxsw_sp_port_mc_disabled_set(struct mlxsw_sp_port *mlxsw_sp_port,\n","prefixes":["net-next","11/16"]}