{"id":816249,"url":"http://patchwork.ozlabs.org/api/patches/816249/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20170920141516.1402-10-jiri@resnulli.us/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170920141516.1402-10-jiri@resnulli.us>","list_archive_url":null,"date":"2017-09-20T14:15:09","name":"[net-next,09/16] mlxsw: spectrum_switchdev: Disable mdb when mc is disabled","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"c1a734e5a771fa0748329eb18b7f25ed92d0ae14","submitter":{"id":15321,"url":"http://patchwork.ozlabs.org/api/people/15321/?format=json","name":"Jiri Pirko","email":"jiri@resnulli.us"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170920141516.1402-10-jiri@resnulli.us/mbox/","series":[{"id":4129,"url":"http://patchwork.ozlabs.org/api/series/4129/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=4129","date":"2017-09-20T14:15:00","name":"mlxsw: Multicast flood update","version":1,"mbox":"http://patchwork.ozlabs.org/series/4129/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/816249/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/816249/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=resnulli-us.20150623.gappssmtp.com\n\theader.i=@resnulli-us.20150623.gappssmtp.com\n\theader.b=\"tCAedZ4Q\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xy1wz2pkWz9s82\n\tfor ;\n\tThu, 21 Sep 2017 00:15:31 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751763AbdITOP2 (ORCPT );\n\tWed, 20 Sep 2017 10:15:28 -0400","from mail-wm0-f66.google.com ([74.125.82.66]:36103 \"EHLO\n\tmail-wm0-f66.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751735AbdITOP1 (ORCPT\n\t); Wed, 20 Sep 2017 10:15:27 -0400","by mail-wm0-f66.google.com with SMTP id r136so2577690wmf.3\n\tfor ; Wed, 20 Sep 2017 07:15:26 -0700 (PDT)","from localhost (ip-89-177-125-82.net.upcbroadband.cz.\n\t[89.177.125.82]) by smtp.gmail.com with ESMTPSA id\n\tz51sm2011770wrz.80.2017.09.20.07.15.24\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 20 Sep 2017 07:15:25 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=resnulli-us.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=dYGXLCZnQsFf83Q97B9v6lnGKg1dG98Hz07boOzpDtQ=;\n\tb=tCAedZ4QkhzL4s+PipTf4QOOGkNNxQ+GKqF07fSAESq7vOQaFaPDgN4DqgIikWuS6X\n\tGEjxLcENIA0k/M6c4G9NS0UfHyW6tV/qyXkENz30pk1NcH1uRLlTieAhgO34Q4XJHcM+\n\tEunOITTlCggkWOnuZ6qw+C0E/+rwcR69l6Red6we1jJHG1LdSgq/BYBTKssQGrQv0uNC\n\tvAFxXGSAB0dPoaJe/ECvbQZwKNOz/z0M2PRNeowQgVvAx1AOfS/ecRaMhdDBYYaWYy4x\n\t6BCr+CzMh2bjR+xmsnymQQX2vVUvq66GrOUPDaHR5jwxhICzD1ZYTYf5Sw0KTxBiJ9z/\n\tB2XA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=dYGXLCZnQsFf83Q97B9v6lnGKg1dG98Hz07boOzpDtQ=;\n\tb=OAFaSdJ9C/6+46cjrbbvwdfSEc35OO54K0cTnV1nNJ9iSW3rv/D1jDv9sCTDGPV9GL\n\tLKGE4GPF3jPzaFSw+cP47is/+PuQo7iEhL+x4aYJgwGxai4dLrBk2ZGbdUXDGmde5Cxs\n\tOzDMolHiWv1eOdBEGc6HARrmkmdhyNqHlXGUt4Qk7EFbX1znQ7jHGOvqB3XnA2vT3srr\n\tRAovoWPo7joyJU/vQLleyyQqXiQOF7Gx/9gU1wZdt+U01XRzkVU0Hjn5P3rmKebmg2KN\n\tmC8wWJ90I8gd+pShH+UqTfPW5PB/61YgzIbPZoR9bfic4ltWPVHc/jXbz6u7nrr6phi9\n\te1YQ==","X-Gm-Message-State":"AHPjjUgRR9sis6gwclC2Z+Eux1j4QVXcE7jNAq31/dWqPOlPsIzKlysQ\n\tpSUZEbHFG/IU1xA4PSMlrxdp5oob","X-Google-Smtp-Source":"AOwi7QDFaQPxClGoslVNnVx+3UGTab8QnDzw+xkGIiadgm7/QUJO6+7H7GlVfcfYCer6rVQ6oGuBDw==","X-Received":"by 10.28.69.11 with SMTP id s11mr3779291wma.81.1505916925520;\n\tWed, 20 Sep 2017 07:15:25 -0700 (PDT)","From":"Jiri Pirko ","To":"netdev@vger.kernel.org","Cc":"davem@davemloft.net, nogahf@mellanox.com, idosch@mellanox.com,\n\tmlxsw@mellanox.com","Subject":"[patch net-next 09/16] mlxsw: spectrum_switchdev: Disable mdb when\n\tmc is disabled","Date":"Wed, 20 Sep 2017 16:15:09 +0200","Message-Id":"<20170920141516.1402-10-jiri@resnulli.us>","X-Mailer":"git-send-email 2.9.5","In-Reply-To":"<20170920141516.1402-1-jiri@resnulli.us>","References":"<20170920141516.1402-1-jiri@resnulli.us>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"From: Nogah Frankel \n\nRemove all the mdb entries from the HW when mc is being disabled and\nre-write them when it is being enabled.\n\nSigned-off-by: Nogah Frankel \nSigned-off-by: Jiri Pirko \n---\n .../ethernet/mellanox/mlxsw/spectrum_switchdev.c | 41 +++++++++++++++++++---\n 1 file changed, 37 insertions(+), 4 deletions(-)","diff":"diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c\nindex cea257a..79806af 100644\n--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c\n+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c\n@@ -121,6 +121,11 @@ mlxsw_sp_bridge_port_fdb_flush(struct mlxsw_sp *mlxsw_sp,\n \t\t\t struct mlxsw_sp_bridge_port *bridge_port,\n \t\t\t u16 fid_index);\n \n+static void\n+mlxsw_sp_bridge_mdb_mc_enable_sync(struct mlxsw_sp_port *mlxsw_sp_port,\n+\t\t\t\t struct mlxsw_sp_bridge_device\n+\t\t\t\t *bridge_device);\n+\n static struct mlxsw_sp_bridge_device *\n mlxsw_sp_bridge_device_find(const struct mlxsw_sp_bridge *bridge,\n \t\t\t const struct net_device *br_dev)\n@@ -757,6 +762,12 @@ static int mlxsw_sp_port_mc_disabled_set(struct mlxsw_sp_port *mlxsw_sp_port,\n \tif (!bridge_device)\n \t\treturn 0;\n \n+\tif (bridge_device->multicast_enabled != !mc_disabled) {\n+\t\tbridge_device->multicast_enabled = !mc_disabled;\n+\t\tmlxsw_sp_bridge_mdb_mc_enable_sync(mlxsw_sp_port,\n+\t\t\t\t\t\t bridge_device);\n+\t}\n+\n \tlist_for_each_entry(bridge_port, &bridge_device->ports_list, list) {\n \t\tenum mlxsw_sp_flood_type packet_type = MLXSW_SP_FLOOD_TYPE_MC;\n \t\tbool member = mc_disabled ? true : bridge_port->mrouter;\n@@ -1207,9 +1218,8 @@ static int mlxsw_sp_port_mdb_op(struct mlxsw_sp *mlxsw_sp, const char *addr,\n \treturn err;\n }\n \n-/* clean the an entry from the HW and write there a full new entry */\n-static int mlxsw_sp_port_smid_full_entry(struct mlxsw_sp *mlxsw_sp,\n-\t\t\t\t\t u16 mid_idx)\n+static int mlxsw_sp_port_smid_full_entry(struct mlxsw_sp *mlxsw_sp, u16 mid_idx,\n+\t\t\t\t\t long *ports_bitmap)\n {\n \tchar *smid_pl;\n \tint err, i;\n@@ -1224,6 +1234,9 @@ static int mlxsw_sp_port_smid_full_entry(struct mlxsw_sp *mlxsw_sp,\n \t\t\tmlxsw_reg_smid_port_mask_set(smid_pl, i, 1);\n \t}\n \n+\tfor_each_set_bit(i, ports_bitmap, mlxsw_core_max_ports(mlxsw_sp->core))\n+\t\tmlxsw_reg_smid_port_set(smid_pl, i, 1);\n+\n \terr = mlxsw_reg_write(mlxsw_sp->core, MLXSW_REG(smid), smid_pl);\n \tkfree(smid_pl);\n \treturn err;\n@@ -1273,7 +1286,8 @@ mlxsw_sp_mc_write_mdb_entry(struct mlxsw_sp *mlxsw_sp,\n \t\treturn false;\n \n \tmid->mid = mid_idx;\n-\terr = mlxsw_sp_port_smid_full_entry(mlxsw_sp, mid_idx);\n+\terr = mlxsw_sp_port_smid_full_entry(mlxsw_sp, mid_idx,\n+\t\t\t\t\t mid->ports_in_mid);\n \tif (err)\n \t\treturn false;\n \n@@ -1414,6 +1428,25 @@ static int mlxsw_sp_port_mdb_add(struct mlxsw_sp_port *mlxsw_sp_port,\n \treturn err;\n }\n \n+static void\n+mlxsw_sp_bridge_mdb_mc_enable_sync(struct mlxsw_sp_port *mlxsw_sp_port,\n+\t\t\t\t struct mlxsw_sp_bridge_device\n+\t\t\t\t *bridge_device)\n+{\n+\tstruct mlxsw_sp *mlxsw_sp = mlxsw_sp_port->mlxsw_sp;\n+\tstruct mlxsw_sp_mid *mid;\n+\tbool mc_enabled;\n+\n+\tmc_enabled = bridge_device->multicast_enabled;\n+\n+\tlist_for_each_entry(mid, &bridge_device->mids_list, list) {\n+\t\tif (mc_enabled)\n+\t\t\tmlxsw_sp_mc_write_mdb_entry(mlxsw_sp, mid);\n+\t\telse\n+\t\t\tmlxsw_sp_mc_remove_mdb_entry(mlxsw_sp, mid);\n+\t}\n+}\n+\n static int mlxsw_sp_port_obj_add(struct net_device *dev,\n \t\t\t\t const struct switchdev_obj *obj,\n \t\t\t\t struct switchdev_trans *trans)\n","prefixes":["net-next","09/16"]}