{"id":816197,"url":"http://patchwork.ozlabs.org/api/patches/816197/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/patch/1505913181-82547-6-git-send-email-bhanuprakash.bodireddy@intel.com/","project":{"id":47,"url":"http://patchwork.ozlabs.org/api/projects/47/?format=json","name":"Open vSwitch","link_name":"openvswitch","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"git@github.com:openvswitch/ovs.git","webscm_url":"https://github.com/openvswitch/ovs","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1505913181-82547-6-git-send-email-bhanuprakash.bodireddy@intel.com>","list_archive_url":null,"date":"2017-09-20T13:12:54","name":"[ovs-dev,v2,05/12] dpif-netdev: Use DP_PACKET_BATCH_FOR_EACH in dp_netdev_run_meter.","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"5e181eba4b43087a8fe106780aa37d48de178416","submitter":{"id":68557,"url":"http://patchwork.ozlabs.org/api/people/68557/?format=json","name":"Bodireddy, Bhanuprakash","email":"bhanuprakash.bodireddy@intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/openvswitch/patch/1505913181-82547-6-git-send-email-bhanuprakash.bodireddy@intel.com/mbox/","series":[{"id":4111,"url":"http://patchwork.ozlabs.org/api/series/4111/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/list/?series=4111","date":"2017-09-20T13:12:49","name":"Use packet batch macro and APIs.","version":2,"mbox":"http://patchwork.ozlabs.org/series/4111/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/816197/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/816197/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xy0r92F9jz9rxj\n\tfor ;\n\tWed, 20 Sep 2017 23:26:17 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 4FBCCB1D;\n\tWed, 20 Sep 2017 13:22:48 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 21A40AB9\n\tfor ; Wed, 20 Sep 2017 13:22:42 +0000 (UTC)","from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id CAE70421\n\tfor ; Wed, 20 Sep 2017 13:22:41 +0000 (UTC)","from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t20 Sep 2017 06:22:41 -0700","from silpixa00393942.ir.intel.com (HELO\n\tsilpixa00393942.ger.corp.intel.com) ([10.237.223.42])\n\tby fmsmga004.fm.intel.com with ESMTP; 20 Sep 2017 06:22:40 -0700"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,421,1500966000\"; d=\"scan'208\";a=\"314221704\"","From":"Bhanuprakash Bodireddy ","To":"dev@openvswitch.org","Date":"Wed, 20 Sep 2017 14:12:54 +0100","Message-Id":"<1505913181-82547-6-git-send-email-bhanuprakash.bodireddy@intel.com>","X-Mailer":"git-send-email 2.4.11","In-Reply-To":"<1505913181-82547-1-git-send-email-bhanuprakash.bodireddy@intel.com>","References":"<1505913181-82547-1-git-send-email-bhanuprakash.bodireddy@intel.com>","X-Spam-Status":"No, score=-5.0 required=5.0 tests=RCVD_IN_DNSWL_HI,\n\tRP_MATCHES_RCVD autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"[ovs-dev] [PATCH v2 05/12] dpif-netdev: Use\n\tDP_PACKET_BATCH_FOR_EACH in dp_netdev_run_meter.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"},"content":"Use DP_PACKET_BATCH_FOR_EACH macro in dp_netdev_run_meter().\n\nSigned-off-by: Bhanuprakash Bodireddy \n---\n lib/dpif-netdev.c | 15 +++++++--------\n 1 file changed, 7 insertions(+), 8 deletions(-)","diff":"diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c\nindex ca74df8..5000f7a 100644\n--- a/lib/dpif-netdev.c\n+++ b/lib/dpif-netdev.c\n@@ -4121,10 +4121,11 @@ dp_netdev_run_meter(struct dp_netdev *dp, struct dp_packet_batch *packets_,\n {\n struct dp_meter *meter;\n struct dp_meter_band *band;\n+ struct dp_packet *packet;\n long long int long_delta_t; /* msec */\n uint32_t delta_t; /* msec */\n int i;\n- int cnt = packets_->count;\n+ const size_t cnt = dp_packet_batch_size(packets_);\n uint32_t bytes, volume;\n int exceeded_band[NETDEV_MAX_BURST];\n uint32_t exceeded_rate[NETDEV_MAX_BURST];\n@@ -4157,8 +4158,8 @@ dp_netdev_run_meter(struct dp_netdev *dp, struct dp_packet_batch *packets_,\n meter->used = now;\n meter->packet_count += cnt;\n bytes = 0;\n- for (i = 0; i < cnt; i++) {\n- bytes += dp_packet_size(packets_->packets[i]);\n+ DP_PACKET_BATCH_FOR_EACH (packet, packets_) {\n+ bytes += dp_packet_size(packet);\n }\n meter->byte_count += bytes;\n \n@@ -4208,8 +4209,8 @@ dp_netdev_run_meter(struct dp_netdev *dp, struct dp_packet_batch *packets_,\n } else {\n /* Packet sizes differ, must process one-by-one. */\n band_exceeded_pkt = cnt;\n- for (i = 0; i < cnt; i++) {\n- uint32_t bits = dp_packet_size(packets_->packets[i]) * 8;\n+ DP_PACKET_BATCH_FOR_EACH (packet, packets_) {\n+ uint32_t bits = dp_packet_size(packet) * 8;\n \n if (band->bucket >= bits) {\n band->bucket -= bits;\n@@ -4237,10 +4238,8 @@ dp_netdev_run_meter(struct dp_netdev *dp, struct dp_packet_batch *packets_,\n /* Fire the highest rate band exceeded by each packet.\n * Drop packets if needed, by swapping packet to the end that will be\n * ignored. */\n- const size_t size = dp_packet_batch_size(packets_);\n- struct dp_packet *packet;\n size_t j;\n- DP_PACKET_BATCH_REFILL_FOR_EACH (j, size, packet, packets_) {\n+ DP_PACKET_BATCH_REFILL_FOR_EACH (j, cnt, packet, packets_) {\n if (exceeded_band[j] >= 0) {\n /* Meter drop packet. */\n band = &meter->bands[exceeded_band[j]];\n","prefixes":["ovs-dev","v2","05/12"]}