{"id":816184,"url":"http://patchwork.ozlabs.org/api/patches/816184/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/150591153693.113604.8604505743746410801.stgit@buzz/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<150591153693.113604.8604505743746410801.stgit@buzz>","list_archive_url":null,"date":"2017-09-20T12:45:36","name":"net_sched: always reset qdisc backlog in qdisc_reset()","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"031ce5ccd206114c4c78792acd1cc2b5077e1301","submitter":{"id":65606,"url":"http://patchwork.ozlabs.org/api/people/65606/?format=json","name":"Konstantin Khlebnikov","email":"khlebnikov@yandex-team.ru"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/150591153693.113604.8604505743746410801.stgit@buzz/mbox/","series":[{"id":4106,"url":"http://patchwork.ozlabs.org/api/series/4106/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=4106","date":"2017-09-20T12:45:36","name":"net_sched: always reset qdisc backlog in qdisc_reset()","version":1,"mbox":"http://patchwork.ozlabs.org/series/4106/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/816184/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/816184/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=yandex-team.ru header.i=@yandex-team.ru\n\theader.b=\"DCL+85Ux\"; dkim-atps=neutral","smtpcorp1p.mail.yandex.net;\n\tdkim=pass header.i=@yandex-team.ru"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxzxR2yGMz9t2V\n\tfor ;\n\tWed, 20 Sep 2017 22:45:47 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751748AbdITMpp (ORCPT );\n\tWed, 20 Sep 2017 08:45:45 -0400","from forwardcorp1j.cmail.yandex.net ([5.255.227.106]:60649 \"EHLO\n\tforwardcorp1j.cmail.yandex.net\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1751554AbdITMpo (ORCPT\n\t); Wed, 20 Sep 2017 08:45:44 -0400","from smtpcorp1p.mail.yandex.net (smtpcorp1p.mail.yandex.net\n\t[IPv6:2a02:6b8:0:1472:2741:0:8b6:10])\n\tby forwardcorp1j.cmail.yandex.net (Yandex) with ESMTP id 3A3BB206AA; \n\tWed, 20 Sep 2017 15:45:42 +0300 (MSK)","from smtpcorp1p.mail.yandex.net (localhost.localdomain [127.0.0.1])\n\tby smtpcorp1p.mail.yandex.net (Yandex) with ESMTP id 377CD6E40B10;\n\tWed, 20 Sep 2017 15:45:42 +0300 (MSK)","from unknown (unknown [2a02:6b8:0:40c:95ec:fcac:6acb:d9d9])\n\tby smtpcorp1p.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id\n\tUbNQZzjCgr-jgs0vpPt; Wed, 20 Sep 2017 15:45:42 +0300\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (Client certificate not present)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru;\n\ts=default; \n\tt=1505911542; bh=9KR1lfYHY5cNpwKNCUqa9lWn2YM4svLYokVu9chnQEs=;\n\th=Subject:From:To:Cc:Date:Message-ID;\n\tb=DCL+85UxbIXonHDJYyFr4xuFKGQ+0IHd3PSZzQv+xkKilYNNeUSAzEfWXM3/5yeY+\n\thL0amhMwz0fx/P7gOcyP2sjc7Qr/tU/V5IGyBj/yV1Qe+gBFg1MJX9H2mXvCmX8yEA\n\tzSPMG9pjp0ecvXIoDEsttMcyHYD/SrAilUPElN/U=","Subject":"[PATCH] net_sched: always reset qdisc backlog in qdisc_reset()","From":"Konstantin Khlebnikov ","To":"netdev@vger.kernel.org, \"David S. Miller\" ","Cc":"Cong Wang , Jiri Pirko ,\n\tJamal Hadi Salim ","Date":"Wed, 20 Sep 2017 15:45:36 +0300","Message-ID":"<150591153693.113604.8604505743746410801.stgit@buzz>","User-Agent":"StGit/0.17.1-dirty","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"SKB stored in qdisc->gso_skb also counted into backlog.\n\nSome qdiscs don't reset backlog to zero in ->reset(),\nfor example sfq just dequeue and free all queued skb.\n\nSigned-off-by: Konstantin Khlebnikov \nFixes: 2ccccf5fb43f (\"net_sched: update hierarchical backlog too\")\n---\n net/sched/sch_generic.c | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c\nindex 92237e75dbbc..bf8c81e07c70 100644\n--- a/net/sched/sch_generic.c\n+++ b/net/sched/sch_generic.c\n@@ -685,6 +685,7 @@ void qdisc_reset(struct Qdisc *qdisc)\n \t\tqdisc->gso_skb = NULL;\n \t}\n \tqdisc->q.qlen = 0;\n+\tqdisc->qstats.backlog = 0;\n }\n EXPORT_SYMBOL(qdisc_reset);\n \n","prefixes":[]}