{"id":816142,"url":"http://patchwork.ozlabs.org/api/patches/816142/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/1505904778-53217-6-git-send-email-linyunsheng@huawei.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1505904778-53217-6-git-send-email-linyunsheng@huawei.com>","list_archive_url":null,"date":"2017-09-20T10:52:54","name":"[net,5/9] net: hns3: Fix for rx_priv_buf_alloc not setting rx shared buffer","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"b60750b6ba9130d20067a630dbc11a069296da97","submitter":{"id":71804,"url":"http://patchwork.ozlabs.org/api/people/71804/?format=json","name":"Yunsheng Lin","email":"linyunsheng@huawei.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1505904778-53217-6-git-send-email-linyunsheng@huawei.com/mbox/","series":[{"id":4080,"url":"http://patchwork.ozlabs.org/api/series/4080/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=4080","date":"2017-09-20T10:52:53","name":"TM related bugfixes for the HNS3 Ethernet Driver","version":1,"mbox":"http://patchwork.ozlabs.org/series/4080/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/816142/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/816142/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxxTV57jVz9s7c\n\tfor ;\n\tWed, 20 Sep 2017 20:54:54 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752097AbdITKyg (ORCPT );\n\tWed, 20 Sep 2017 06:54:36 -0400","from szxga04-in.huawei.com ([45.249.212.190]:6505 \"EHLO\n\tszxga04-in.huawei.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751916AbdITKx0 (ORCPT\n\t); Wed, 20 Sep 2017 06:53:26 -0400","from 172.30.72.59 (EHLO DGGEMS407-HUB.china.huawei.com)\n\t([172.30.72.59])\n\tby dggrg04-dlp.huawei.com (MOS 4.4.6-GA FastPath queued)\n\twith ESMTP id DHP73802; Wed, 20 Sep 2017 18:53:24 +0800 (CST)","from localhost.localdomain (10.67.212.75) by\n\tDGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP\n\tServer id 14.3.301.0; Wed, 20 Sep 2017 18:53:13 +0800"],"From":"Yunsheng Lin ","To":"","CC":", ,\n\t, ,\n\t, ,\n\t, ,\n\t, ,\n\t, ","Subject":"[PATCH net 5/9] net: hns3: Fix for rx_priv_buf_alloc not setting rx\n\tshared buffer","Date":"Wed, 20 Sep 2017 18:52:54 +0800","Message-ID":"<1505904778-53217-6-git-send-email-linyunsheng@huawei.com>","X-Mailer":"git-send-email 1.9.1","In-Reply-To":"<1505904778-53217-1-git-send-email-linyunsheng@huawei.com>","References":"<1505904778-53217-1-git-send-email-linyunsheng@huawei.com>","MIME-Version":"1.0","Content-Type":"text/plain","X-Originating-IP":"[10.67.212.75]","X-CFilter-Loop":"Reflected","X-Mirapoint-Virus-RAPID-Raw":"score=unknown(0),\n\trefid=str=0001.0A0B0205.59C248A4.0108, ss=1, re=0.000, recu=0.000,\n\treip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0,\n\tso=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32","X-Mirapoint-Loop-Id":"72ef87d0267fa6d1ebfe21ba86efed95","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"rx_priv_buf_alloc is used to tell hardware how much buffer is\nused for rx direction, right now only the private buffer is\nassigned.\nFor ae_dev that doesn't support DCB, private rx buffer is assigned\nto zero, only shared rx buffer is used. So not setting the shared\nrx buffer cause dropping of packet in SSU.\n\nFixes: 46a3df9f9718 (\"net: hns3: Add HNS3 Acceleration Engine & Compatibility Layer Support\")\nSigned-off-by: Yunsheng Lin \n---\n drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 3 ++-\n drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 4 ++++\n 2 files changed, 6 insertions(+), 1 deletion(-)","diff":"diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h\nindex 30e2ad5..758cf39 100644\n--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h\n+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h\n@@ -270,7 +270,8 @@ struct hclge_tx_buff_alloc {\n \n struct hclge_rx_priv_buff {\n \t__le16 buf_num[HCLGE_TC_NUM];\n-\tu8 rsv[8];\n+\t__le16 shared_buf;\n+\tu8 rsv[6];\n };\n \n struct hclge_query_version {\ndiff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c\nindex bf3179a..c08c41f 100644\n--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c\n+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c\n@@ -1622,6 +1622,10 @@ static int hclge_rx_priv_buf_alloc(struct hclge_dev *hdev)\n \t\t\tcpu_to_le16(true << HCLGE_TC0_PRI_BUF_EN_B);\n \t}\n \n+\treq->shared_buf =\n+\t\tcpu_to_le16((hdev->s_buf.buf_size >> HCLGE_BUF_UNIT_S) |\n+\t\t\t (1 << HCLGE_TC0_PRI_BUF_EN_B));\n+\n \tret = hclge_cmd_send(&hdev->hw, &desc, 1);\n \tif (ret) {\n \t\tdev_err(&hdev->pdev->dev,\n","prefixes":["net","5/9"]}