{"id":816140,"url":"http://patchwork.ozlabs.org/api/patches/816140/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/1505904778-53217-7-git-send-email-linyunsheng@huawei.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1505904778-53217-7-git-send-email-linyunsheng@huawei.com>","list_archive_url":null,"date":"2017-09-20T10:52:55","name":"[net,6/9] net: hns3: Fix for rx priv buf allocation when DCB is not supported","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"e427a2ccec5eb8a4d33d8e7dfe7ba52fafef7223","submitter":{"id":71804,"url":"http://patchwork.ozlabs.org/api/people/71804/?format=json","name":"Yunsheng Lin","email":"linyunsheng@huawei.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1505904778-53217-7-git-send-email-linyunsheng@huawei.com/mbox/","series":[{"id":4080,"url":"http://patchwork.ozlabs.org/api/series/4080/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=4080","date":"2017-09-20T10:52:53","name":"TM related bugfixes for the HNS3 Ethernet Driver","version":1,"mbox":"http://patchwork.ozlabs.org/series/4080/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/816140/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/816140/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxxSy0rGFz9s7c\n\tfor ;\n\tWed, 20 Sep 2017 20:54:26 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751763AbdITKyP (ORCPT );\n\tWed, 20 Sep 2017 06:54:15 -0400","from szxga04-in.huawei.com ([45.249.212.190]:6508 \"EHLO\n\tszxga04-in.huawei.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751940AbdITKx1 (ORCPT\n\t); Wed, 20 Sep 2017 06:53:27 -0400","from 172.30.72.59 (EHLO DGGEMS407-HUB.china.huawei.com)\n\t([172.30.72.59])\n\tby dggrg04-dlp.huawei.com (MOS 4.4.6-GA FastPath queued)\n\twith ESMTP id DHP73807; Wed, 20 Sep 2017 18:53:25 +0800 (CST)","from localhost.localdomain (10.67.212.75) by\n\tDGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP\n\tServer id 14.3.301.0; Wed, 20 Sep 2017 18:53:14 +0800"],"From":"Yunsheng Lin ","To":"","CC":", ,\n\t, ,\n\t, ,\n\t, ,\n\t, ,\n\t, ","Subject":"[PATCH net 6/9] net: hns3: Fix for rx priv buf allocation when DCB\n\tis not supported","Date":"Wed, 20 Sep 2017 18:52:55 +0800","Message-ID":"<1505904778-53217-7-git-send-email-linyunsheng@huawei.com>","X-Mailer":"git-send-email 1.9.1","In-Reply-To":"<1505904778-53217-1-git-send-email-linyunsheng@huawei.com>","References":"<1505904778-53217-1-git-send-email-linyunsheng@huawei.com>","MIME-Version":"1.0","Content-Type":"text/plain","X-Originating-IP":"[10.67.212.75]","X-CFilter-Loop":"Reflected","X-Mirapoint-Virus-RAPID-Raw":"score=unknown(0),\n\trefid=str=0001.0A0B0202.59C248A5.007D, ss=1, re=0.000, recu=0.000,\n\treip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0,\n\tso=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32","X-Mirapoint-Loop-Id":"30e6abfdd22f976b63643ad21d26c318","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"When hdev doesn't support DCB, rx private buffer is not allocated,\notherwise there is not enough buffer for rx shared buffer, causing\nbuffer allocation process to fail.\nThis patch fixes by checking the dcb capability in\nhclge_rx_buffer_calc.\n\nFixes: 46a3df9f9718 (\"net: hns3: Add HNS3 Acceleration Engine & Compatibility Layer Support\")\nSigned-off-by: Yunsheng Lin \n---\n drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 10 ++++++++++\n 1 file changed, 10 insertions(+)","diff":"diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c\nindex c08c41f..1e15ce1 100644\n--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c\n+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c\n@@ -1489,6 +1489,16 @@ int hclge_rx_buffer_calc(struct hclge_dev *hdev, u32 tx_size)\n \tstruct hclge_priv_buf *priv;\n \tint i;\n \n+\t/* When DCB is not supported, rx private\n+\t * buffer is not allocated.\n+\t */\n+\tif (!hnae3_dev_dcb_supported(hdev)) {\n+\t\tif (!hclge_is_rx_buf_ok(hdev, rx_all))\n+\t\t\treturn -ENOMEM;\n+\n+\t\treturn 0;\n+\t}\n+\n \t/* step 1, try to alloc private buffer for all enabled tc */\n \tfor (i = 0; i < HCLGE_MAX_TC_NUM; i++) {\n \t\tpriv = &hdev->priv_buf[i];\n","prefixes":["net","6/9"]}