{"id":816127,"url":"http://patchwork.ozlabs.org/api/patches/816127/?format=json","web_url":"http://patchwork.ozlabs.org/project/ubuntu-kernel/patch/20170920102707.8266-2-colin.king@canonical.com/","project":{"id":15,"url":"http://patchwork.ozlabs.org/api/projects/15/?format=json","name":"Ubuntu Kernel","link_name":"ubuntu-kernel","list_id":"kernel-team.lists.ubuntu.com","list_email":"kernel-team@lists.ubuntu.com","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170920102707.8266-2-colin.king@canonical.com>","list_archive_url":null,"date":"2017-09-20T10:27:05","name":"[1/3] UBUNTU: SAUCE: opennsl: bcm-knet: check for null sinfo to avoid a null pointer dereference","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"5c97529f280400e5867bff4602c0149ac03046c5","submitter":{"id":2900,"url":"http://patchwork.ozlabs.org/api/people/2900/?format=json","name":"Colin Ian King","email":"colin.king@canonical.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/ubuntu-kernel/patch/20170920102707.8266-2-colin.king@canonical.com/mbox/","series":[{"id":4075,"url":"http://patchwork.ozlabs.org/api/series/4075/?format=json","web_url":"http://patchwork.ozlabs.org/project/ubuntu-kernel/list/?series=4075","date":"2017-09-20T10:27:04","name":"UBUNTU: SAUCE: opennsl: fix static analysis issues","version":1,"mbox":"http://patchwork.ozlabs.org/series/4075/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/816127/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/816127/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=kernel-team-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxwsf5ppXz9sNw;\n\tWed, 20 Sep 2017 20:27:18 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1ducDq-0002N9-C1; Wed, 20 Sep 2017 10:27:14 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1ducDk-0002Gf-P5\n\tfor kernel-team@lists.ubuntu.com; Wed, 20 Sep 2017 10:27:08 +0000","from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost)\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.76) (envelope-from )\n\tid 1ducDk-00080k-72; Wed, 20 Sep 2017 10:27:08 +0000"],"From":"Colin King ","To":"kernel-team@lists.ubuntu.com","Subject":"[PATCH 1/3] UBUNTU: SAUCE: opennsl: bcm-knet: check for null sinfo\n\tto avoid a null pointer dereference","Date":"Wed, 20 Sep 2017 11:27:05 +0100","Message-Id":"<20170920102707.8266-2-colin.king@canonical.com>","X-Mailer":"git-send-email 2.14.1","In-Reply-To":"<20170920102707.8266-1-colin.king@canonical.com>","References":"<20170920102707.8266-1-colin.king@canonical.com>","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" "},"content":"From: Colin Ian King \n\nBugLink: https://launchpad.net/bugs/1718388\n\nsinfo can potentially be null, so add a null check to avoid a null\npointer deference on sinfo->info_id.\n\nDetected by CoverityScan CID#1456902 (\"Dereference before null check\")\n\nSigned-off-by: Colin Ian King \n---\n .../systems/linux/kernel/modules/bcm-knet/bcm-knet.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/ubuntu/opennsl/OpenNSL/sdk-6.4.10-gpl-modules/systems/linux/kernel/modules/bcm-knet/bcm-knet.c b/ubuntu/opennsl/OpenNSL/sdk-6.4.10-gpl-modules/systems/linux/kernel/modules/bcm-knet/bcm-knet.c\nindex 9dc94b3..9aed5dc 100644\n--- a/ubuntu/opennsl/OpenNSL/sdk-6.4.10-gpl-modules/systems/linux/kernel/modules/bcm-knet/bcm-knet.c\n+++ b/ubuntu/opennsl/OpenNSL/sdk-6.4.10-gpl-modules/systems/linux/kernel/modules/bcm-knet/bcm-knet.c\n@@ -5605,7 +5605,8 @@ bkn_get_next_dma_event(kcom_msg_dma_info_t *kmsg)\n sinfo = bkn_sinfo_from_unit(dev_no);\n }\n \n- if ((sinfo->inst_id != 0) && ((sinfo->inst_id & (1 << dev_evt)) == 0)){\n+ if (sinfo && (sinfo->inst_id != 0) &&\n+\t ((sinfo->inst_id & (1 << dev_evt)) == 0)) {\n DBG_INST((\" %s skip dev(%d)\\n\",__FUNCTION__,dev_evt));\n continue;\n }\n","prefixes":["1/3"]}