{"id":816126,"url":"http://patchwork.ozlabs.org/api/patches/816126/?format=json","web_url":"http://patchwork.ozlabs.org/project/ubuntu-kernel/patch/20170920102707.8266-3-colin.king@canonical.com/","project":{"id":15,"url":"http://patchwork.ozlabs.org/api/projects/15/?format=json","name":"Ubuntu Kernel","link_name":"ubuntu-kernel","list_id":"kernel-team.lists.ubuntu.com","list_email":"kernel-team@lists.ubuntu.com","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170920102707.8266-3-colin.king@canonical.com>","list_archive_url":null,"date":"2017-09-20T10:27:06","name":"[2/3] UBUNTU: SAUCE: opennsl: bcm-knet: remove redundant null checks on dev->name","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"f2df92a42a3b6b205867887ff511ae32573f8b59","submitter":{"id":2900,"url":"http://patchwork.ozlabs.org/api/people/2900/?format=json","name":"Colin Ian King","email":"colin.king@canonical.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/ubuntu-kernel/patch/20170920102707.8266-3-colin.king@canonical.com/mbox/","series":[{"id":4075,"url":"http://patchwork.ozlabs.org/api/series/4075/?format=json","web_url":"http://patchwork.ozlabs.org/project/ubuntu-kernel/list/?series=4075","date":"2017-09-20T10:27:04","name":"UBUNTU: SAUCE: opennsl: fix static analysis issues","version":1,"mbox":"http://patchwork.ozlabs.org/series/4075/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/816126/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/816126/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=kernel-team-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxwsf46myz9s81;\n\tWed, 20 Sep 2017 20:27:18 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1ducDr-0002Nu-0W; Wed, 20 Sep 2017 10:27:15 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1ducDl-0002HW-87\n\tfor kernel-team@lists.ubuntu.com; Wed, 20 Sep 2017 10:27:09 +0000","from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost)\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.76) (envelope-from )\n\tid 1ducDk-00080p-P7; Wed, 20 Sep 2017 10:27:08 +0000"],"From":"Colin King ","To":"kernel-team@lists.ubuntu.com","Subject":"[PATCH 2/3] UBUNTU: SAUCE: opennsl: bcm-knet: remove redundant null\n\tchecks on dev->name","Date":"Wed, 20 Sep 2017 11:27:06 +0100","Message-Id":"<20170920102707.8266-3-colin.king@canonical.com>","X-Mailer":"git-send-email 2.14.1","In-Reply-To":"<20170920102707.8266-1-colin.king@canonical.com>","References":"<20170920102707.8266-1-colin.king@canonical.com>","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" "},"content":"From: Colin Ian King \n\nBugLink: https://launchpad.net/bugs/1718388\n\ndev->name is a char array and hence can never be null and so the\nnull checks on dev->name are redundant. Remove them.\n\nDetected by CoverityScan CID#1456897, CID#145690 (\"Array compared\nagainst 0\")\n\nSigned-off-by: Colin Ian King \n---\n .../systems/linux/kernel/modules/bcm-knet/bcm-knet.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/ubuntu/opennsl/OpenNSL/sdk-6.4.10-gpl-modules/systems/linux/kernel/modules/bcm-knet/bcm-knet.c b/ubuntu/opennsl/OpenNSL/sdk-6.4.10-gpl-modules/systems/linux/kernel/modules/bcm-knet/bcm-knet.c\nindex 9aed5dc..8f9589f 100644\n--- a/ubuntu/opennsl/OpenNSL/sdk-6.4.10-gpl-modules/systems/linux/kernel/modules/bcm-knet/bcm-knet.c\n+++ b/ubuntu/opennsl/OpenNSL/sdk-6.4.10-gpl-modules/systems/linux/kernel/modules/bcm-knet/bcm-knet.c\n@@ -3786,7 +3786,7 @@ bkn_proc_link_show(struct seq_file *m, void *v)\n list_for_each(dlist, &sinfo->ndev_list) {\n priv = (bkn_priv_t *)dlist;\n dev = priv->dev;\n- if (dev && dev->name) {\n+ if (dev) {\n seq_printf(m, \" %-14s %s\\n\", dev->name,\n netif_carrier_ok(dev) ? \"up\" : \"down\");\n }\n@@ -3847,7 +3847,7 @@ bkn_proc_link_write(struct file *file, const char *buf,\n list_for_each(dlist, &sinfo->ndev_list) {\n priv = (bkn_priv_t *)dlist;\n dev = priv->dev;\n- if (dev && dev->name) {\n+ if (dev) {\n if (memcmp(dev->name, link_str, len) == 0) {\n break;\n }\n","prefixes":["2/3"]}