{"id":816117,"url":"http://patchwork.ozlabs.org/api/patches/816117/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1505901971-12004-2-git-send-email-arvind.yadav.cs@gmail.com/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<1505901971-12004-2-git-send-email-arvind.yadav.cs@gmail.com>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/1505901971-12004-2-git-send-email-arvind.yadav.cs@gmail.com/","date":"2017-09-20T10:06:09","name":"[1/3] ASoC: davinci-mcasp: Handle return value of devm_kasprintf","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"8d259969cece985bb9504cbfac3dca1086e51d93","submitter":{"id":69434,"url":"http://patchwork.ozlabs.org/api/people/69434/?format=json","name":"Arvind Yadav","email":"arvind.yadav.cs@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1505901971-12004-2-git-send-email-arvind.yadav.cs@gmail.com/mbox/","series":[{"id":4069,"url":"http://patchwork.ozlabs.org/api/series/4069/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=4069","date":"2017-09-20T10:06:08","name":"ASoC: Handle return value of devm_kasprintf","version":1,"mbox":"http://patchwork.ozlabs.org/series/4069/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/816117/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/816117/checks/","tags":{},"related":[],"headers":{"Return-Path":"<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxwVx4Tyqz9s81\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 20 Sep 2017 20:11:05 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xxwVx0JtfzDqYG\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 20 Sep 2017 20:11:05 +1000 (AEST)","from mail-pg0-x241.google.com (mail-pg0-x241.google.com\n\t[IPv6:2607:f8b0:400e:c05::241])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xxwQW6SMPzDqZv\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tWed, 20 Sep 2017 20:07:15 +1000 (AEST)","by mail-pg0-x241.google.com with SMTP id m30so1382214pgn.5\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tWed, 20 Sep 2017 03:07:15 -0700 (PDT)","from symbol-HP-Z420-Workstation.zebra.lan ([223.31.70.102])\n\tby smtp.googlemail.com with ESMTPSA id\n\tu12sm10492250pfg.146.2017.09.20.03.07.09\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 20 Sep 2017 03:07:13 -0700 (PDT)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"WZRK6xu5\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"WZRK6xu5\"; dkim-atps=neutral","ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gmail.com\n\t(client-ip=2607:f8b0:400e:c05::241; helo=mail-pg0-x241.google.com;\n\tenvelope-from=arvind.yadav.cs@gmail.com; receiver=<UNKNOWN>)","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"WZRK6xu5\"; dkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=MQ6i9uXC1pI6R8MCIzH2cRRwlYy18zYzU8hhVbWzst4=;\n\tb=WZRK6xu5Bg0BimUGshCH/HMrSiS3wIHshrTr4I8PEbwk07Hz4uurbhKmP7LjG9wLIj\n\tR6ZZ+OJPjJJgLchEceO0+KVsYpmB+KmuCceluxSESp1VxaPhLduj5sOmMOoj9whaguku\n\t5/sNvykmmazXePQIFIqf9zwleTDuQnq277sj4KOfi9jf9sAvHSQSANlkwsQkhIu4Jmsw\n\tgVa617CrJZuRckdCTViF5abgAttl21wpouMiDSWkD/gAAaa58mW/hAUS0plzBWgz3Pz6\n\tvPgXtnsiWRBPEM5hE8TUcEdB6Im36U/D4xKgOZBQLcdUG9gFtZHN5QvkT3mNPgmCEWpS\n\tW43Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=MQ6i9uXC1pI6R8MCIzH2cRRwlYy18zYzU8hhVbWzst4=;\n\tb=NGx4oirmp564x1bWiznf6iMmhscP4QNx/nvUO3Zmc4/t1GrItn3GLzT9FjkRWPmvwu\n\tRJ60BHXT0wKWu/ylbPgQNpGNsV1kx8QAwRqS54do6SUpupgTavSzxbnX74IDi9JN+nag\n\t+5LhDOGccMp0oKJhfrFINuOe2IU6xe7i6ciRh6VvfKzP27WYMjTqehqTLkqGgMKl++YQ\n\t+4tqr1GCf6EJkHGCUCrpJaoLp70jDud5oBWOynvEiJd9DXemQaN7T4kss9PiAuLw5CSX\n\twu+y56Ui4vI1PVhjHKyhqHIDObKKddrwcx1NDVf5se3u2poG2n5uW+r6ZZCK7be3aJII\n\t5o/A==","X-Gm-Message-State":"AHPjjUgrT/Bm8dq/BMaRcAFqsvxdDiozCUPyFxYJ6RUIWAqf8bHguW7O\n\tNYPxdZxj9r249CNM+n0z9/Y=","X-Google-Smtp-Source":"AOwi7QAKhDB7ZuK5g7oUHWK0sfUgdMOjQd+5j/E3mTFrFy7OELPncVOL5O1QdfYPHdqDdYaPAFfbhQ==","X-Received":"by 10.101.82.9 with SMTP id o9mr1685584pgp.42.1505902033633;\n\tWed, 20 Sep 2017 03:07:13 -0700 (PDT)","From":"Arvind Yadav <arvind.yadav.cs@gmail.com>","To":"lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, \n\ttimur@tabi.org, nicoleotsuka@gmail.com, Xiubo.Lee@gmail.com,\n\tfabio.estevam@nxp.com, peter.ujfalusi@ti.com,\n\talsa-devel@alsa-project.org, linux-kernel@vger.kernel.org","Subject":"[PATCH 1/3] ASoC: davinci-mcasp: Handle return value of\n\tdevm_kasprintf","Date":"Wed, 20 Sep 2017 15:36:09 +0530","Message-Id":"<1505901971-12004-2-git-send-email-arvind.yadav.cs@gmail.com>","X-Mailer":"git-send-email 1.9.1","In-Reply-To":"<1505901971-12004-1-git-send-email-arvind.yadav.cs@gmail.com>","References":"<1505901971-12004-1-git-send-email-arvind.yadav.cs@gmail.com>","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>","List-Unsubscribe":"<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>","List-Archive":"<http://lists.ozlabs.org/pipermail/linuxppc-dev/>","List-Post":"<mailto:linuxppc-dev@lists.ozlabs.org>","List-Help":"<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>","List-Subscribe":"<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>","Cc":"linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>"},"content":"devm_kasprintf() can fail here and we must check its return value.\n\nSigned-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>\n---\n sound/soc/davinci/davinci-mcasp.c | 12 ++++++++++++\n 1 file changed, 12 insertions(+)","diff":"diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c\nindex f395bbc..d1a4aa2 100644\n--- a/sound/soc/davinci/davinci-mcasp.c\n+++ b/sound/soc/davinci/davinci-mcasp.c\n@@ -1867,6 +1867,10 @@ static int davinci_mcasp_probe(struct platform_device *pdev)\n \tif (irq >= 0) {\n \t\tirq_name = devm_kasprintf(&pdev->dev, GFP_KERNEL, \"%s_common\",\n \t\t\t\t\t  dev_name(&pdev->dev));\n+\t\tif (!irq_name) {\n+\t\t\tret = -ENOMEM;\n+\t\t\tgoto err;\n+\t\t}\n \t\tret = devm_request_threaded_irq(&pdev->dev, irq, NULL,\n \t\t\t\t\t\tdavinci_mcasp_common_irq_handler,\n \t\t\t\t\t\tIRQF_ONESHOT | IRQF_SHARED,\n@@ -1884,6 +1888,10 @@ static int davinci_mcasp_probe(struct platform_device *pdev)\n \tif (irq >= 0) {\n \t\tirq_name = devm_kasprintf(&pdev->dev, GFP_KERNEL, \"%s_rx\",\n \t\t\t\t\t  dev_name(&pdev->dev));\n+\t\tif (!irq_name) {\n+\t\t\tret = -ENOMEM;\n+\t\t\tgoto err;\n+\t\t}\n \t\tret = devm_request_threaded_irq(&pdev->dev, irq, NULL,\n \t\t\t\t\t\tdavinci_mcasp_rx_irq_handler,\n \t\t\t\t\t\tIRQF_ONESHOT, irq_name, mcasp);\n@@ -1899,6 +1907,10 @@ static int davinci_mcasp_probe(struct platform_device *pdev)\n \tif (irq >= 0) {\n \t\tirq_name = devm_kasprintf(&pdev->dev, GFP_KERNEL, \"%s_tx\",\n \t\t\t\t\t  dev_name(&pdev->dev));\n+\t\tif (!irq_name) {\n+\t\t\tret = -ENOMEM;\n+\t\t\tgoto err;\n+\t\t}\n \t\tret = devm_request_threaded_irq(&pdev->dev, irq, NULL,\n \t\t\t\t\t\tdavinci_mcasp_tx_irq_handler,\n \t\t\t\t\t\tIRQF_ONESHOT, irq_name, mcasp);\n","prefixes":["1/3"]}