{"id":816079,"url":"http://patchwork.ozlabs.org/api/patches/816079/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/patch/1505891589-6632-2-git-send-email-arvind.yadav.cs@gmail.com/","project":{"id":42,"url":"http://patchwork.ozlabs.org/api/projects/42/?format=json","name":"Linux GPIO development","link_name":"linux-gpio","list_id":"linux-gpio.vger.kernel.org","list_email":"linux-gpio@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1505891589-6632-2-git-send-email-arvind.yadav.cs@gmail.com>","list_archive_url":null,"date":"2017-09-20T07:13:08","name":"[1/2] gpio: brcmstb: Handle return value of devm_kasprintf","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ee37a599601d3de82647888542100087492069b6","submitter":{"id":69434,"url":"http://patchwork.ozlabs.org/api/people/69434/?format=json","name":"Arvind Yadav","email":"arvind.yadav.cs@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-gpio/patch/1505891589-6632-2-git-send-email-arvind.yadav.cs@gmail.com/mbox/","series":[{"id":4043,"url":"http://patchwork.ozlabs.org/api/series/4043/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/list/?series=4043","date":"2017-09-20T07:13:07","name":"Handle return value of devm_kasprintf","version":1,"mbox":"http://patchwork.ozlabs.org/series/4043/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/816079/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/816079/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-gpio-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"fo1JDVjA\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxrbL6RbJz9s81\n\tfor ;\n\tWed, 20 Sep 2017 17:14:38 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751730AbdITHOO (ORCPT );\n\tWed, 20 Sep 2017 03:14:14 -0400","from mail-pg0-f68.google.com ([74.125.83.68]:36901 \"EHLO\n\tmail-pg0-f68.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751666AbdITHOL (ORCPT\n\t); Wed, 20 Sep 2017 03:14:11 -0400","by mail-pg0-f68.google.com with SMTP id v5so1181761pgn.4;\n\tWed, 20 Sep 2017 00:14:11 -0700 (PDT)","from symbol-HP-Z420-Workstation.zebra.lan ([223.31.70.102])\n\tby smtp.googlemail.com with ESMTPSA id\n\t195sm5927913pgg.42.2017.09.20.00.14.07\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 20 Sep 2017 00:14:10 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=ehpOF8LqfzbIHCwrTCRjrL7cPywbkI1IrZmnMmYZi5Y=;\n\tb=fo1JDVjAqIZbT0p3Dkoz89of6I16F5RyH9h3SNq7g25JIY+9KQh1xJ3vf0lMFIlcuz\n\t+zgvfDEfVPWOzOGEHi/NP8QfvdXwyjS4l+vHeb85WwvZXwOMqAz0f33c+yiTgaCNEzA7\n\t7MI89QyRDjKH6vc2TlqtYaMIpLm0YOT84aXXbK5evB7LtXjN5pRs7U9GLs1jjn667F7v\n\t9fPonV8M+18smbYACSpXOr9DxsY3uB2XGkwOzcr0Fp1QM3pSbKhT/eAxO1obM1GipHiM\n\tN1ltgYUYKlFd52kCUytWITSegYQe47RKCZXcpMY/oGufYOVWJRaW6ZGK25GwG+eHh+Sx\n\tq9CQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=ehpOF8LqfzbIHCwrTCRjrL7cPywbkI1IrZmnMmYZi5Y=;\n\tb=ol8ji33xaqumYcbTD+etGgJ49hMkttmWPVVdFWm2Y5cOJoW57fIpxncH/zWGjOvTwx\n\t7ZcKXrDfKaHSD6YXYylTwOF9GDtrGYFN/C+dNZnEFRUnSvCYxPk3A93JDHMNdUuN8Oxt\n\tcw0gpYmuEz4KTuUPEF7P5q1jn8NiR748SptySP/u6yRIed0/D7rsEgQKK6P2Q7Zscqxe\n\tO507OBDDIDKAVqCrEww3SnGxVTIjF7UE5R6tEivVlOvy5TE9ULoh9JyhYJ3+v4T+K6Iv\n\tek9afdUXNUIqdxJIY7hkipf0a+niaDD2IZllPMMDd+x9KbsYt4vY5YC20dd+SHLrvVem\n\tCWAg==","X-Gm-Message-State":"AHPjjUgrfoP31+u7pLLzkec83mz9mvm0ONja8dPgg40hdgaVvXRcGQiF\n\tatnOpOPodIS88gbERr4PZe4=","X-Google-Smtp-Source":"AOwi7QBsdYMRXOOklwTP6JzE25tEIvxe0sct4divX/JiEy/msaoD6HF67Tzc41G0gmcDuOTNxyXlVw==","X-Received":"by 10.98.157.73 with SMTP id i70mr1208520pfd.268.1505891650883; \n\tWed, 20 Sep 2017 00:14:10 -0700 (PDT)","From":"Arvind Yadav ","To":"gregory.0xf0@gmail.com, linus.walleij@linaro.org,\n\tcomputersforpeace@gmail.com, f.fainelli@gmail.com","Cc":"bcm-kernel-feedback-list@broadcom.com, linux-gpio@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org","Subject":"[PATCH 1/2] gpio: brcmstb: Handle return value of devm_kasprintf","Date":"Wed, 20 Sep 2017 12:43:08 +0530","Message-Id":"<1505891589-6632-2-git-send-email-arvind.yadav.cs@gmail.com>","X-Mailer":"git-send-email 1.9.1","In-Reply-To":"<1505891589-6632-1-git-send-email-arvind.yadav.cs@gmail.com>","References":"<1505891589-6632-1-git-send-email-arvind.yadav.cs@gmail.com>","Sender":"linux-gpio-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"},"content":"devm_kasprintf() can fail here and we must check its return value.\n\nSigned-off-by: Arvind Yadav \n---\n drivers/gpio/gpio-brcmstb.c | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/drivers/gpio/gpio-brcmstb.c b/drivers/gpio/gpio-brcmstb.c\nindex dd0308c..1227d6e 100644\n--- a/drivers/gpio/gpio-brcmstb.c\n+++ b/drivers/gpio/gpio-brcmstb.c\n@@ -485,6 +485,9 @@ static int brcmstb_gpio_probe(struct platform_device *pdev)\n \t\tgc->of_node = np;\n \t\tgc->owner = THIS_MODULE;\n \t\tgc->label = devm_kasprintf(dev, GFP_KERNEL, \"%pOF\", dev->of_node);\n+\t\tif (!gc->label)\n+\t\t\tgoto fail;\n+\n \t\tgc->base = gpio_base;\n \t\tgc->of_gpio_n_cells = 2;\n \t\tgc->of_xlate = brcmstb_gpio_of_xlate;\n","prefixes":["1/2"]}