{"id":816078,"url":"http://patchwork.ozlabs.org/api/patches/816078/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/patch/1505891589-6632-3-git-send-email-arvind.yadav.cs@gmail.com/","project":{"id":42,"url":"http://patchwork.ozlabs.org/api/projects/42/?format=json","name":"Linux GPIO development","link_name":"linux-gpio","list_id":"linux-gpio.vger.kernel.org","list_email":"linux-gpio@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1505891589-6632-3-git-send-email-arvind.yadav.cs@gmail.com>","list_archive_url":null,"date":"2017-09-20T07:13:09","name":"[2/2] gpio: tb10x: Handle return value of devm_kasprintf","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"f9ad4025403f403f444e2548c555b345c9efdbb7","submitter":{"id":69434,"url":"http://patchwork.ozlabs.org/api/people/69434/?format=json","name":"Arvind Yadav","email":"arvind.yadav.cs@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-gpio/patch/1505891589-6632-3-git-send-email-arvind.yadav.cs@gmail.com/mbox/","series":[{"id":4043,"url":"http://patchwork.ozlabs.org/api/series/4043/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/list/?series=4043","date":"2017-09-20T07:13:07","name":"Handle return value of devm_kasprintf","version":1,"mbox":"http://patchwork.ozlabs.org/series/4043/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/816078/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/816078/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-gpio-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"gJp49+st\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxrb43G4tz9s81\n\tfor ;\n\tWed, 20 Sep 2017 17:14:24 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751801AbdITHOQ (ORCPT );\n\tWed, 20 Sep 2017 03:14:16 -0400","from mail-pf0-f195.google.com ([209.85.192.195]:35438 \"EHLO\n\tmail-pf0-f195.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751771AbdITHOO (ORCPT\n\t); Wed, 20 Sep 2017 03:14:14 -0400","by mail-pf0-f195.google.com with SMTP id i23so874236pfi.2;\n\tWed, 20 Sep 2017 00:14:14 -0700 (PDT)","from symbol-HP-Z420-Workstation.zebra.lan ([223.31.70.102])\n\tby smtp.googlemail.com with ESMTPSA id\n\t195sm5927913pgg.42.2017.09.20.00.14.11\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 20 Sep 2017 00:14:13 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=1wAxjax2nzD3DLIz/+gXxgwPnmKL4TYJUSg3RaNS1E0=;\n\tb=gJp49+stTqRXIrO82MS7oTc1e9ja8MCRAQvDG/1xHMDmJlJ5WYZK4FDQ3+3Yq+Ych9\n\t0x6M4+/y0ZImUV6/PPDOyqvNPLyLgNKKaZXHwNAR19ox+e6wefZwK/oRHSoYBXycrJNI\n\tchihNmEA0uAs9VYWf7FJRk4xlP7z4S1rtADO5PuF+ep7bPfZU+P0vxSs7FKs56ti7bNJ\n\tmoVMSmARg5rsJpwJkkpHWETzNSc3kbYPXOYxEir9ETj8kj5nEtrRNFIr1OJ2NyZIoAVH\n\twBK7ya2z/v/ZkBtBW8OyxO2XLiSVfj+wO6Sju8vFlNWXc3EGjvpBDgMl3K16z2NgTl1U\n\tuMRg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=1wAxjax2nzD3DLIz/+gXxgwPnmKL4TYJUSg3RaNS1E0=;\n\tb=Cpdg5wq0WoEfZ6i521j/VnFf9GKVucJz7OfZtLcHm/TQJYOqTVQZop6/t/dKOHR6HY\n\tF+E00Bm4wz4Gaj/F+FFzbfwsOppHPv2S9J2+0CnixdDHpa4ZOUtR10YEJlVzlV7Wnxjr\n\tKVOu4OrusFtf7YrXju0pBe15tDd7VDZojoPwsqMt4PhQdXaidTCWrGwjY5icwbAR2HDP\n\tDcWBDNhVGOlQfiXJ0G549ubCR8czK+EKGR8LsUlel3WBCbinn0BhgS92mYwtY+5f/c3g\n\ttdFidYejr7vUogF7/DVMWmrDKUicxMi6+B10ST8Qba2jjywNiFbvso1FZXVgagfjHpph\n\tbmAw==","X-Gm-Message-State":"AHPjjUhWUq2YU1jjJPAp4WOw7uiisautuwb2N8u4aS8Ni7zgXew6t4Bx\n\tl/ZmPDBl/HxcpwI0AUFgX8PiTw==","X-Google-Smtp-Source":"AOwi7QBGQUork/IHRZDkM62UFBdpIgsceJ9Ta+MSHIotRUyVrsaZQa17+RuQr+wQpBO3fmebv/jjPA==","X-Received":"by 10.84.129.226 with SMTP id b89mr1143522plb.438.1505891654123; \n\tWed, 20 Sep 2017 00:14:14 -0700 (PDT)","From":"Arvind Yadav ","To":"gregory.0xf0@gmail.com, linus.walleij@linaro.org,\n\tcomputersforpeace@gmail.com, f.fainelli@gmail.com","Cc":"bcm-kernel-feedback-list@broadcom.com, linux-gpio@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org","Subject":"[PATCH 2/2] gpio: tb10x: Handle return value of devm_kasprintf","Date":"Wed, 20 Sep 2017 12:43:09 +0530","Message-Id":"<1505891589-6632-3-git-send-email-arvind.yadav.cs@gmail.com>","X-Mailer":"git-send-email 1.9.1","In-Reply-To":"<1505891589-6632-1-git-send-email-arvind.yadav.cs@gmail.com>","References":"<1505891589-6632-1-git-send-email-arvind.yadav.cs@gmail.com>","Sender":"linux-gpio-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"},"content":"devm_kasprintf() can fail here and we must check its return value.\n\nSigned-off-by: Arvind Yadav \n---\n drivers/gpio/gpio-tb10x.c | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/drivers/gpio/gpio-tb10x.c b/drivers/gpio/gpio-tb10x.c\nindex 091ffaa..ac6f2a9 100644\n--- a/drivers/gpio/gpio-tb10x.c\n+++ b/drivers/gpio/gpio-tb10x.c\n@@ -193,6 +193,9 @@ static int tb10x_gpio_probe(struct platform_device *pdev)\n \n \ttb10x_gpio->gc.label\t\t=\n \t\tdevm_kasprintf(&pdev->dev, GFP_KERNEL, \"%pOF\", pdev->dev.of_node);\n+\tif (!tb10x_gpio->gc.label)\n+\t\treturn -ENOMEM;\n+\n \ttb10x_gpio->gc.parent\t\t= &pdev->dev;\n \ttb10x_gpio->gc.owner\t\t= THIS_MODULE;\n \ttb10x_gpio->gc.direction_input\t= tb10x_gpio_direction_in;\n","prefixes":["2/2"]}