{"id":815918,"url":"http://patchwork.ozlabs.org/api/patches/815918/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/patch/20170919220125.32535-32-blp@ovn.org/","project":{"id":47,"url":"http://patchwork.ozlabs.org/api/projects/47/?format=json","name":"Open vSwitch","link_name":"openvswitch","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"git@github.com:openvswitch/ovs.git","webscm_url":"https://github.com/openvswitch/ovs","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170919220125.32535-32-blp@ovn.org>","list_archive_url":null,"date":"2017-09-19T22:01:04","name":"[ovs-dev,RFC,31/52] ovsdb-idl: Document state machine.","commit_ref":null,"pull_url":null,"state":"rfc","archived":false,"hash":"1654342e89d1d9056c6bfd5e86a82d617c42dbcf","submitter":{"id":67603,"url":"http://patchwork.ozlabs.org/api/people/67603/?format=json","name":"Ben Pfaff","email":"blp@ovn.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/openvswitch/patch/20170919220125.32535-32-blp@ovn.org/mbox/","series":[{"id":3975,"url":"http://patchwork.ozlabs.org/api/series/3975/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/list/?series=3975","date":"2017-09-19T22:00:34","name":"clustering implementation","version":1,"mbox":"http://patchwork.ozlabs.org/series/3975/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/815918/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/815918/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxd6X0B0pz9sNV\n\tfor ;\n\tWed, 20 Sep 2017 08:37:24 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 195FADFE;\n\tTue, 19 Sep 2017 22:25:18 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 16A62DE7\n\tfor ; Tue, 19 Sep 2017 22:25:17 +0000 (UTC)","from slow1-d.mail.gandi.net (slow1-d.mail.gandi.net\n\t[217.70.178.86])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTP id 8851C159\n\tfor ; Tue, 19 Sep 2017 22:25:16 +0000 (UTC)","from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby slow1-d.mail.gandi.net (Postfix) with ESMTP id D0010534ECB\n\tfor ; Wed, 20 Sep 2017 00:02:21 +0200 (CEST)","from sigabrt.benpfaff.org (unknown [208.91.2.3])\n\t(Authenticated sender: blp@ovn.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 30386172094;\n\tWed, 20 Sep 2017 00:02:19 +0200 (CEST)"],"X-Greylist":"from auto-whitelisted by SQLgrey-1.7.6","X-Originating-IP":"208.91.2.3","From":"Ben Pfaff ","To":"dev@openvswitch.org","Date":"Tue, 19 Sep 2017 15:01:04 -0700","Message-Id":"<20170919220125.32535-32-blp@ovn.org>","X-Mailer":"git-send-email 2.10.2","In-Reply-To":"<20170919220125.32535-1-blp@ovn.org>","References":"<20170919220125.32535-1-blp@ovn.org>","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"Ben Pfaff ","Subject":"[ovs-dev] [PATCH RFC 31/52] ovsdb-idl: Document state machine.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"},"content":"Signed-off-by: Ben Pfaff \n---\n lib/ovsdb-idl.c | 33 +++++++++++++++++++++++++++++++--\n 1 file changed, 31 insertions(+), 2 deletions(-)","diff":"diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c\nindex 62a6c3898227..d71188ab3c7c 100644\n--- a/lib/ovsdb-idl.c\n+++ b/lib/ovsdb-idl.c\n@@ -79,12 +79,41 @@ struct ovsdb_idl_arc {\n struct ovsdb_idl_row *dst; /* Destination row. */\n };\n \n+/* Connection state machine.\n+ *\n+ * When a JSON-RPC session connects, the IDL sends a \"get_schema\" request and\n+ * transitions to IDL_S_SCHEMA_REQUESTED. If the session drops and reconnects,\n+ * the IDL starts over again in the same way. */\n enum ovsdb_idl_state {\n+ /* Waits for \"get_schema\" reply, then sends a \"monitor_cond\" request whose\n+ * details are informed by the schema and transitions to\n+ * IDL_S_MONITOR_COND_REQUESTED. */\n IDL_S_SCHEMA_REQUESTED,\n- IDL_S_MONITOR_REQUESTED,\n- IDL_S_MONITORING,\n+\n+ /* Waits for \"monitor_cond\" reply:\n+ *\n+ * - If the reply indicates success, replaces the IDL contents by the\n+ * data carried in the reply and transitions to IDL_S_MONITORING_COND.\n+ *\n+ * - If the reply indicates failure because the database is too old to\n+ * support monitor_cond, sends a \"monitor\" request and transitions to\n+ * IDl_S_MONITOR_REQUESTED. */\n IDL_S_MONITOR_COND_REQUESTED,\n+\n+ /* Waits for \"monitor\" reply, then replaces the IDL contents by the data\n+ * carried in the reply and transitions to IDL_S_MONITORING. */\n+ IDL_S_MONITOR_REQUESTED,\n+\n+ /* Terminal states that process \"update2\" (IDL_S_MONITORING_COND) or\n+ * \"update\" (IDL_S_MONITORING) notifications. */\n IDL_S_MONITORING_COND,\n+ IDL_S_MONITORING,\n+\n+ /* Terminal error state that indicates that nothing useful can be done.\n+ * The most likely reason is that the database server doesn't actually have\n+ * the desired database. We maintain the session with the database server\n+ * anyway. If it starts serving the database that we want, then it will\n+ * kill the session and we will automatically reconnect and try again. */\n IDL_S_NO_SCHEMA\n };\n \n","prefixes":["ovs-dev","RFC","31/52"]}