{"id":815884,"url":"http://patchwork.ozlabs.org/api/patches/815884/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/patch/20170919220125.32535-18-blp@ovn.org/","project":{"id":47,"url":"http://patchwork.ozlabs.org/api/projects/47/?format=json","name":"Open vSwitch","link_name":"openvswitch","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"git@github.com:openvswitch/ovs.git","webscm_url":"https://github.com/openvswitch/ovs","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170919220125.32535-18-blp@ovn.org>","list_archive_url":null,"date":"2017-09-19T22:00:50","name":"[ovs-dev,RFC,17/52] ovsdb-data: Add OVS_WARN_UNUSED_RESULT annotations to function definitions.","commit_ref":null,"pull_url":null,"state":"rfc","archived":false,"hash":"ae5be7ca8e5655d52c9bc335c7b0393751f96161","submitter":{"id":67603,"url":"http://patchwork.ozlabs.org/api/people/67603/?format=json","name":"Ben Pfaff","email":"blp@ovn.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/openvswitch/patch/20170919220125.32535-18-blp@ovn.org/mbox/","series":[{"id":3975,"url":"http://patchwork.ozlabs.org/api/series/3975/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/list/?series=3975","date":"2017-09-19T22:00:34","name":"clustering implementation","version":1,"mbox":"http://patchwork.ozlabs.org/series/3975/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/815884/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/815884/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxcZr0F7Jz9sMN\n\tfor ;\n\tWed, 20 Sep 2017 08:13:24 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 1C66CCC8;\n\tTue, 19 Sep 2017 22:02:06 +0000 (UTC)","from smtp2.linuxfoundation.org (smtp2.linux-foundation.org\n\t[172.17.192.36])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 59BC3CAF\n\tfor ; Tue, 19 Sep 2017 22:02:01 +0000 (UTC)","from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby smtp2.linuxfoundation.org (Postfix) with ESMTPS id ECEFA1DD11\n\tfor ; Tue, 19 Sep 2017 22:02:00 +0000 (UTC)","from sigabrt.benpfaff.org (unknown [208.91.2.3])\n\t(Authenticated sender: blp@ovn.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id A4F4817209B;\n\tWed, 20 Sep 2017 00:01:58 +0200 (CEST)"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-Originating-IP":"208.91.2.3","From":"Ben Pfaff ","To":"dev@openvswitch.org","Date":"Tue, 19 Sep 2017 15:00:50 -0700","Message-Id":"<20170919220125.32535-18-blp@ovn.org>","X-Mailer":"git-send-email 2.10.2","In-Reply-To":"<20170919220125.32535-1-blp@ovn.org>","References":"<20170919220125.32535-1-blp@ovn.org>","X-Spam-Status":"No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW\n\tautolearn=ham version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp2.linux-foundation.org","Cc":"Ben Pfaff ","Subject":"[ovs-dev] [PATCH RFC 17/52] ovsdb-data: Add OVS_WARN_UNUSED_RESULT\n\tannotations to function definitions.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"},"content":"The function prototypes in ovsdb-data.h already have these, but it seems\nmore complete to have the annotation on the definitions too.\n\nSigned-off-by: Ben Pfaff \n---\n lib/ovsdb-data.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/lib/ovsdb-data.c b/lib/ovsdb-data.c\nindex af386b3ce480..3ddf5f5bd539 100644\n--- a/lib/ovsdb-data.c\n+++ b/lib/ovsdb-data.c\n@@ -1302,7 +1302,7 @@ ovsdb_datum_from_json__(struct ovsdb_datum *datum,\n * If 'symtab' is nonnull, then named UUIDs in 'symtab' are accepted. Refer to\n * RFC 7047 for information about this, and for the syntax that this function\n * accepts. */\n-struct ovsdb_error *\n+struct ovsdb_error * OVS_WARN_UNUSED_RESULT\n ovsdb_datum_from_json(struct ovsdb_datum *datum,\n const struct ovsdb_type *type,\n const struct json *json,\n@@ -1328,7 +1328,7 @@ ovsdb_datum_from_json(struct ovsdb_datum *datum,\n *\n * The datum generated should be used then discard. It is not suitable\n * for storing into IDL because of the possible member size violation. */\n-struct ovsdb_error *\n+struct ovsdb_error * OVS_WARN_UNUSED_RESULT\n ovsdb_transient_datum_from_json(struct ovsdb_datum *datum,\n const struct ovsdb_type *type,\n const struct json *json)\n","prefixes":["ovs-dev","RFC","17/52"]}