{"id":815863,"url":"http://patchwork.ozlabs.org/api/patches/815863/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/patch/20170919220125.32535-2-blp@ovn.org/","project":{"id":47,"url":"http://patchwork.ozlabs.org/api/projects/47/?format=json","name":"Open vSwitch","link_name":"openvswitch","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"git@github.com:openvswitch/ovs.git","webscm_url":"https://github.com/openvswitch/ovs","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170919220125.32535-2-blp@ovn.org>","list_archive_url":null,"date":"2017-09-19T22:00:34","name":"[ovs-dev,RFC,01/52] replication: Avoid theoretical use-after-free error in reset_database().","commit_ref":null,"pull_url":null,"state":"rfc","archived":false,"hash":"47b11bfb470bdb102caf810ea471894aae478a52","submitter":{"id":67603,"url":"http://patchwork.ozlabs.org/api/people/67603/?format=json","name":"Ben Pfaff","email":"blp@ovn.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/openvswitch/patch/20170919220125.32535-2-blp@ovn.org/mbox/","series":[{"id":3975,"url":"http://patchwork.ozlabs.org/api/series/3975/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/list/?series=3975","date":"2017-09-19T22:00:34","name":"clustering implementation","version":1,"mbox":"http://patchwork.ozlabs.org/series/3975/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/815863/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/815863/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxcKL5716z9sBW\n\tfor ;\n\tWed, 20 Sep 2017 08:01:40 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 3A8DCB1F;\n\tTue, 19 Sep 2017 22:01:38 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 54C24A64\n\tfor ; Tue, 19 Sep 2017 22:01:36 +0000 (UTC)","from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id BFADE432\n\tfor ; Tue, 19 Sep 2017 22:01:35 +0000 (UTC)","from sigabrt.benpfaff.org (unknown [208.91.2.3])\n\t(Authenticated sender: blp@ovn.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id CD06D172097;\n\tWed, 20 Sep 2017 00:01:33 +0200 (CEST)"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-Originating-IP":"208.91.2.3","From":"Ben Pfaff ","To":"dev@openvswitch.org","Date":"Tue, 19 Sep 2017 15:00:34 -0700","Message-Id":"<20170919220125.32535-2-blp@ovn.org>","X-Mailer":"git-send-email 2.10.2","In-Reply-To":"<20170919220125.32535-1-blp@ovn.org>","References":"<20170919220125.32535-1-blp@ovn.org>","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"Ben Pfaff ","Subject":"[ovs-dev] [PATCH RFC 01/52] replication: Avoid theoretical\n\tuse-after-free error in reset_database().","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"},"content":"Code that calls ovsdb_txn_row_delete() should avoid referencing the\ndeleted row again, because it might be freed. In practice this shouldn't\nreally happen in this case because of the particular circumstances, but it\ncosts little to be careful.\n\nSigned-off-by: Ben Pfaff \n---\n ovsdb/replication.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/ovsdb/replication.c b/ovsdb/replication.c\nindex 304212d9d93a..47b0af19bbf6 100644\n--- a/ovsdb/replication.c\n+++ b/ovsdb/replication.c\n@@ -529,8 +529,8 @@ reset_database(struct ovsdb *db)\n /* Delete all rows if the table is not blacklisted. */\n if (!blacklist_tables_find(db->schema->name, table_node->name)) {\n struct ovsdb_table *table = table_node->data;\n- struct ovsdb_row *row;\n- HMAP_FOR_EACH (row, hmap_node, &table->rows) {\n+ struct ovsdb_row *row, *next;\n+ HMAP_FOR_EACH_SAFE (row, next, hmap_node, &table->rows) {\n ovsdb_txn_row_delete(txn, row);\n }\n }\n","prefixes":["ovs-dev","RFC","01/52"]}