{"id":815799,"url":"http://patchwork.ozlabs.org/api/patches/815799/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/patch/1505849344-52387-8-git-send-email-bhanuprakash.bodireddy@intel.com/","project":{"id":47,"url":"http://patchwork.ozlabs.org/api/projects/47/?format=json","name":"Open vSwitch","link_name":"openvswitch","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"git@github.com:openvswitch/ovs.git","webscm_url":"https://github.com/openvswitch/ovs","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1505849344-52387-8-git-send-email-bhanuprakash.bodireddy@intel.com>","list_archive_url":null,"date":"2017-09-19T19:29:01","name":"[ovs-dev,07/10] odp-execute: Use const qualifer for batch size.","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"4cb7cca6d26ca2a025e090aa168f79ed07e34f0e","submitter":{"id":68557,"url":"http://patchwork.ozlabs.org/api/people/68557/?format=json","name":"Bodireddy, Bhanuprakash","email":"bhanuprakash.bodireddy@intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/openvswitch/patch/1505849344-52387-8-git-send-email-bhanuprakash.bodireddy@intel.com/mbox/","series":[{"id":3956,"url":"http://patchwork.ozlabs.org/api/series/3956/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/list/?series=3956","date":"2017-09-19T19:28:54","name":"Use DP_PACKET_BATCH_FOR_EACH macro.","version":1,"mbox":"http://patchwork.ozlabs.org/series/3956/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/815799/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/815799/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxYFH1SLpz9rxm\n\tfor ;\n\tWed, 20 Sep 2017 05:42:59 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id E0142A80;\n\tTue, 19 Sep 2017 19:38:52 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id E2546B9E\n\tfor ; Tue, 19 Sep 2017 19:38:48 +0000 (UTC)","from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id B25544C4\n\tfor ; Tue, 19 Sep 2017 19:38:48 +0000 (UTC)","from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga105.fm.intel.com with ESMTP; 19 Sep 2017 12:38:48 -0700","from silpixa00393942.ir.intel.com (HELO\n\tsilpixa00393942.ger.corp.intel.com) ([10.237.223.42])\n\tby orsmga001.jf.intel.com with ESMTP; 19 Sep 2017 12:38:47 -0700"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos; i=\"5.42,418,1500966000\"; d=\"scan'208\";\n\ta=\"1173892374\"","From":"Bhanuprakash Bodireddy ","To":"dev@openvswitch.org","Date":"Tue, 19 Sep 2017 20:29:01 +0100","Message-Id":"<1505849344-52387-8-git-send-email-bhanuprakash.bodireddy@intel.com>","X-Mailer":"git-send-email 2.4.11","In-Reply-To":"<1505849344-52387-1-git-send-email-bhanuprakash.bodireddy@intel.com>","References":"<1505849344-52387-1-git-send-email-bhanuprakash.bodireddy@intel.com>","X-Spam-Status":"No, score=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED,\n\tRP_MATCHES_RCVD autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"[ovs-dev] [PATCH 07/10] odp-execute: Use const qualifer for batch\n\tsize.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"},"content":"It is recommended to use const qualifer for 'num' that tracks the\npacket batch count. This way 'num' can't be modified by iterator.\n\nSigned-off-by: Bhanuprakash Bodireddy \n---\n lib/odp-execute.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/lib/odp-execute.c b/lib/odp-execute.c\nindex 5f4d23a..3109f39 100644\n--- a/lib/odp-execute.c\n+++ b/lib/odp-execute.c\n@@ -826,7 +826,8 @@ odp_execute_actions(void *dp, struct dp_packet_batch *batch, bool steal,\n break;\n }\n case OVS_ACTION_ATTR_DECAP_NSH: {\n- size_t i, num = batch->count;\n+ size_t i;\n+ const size_t num = dp_packet_batch_size(batch);\n \n DP_PACKET_BATCH_REFILL_FOR_EACH (i, num, packet, batch) {\n if (decap_nsh(packet)) {\n","prefixes":["ovs-dev","07/10"]}