{"id":815770,"url":"http://patchwork.ozlabs.org/api/patches/815770/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170919182745.90280-3-pasic@linux.vnet.ibm.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170919182745.90280-3-pasic@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-09-19T18:27:42","name":"[v3,2/5] s390x/css: use ccw data stream","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"7d14805706ceb84eacb0aa873a4821d9befeda37","submitter":{"id":68297,"url":"http://patchwork.ozlabs.org/api/people/68297/?format=json","name":"Halil Pasic","email":"pasic@linux.vnet.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170919182745.90280-3-pasic@linux.vnet.ibm.com/mbox/","series":[{"id":3944,"url":"http://patchwork.ozlabs.org/api/series/3944/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3944","date":"2017-09-19T18:27:40","name":"add CCW indirect data access support","version":3,"mbox":"http://patchwork.ozlabs.org/series/3944/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/815770/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/815770/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxWbZ29MYz9sBZ\n\tfor ;\n\tWed, 20 Sep 2017 04:28:42 +1000 (AEST)","from localhost ([::1]:44765 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duNGC-0003oh-B7\n\tfor incoming@patchwork.ozlabs.org; Tue, 19 Sep 2017 14:28:40 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:53029)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duNFX-0003n3-3n\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 14:28:00 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duNFS-0002EN-6V\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 14:27:59 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5]:58756\n\thelo=mx0a-001b2d01.pphosted.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1duNFS-0002DS-1u\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 14:27:54 -0400","from pps.filterd (m0098417.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8JIOGs3129129\n\tfor ; Tue, 19 Sep 2017 14:27:53 -0400","from e06smtp15.uk.ibm.com (e06smtp15.uk.ibm.com [195.75.94.111])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d35e8bqyk-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Tue, 19 Sep 2017 14:27:53 -0400","from localhost\n\tby e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tTue, 19 Sep 2017 19:27:51 +0100","from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197)\n\tby e06smtp15.uk.ibm.com (192.168.101.145) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tTue, 19 Sep 2017 19:27:50 +0100","from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60])\n\tby b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8JIRnaO11599994; Tue, 19 Sep 2017 18:27:49 GMT","from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 0913242041;\n\tTue, 19 Sep 2017 19:24:02 +0100 (BST)","from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id CE0574203F;\n\tTue, 19 Sep 2017 19:24:01 +0100 (BST)","from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9])\n\tby d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTPS;\n\tTue, 19 Sep 2017 19:24:01 +0100 (BST)"],"From":"Halil Pasic ","To":"Cornelia Huck ","Date":"Tue, 19 Sep 2017 20:27:42 +0200","X-Mailer":"git-send-email 2.13.5","In-Reply-To":"<20170919182745.90280-1-pasic@linux.vnet.ibm.com>","References":"<20170919182745.90280-1-pasic@linux.vnet.ibm.com>","X-TM-AS-GCONF":"00","x-cbid":"17091918-0020-0000-0000-000003B97365","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17091918-0021-0000-0000-0000424B22C3","Message-Id":"<20170919182745.90280-3-pasic@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-19_08:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709190256","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.158.5","Subject":"[Qemu-devel] [PATCH v3 2/5] s390x/css: use ccw data stream","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Dong Jia Shi ,\n\tHalil Pasic ,\n\tPierre Morel , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"Replace direct access which implicitly assumes no IDA\nor MIDA with the new ccw data stream interface which should\ncope with these transparently in the future.\n\nSigned-off-by: Halil Pasic \nReviewed-by: Dong Jia Shi \nReviewed-by: Pierre Morel\n---\n hw/s390x/css.c | 9 +++++----\n 1 file changed, 5 insertions(+), 4 deletions(-)","diff":"diff --git a/hw/s390x/css.c b/hw/s390x/css.c\nindex e8d2016563..6b0cd8861b 100644\n--- a/hw/s390x/css.c\n+++ b/hw/s390x/css.c\n@@ -890,6 +890,7 @@ static int css_interpret_ccw(SubchDev *sch, hwaddr ccw_addr,\n }\n \n /* Look at the command. */\n+ ccw_dstream_init(&sch->cds, &ccw, &(sch->orb));\n switch (ccw.cmd_code) {\n case CCW_CMD_NOOP:\n /* Nothing to do. */\n@@ -903,8 +904,8 @@ static int css_interpret_ccw(SubchDev *sch, hwaddr ccw_addr,\n }\n }\n len = MIN(ccw.count, sizeof(sch->sense_data));\n- cpu_physical_memory_write(ccw.cda, sch->sense_data, len);\n- sch->curr_status.scsw.count = ccw.count - len;\n+ ccw_dstream_write_buf(&sch->cds, sch->sense_data, len);\n+ sch->curr_status.scsw.count = ccw_dstream_residual_count(&sch->cds);\n memset(sch->sense_data, 0, sizeof(sch->sense_data));\n ret = 0;\n break;\n@@ -930,8 +931,8 @@ static int css_interpret_ccw(SubchDev *sch, hwaddr ccw_addr,\n } else {\n sense_id.reserved = 0;\n }\n- cpu_physical_memory_write(ccw.cda, &sense_id, len);\n- sch->curr_status.scsw.count = ccw.count - len;\n+ ccw_dstream_write_buf(&sch->cds, &sense_id, len);\n+ sch->curr_status.scsw.count = ccw_dstream_residual_count(&sch->cds);\n ret = 0;\n break;\n }\n","prefixes":["v3","2/5"]}