{"id":815725,"url":"http://patchwork.ozlabs.org/api/patches/815725/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170919165226.23022-18-marcandre.lureau@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170919165226.23022-18-marcandre.lureau@redhat.com>","list_archive_url":null,"date":"2017-09-19T16:52:16","name":"[v2,17/27] vhost-user-scsi: remove VUS_MAX_LUNS","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"09541e7715d0419a3aac879e2d605ff858044a42","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170919165226.23022-18-marcandre.lureau@redhat.com/mbox/","series":[{"id":3931,"url":"http://patchwork.ozlabs.org/api/series/3931/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3931","date":"2017-09-19T16:51:59","name":"vhost-user-scsi: code clean-up","version":2,"mbox":"http://patchwork.ozlabs.org/series/3931/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/815725/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/815725/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=marcandre.lureau@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxVKz5YZLz9rvt\n\tfor ;\n\tWed, 20 Sep 2017 03:31:51 +1000 (AEST)","from localhost ([::1]:44296 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duMNB-0005Kr-R7\n\tfor incoming@patchwork.ozlabs.org; Tue, 19 Sep 2017 13:31:49 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:47183)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duLmf-0006Dc-5U\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 12:54:06 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duLme-0002W7-8S\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 12:54:05 -0400","from mx1.redhat.com ([209.132.183.28]:33974)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1duLme-0002Vc-22\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 12:54:04 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 03223883BF;\n\tTue, 19 Sep 2017 16:54:03 +0000 (UTC)","from localhost (ovpn-112-56.ams2.redhat.com [10.36.112.56])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 586685D6A4;\n\tTue, 19 Sep 2017 16:54:01 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 03223883BF","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","To":"qemu-devel@nongnu.org","Date":"Tue, 19 Sep 2017 18:52:16 +0200","Message-Id":"<20170919165226.23022-18-marcandre.lureau@redhat.com>","In-Reply-To":"<20170919165226.23022-1-marcandre.lureau@redhat.com>","References":"<20170919165226.23022-1-marcandre.lureau@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tTue, 19 Sep 2017 16:54:03 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v2 17/27] vhost-user-scsi: remove VUS_MAX_LUNS","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pbonzini@redhat.com, felipe@nutanix.com, changpeng.liu@intel.com,\n\t=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\tf4bug@amsat.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"There is no code to support more than 1 yet, no need for that today.\n\nSigned-off-by: Marc-André Lureau \nReviewed-by: Philippe Mathieu-Daudé \n---\n contrib/vhost-user-scsi/vhost-user-scsi.c | 8 +++-----\n 1 file changed, 3 insertions(+), 5 deletions(-)","diff":"diff --git a/contrib/vhost-user-scsi/vhost-user-scsi.c b/contrib/vhost-user-scsi/vhost-user-scsi.c\nindex 38fe451619..6b55cc71d3 100644\n--- a/contrib/vhost-user-scsi/vhost-user-scsi.c\n+++ b/contrib/vhost-user-scsi/vhost-user-scsi.c\n@@ -53,8 +53,6 @@\n \n /** vhost-user-scsi specific definitions **/\n \n- /* Only 1 LUN and device supported today */\n-#define VUS_MAX_LUNS 1\n #define VUS_ISCSI_INITIATOR \"iqn.2016-11.com.nutanix:vhost-user-scsi\"\n \n typedef struct iscsi_lun {\n@@ -67,7 +65,7 @@ typedef struct vhost_scsi_dev {\n int server_sock;\n GMainLoop *loop;\n GTree *fdmap; /* fd -> gsource context id */\n- iscsi_lun_t luns[VUS_MAX_LUNS];\n+ iscsi_lun_t lun;\n } vhost_scsi_dev_t;\n \n /** glib event loop integration for libvhost-user and misc callbacks **/\n@@ -535,7 +533,7 @@ static void vus_proc_req(VuDev *vu_dev, int idx)\n }\n rsp = (VirtIOSCSICmdResp *)elem->in_sg[0].iov_base;\n \n- if (handle_cmd_sync(vdev_scsi->luns[0].iscsi_ctx,\n+ if (handle_cmd_sync(vdev_scsi->lun.iscsi_ctx,\n req, &elem->out_sg[1], elem->out_num - 1,\n rsp, &elem->in_sg[1], elem->in_num - 1) != 0) {\n vus_panic_cb(vu_dev, NULL);\n@@ -720,7 +718,7 @@ int main(int argc, char **argv)\n }\n vdev_scsi = vdev_scsi_new(sock);\n \n- if (iscsi_add_lun(&vdev_scsi->luns[0], iscsi_uri) != 0) {\n+ if (iscsi_add_lun(&vdev_scsi->lun, iscsi_uri) != 0) {\n goto err;\n }\n \n","prefixes":["v2","17/27"]}