{"id":815717,"url":"http://patchwork.ozlabs.org/api/patches/815717/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/1505841979-26365-5-git-send-email-Michal.Kalderon@cavium.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1505841979-26365-5-git-send-email-Michal.Kalderon@cavium.com>","list_archive_url":null,"date":"2017-09-19T17:26:19","name":"[net-next,4/4] qed: iWARP - Add check for errors on a SYN packet","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":true,"hash":"c754c7c72e1fb9cab79ee75ec11ee5d2af100076","submitter":{"id":69904,"url":"http://patchwork.ozlabs.org/api/people/69904/?format=json","name":"Michal Kalderon","email":"Michal.Kalderon@cavium.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1505841979-26365-5-git-send-email-Michal.Kalderon@cavium.com/mbox/","series":[{"id":3932,"url":"http://patchwork.ozlabs.org/api/series/3932/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=3932","date":"2017-09-19T17:26:15","name":"qed: iWARP fixes and enhancements","version":1,"mbox":"http://patchwork.ozlabs.org/series/3932/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/815717/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/815717/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=CAVIUMNETWORKS.onmicrosoft.com\n\theader.i=@CAVIUMNETWORKS.onmicrosoft.com header.b=\"IevIuC5G\"; \n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxVFF3Jprz9rvt\n\tfor ;\n\tWed, 20 Sep 2017 03:27:45 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751523AbdISR1n (ORCPT );\n\tTue, 19 Sep 2017 13:27:43 -0400","from mail-by2nam01on0051.outbound.protection.outlook.com\n\t([104.47.34.51]:32800\n\t\"EHLO NAM01-BY2-obe.outbound.protection.outlook.com\"\n\trhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S1751471AbdISR1j (ORCPT );\n\tTue, 19 Sep 2017 13:27:39 -0400","from SN1PR0701CA0018.namprd07.prod.outlook.com (10.162.96.28) by\n\tBLUPR0701MB2084.namprd07.prod.outlook.com (10.163.122.154) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.11;\n\tTue, 19 Sep 2017 17:27:37 +0000","from BL2FFO11FD050.protection.gbl (2a01:111:f400:7c09::109) by\n\tSN1PR0701CA0018.outlook.office365.com (2a01:111:e400:5173::28) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n\t15.20.56.9 via Frontend Transport; Tue, 19 Sep 2017 17:27:37 +0000","from CAEXCH02.caveonetworks.com (50.232.66.26) by\n\tBL2FFO11FD050.mail.protection.outlook.com (10.173.161.212) with\n\tMicrosoft SMTP Server (version=TLS1_0,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384)\n\tid 15.20.35.14 via Frontend Transport; Tue, 19 Sep 2017 17:27:36 +0000","from lb-tlvb-michal.il.qlogic.com.com (10.185.6.89) by\n\tCAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id\n\t14.2.347.0; Tue, 19 Sep 2017 10:27:34 -0700"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=KDWYj8khDIUkOO4tVSQRh3ZSSdfURIsgvPS2SxG1MS4=;\n\tb=IevIuC5GWnX9D2s3wXQL4CkLc/69tPqoH3SGwLTFw0WQV3cnPbBH4ExiRU9HCgX0aQhTU45OUV04iJJoYIcmdUDDBq6WQxBhmV5Os+R2k7ze9erwFGcifyeFrfID50pNX4NC6jtj2DCkPCGdbZTk7mA8dJvJL+vggiHzPzfZs8Q=","Received-SPF":"None (protection.outlook.com: cavium.com does not designate\n\tpermitted sender hosts)","From":"Michal Kalderon ","To":", ","CC":", ,\n\tMichal Kalderon ,\n\tAriel Elior ","Subject":"[PATCH net-next 4/4] qed: iWARP - Add check for errors on a SYN\n\tpacket","Date":"Tue, 19 Sep 2017 20:26:19 +0300","Message-ID":"<1505841979-26365-5-git-send-email-Michal.Kalderon@cavium.com>","X-Mailer":"git-send-email 1.9.3","In-Reply-To":"<1505841979-26365-1-git-send-email-Michal.Kalderon@cavium.com>","References":"<1505841979-26365-1-git-send-email-Michal.Kalderon@cavium.com>","MIME-Version":"1.0","Content-Type":"text/plain","X-EOPAttributedMessage":"0","X-Forefront-Antispam-Report":"CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI;\n\tSFV:NSPM;\n\tSFS:(10009020)(6009001)(376002)(346002)(2980300002)(428002)(199003)(189002)(2906002)(48376002)(107886003)(16586007)(76176999)(5660300001)(356003)(105586002)(2950100002)(47776003)(50466002)(69596002)(104016004)(110136005)(72206003)(77096006)(4326008)(478600001)(305945005)(50986999)(36756003)(316002)(575784001)(81156014)(5003940100001)(86362001)(81166006)(8676002)(8936002)(50226002)(189998001)(6666003)(54906002)(101416001)(106466001);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB2084;\n\tH:CAEXCH02.caveonetworks.com; FPR:; SPF:None;\n\tPTR:50-232-66-26-static.hfc.comcastbusiness.net; A:1; MX:1;\n\tLANG:en; ","X-Microsoft-Exchange-Diagnostics":["1; BL2FFO11FD050;\n\t1:qjtN513MdeEUnBcCK4vv5iGO6iJ35ruvX+x04MNBaWbsyBnIcbCukCMdktMLkVls59LI4t2iE274/wYpehqltqMYGUV5Zidzje/XjSiodu6cDvetph9Op5pt4gbA5cEa","1; BLUPR0701MB2084;\n\t3:9goVWi7Kqp5xTFxM8c78IaibgYpdX/5l2w5PtF0K2YgdZ0d1qYKdxkcfWSPrxuc+fBiCBa5CGfM9NiaIbwWL9ZyH9KShJ5uAGEQzR15LYAR08di7w03A7fHy72DwqVcPwGDm5h1hC3VQL/l0+MhZePjyRkFAf5ofr1uFC9QI4hBElLjbHTtHM29d/h1XkwzoqSHKEvZk5m5XtIiaSDY5zwdPVx0dGyR4SepNa7XBzaXwRI2Mg5gTq4tLg1S1Siakfi39FiH3apj/1J/3Imh7odtzzPGU1Ido+qN0YZjupJ2Cmn5WV7O/q6XDOIlOWfnV0KLgeFd6tBViNJYcMK9FqMM33ZtDzY54GQszKilDEL4=;\n\t25:NPAqZzktEqGzthwzK1aOuAWYqhwo8gpbFgOEK2tWrykV/t+e7eTGrZkMhu0hFg6iZg786JnJRbp1aFzh3RFLlUTiqhpDCbDeAvbrjlNC0m7AOJ9zwh22KnuqDsEmI8XadLyfpqOjuKTE5NCKY5szxJf9vc7KkLEWwjDSGsbCFy5VP83jlxeUCSLvptKF4YQxIGlWrUTojH6vkls84ggDhqRTHVNSzR0MjU4+4Qlok8hdlhLtgzesEJVFGX80yZBDSaZj2EGUc33dVGI4LOT2WCfP0YVt9GTgdBL13FzPd2K5nftP3d+uVpD0JSFyZeVFlk8wr/8pAzeIA9GMeOIGdw==","1; BLUPR0701MB2084;\n\t31:BEouYwsQHs4yP0cfqsDqwYJ/vm4xSylnPWGr3mBb4WzOT1WyhwD+jdQ7Q/NBvnSCL3Fxfv7wxpJL8PJsG3f/GQCvauxWbSl+ZRDyQ7gMaRnSezI6IR0Wo4SNsxitOaGLuAyolrbBRoLPY6WvavybldHftnaNUhn+XLQrTH8OM1GsMI+LQ9QXi75fp4kVn0BUj43PpsiyPQlSEoDOqCDimUDrYlsBZpYR6dq/uXoHVeM=;\n\t20:ZTTqgrcFYYzWvA8hGwtSnZOBnnHJOCB5RrKCokuu9rZSE3Trg6AJYYJ9y1LC6G8f7d4IIn7xXoWvbDW3dJ+KT6bdP7rcO2e7ZnZI6ob12+msK4d1V8QYXQmhSkJMR0JW8w6M0r16tk7OD7ixo/F4A45mAVszBlwukA7XXUFZO49HqIzTf22ZIvUhHMIdMDgzq63HOykvKWeD5vyzMqVNKwqlmNHC8cteH5iqBJ7le1/CsCbRp+sOd7aJMyW+yTsAMkCtcZEHnAX18Aoi6D/FIZDWw9wVJNYW4SHKjpqiePTGu2exq1IT1hYBzZfccC+naoDQQOEL4K7OzzPsI0AtSGqOuEe/R02WQxp2RsMlfKvqY2FmrNQNotfn44gSxLy0GWLMlIB5Kvuu2NLcsGk4Hz5gZUKEjqIrFpulmjOmzvwZSbfK2eXeJEly5NC55xXsSqctZac/W9QqP2oeE1M7qkE6X4CgrjHN5v8Yo8TeMk+3KmAxshFeqnvEm2HTRanu","1; BLUPR0701MB2084;\n\t4:/8jFFRVMPy8bGiJhHR3FL+DEzs9yzNxMnceHGwgr6WEEUjyd3UWr/zBWqhgxdbwm/xJnLbImbjPvbw41fB/iyRTxBI6VCIPg4jw9msR1rAtk8Ft5Hu7Q42wihoE98QBMJQ5bJ5+Mi4ssmc7lJODXGOuA2vAFjA5wHTSkLvQJkZqCvlwbXMoPvyIRhEg3auu1MlX43tjovvw/ljDUQis+ZKPPgXPWOBD5ZrU4XYahy+YdWv2aSUl/k7IUFAc5oeMD","1; BLUPR0701MB2084;\n\t23:4ysc2UZKsMSxScyTeWMx/odWqhF8WkUrYeFJjTH4ohzaVIW/6y1NFLMitf+N4IIvJqacErAA8RbOV5D7diyCQVisZs3b9wt96u+TLuF9rvXfgQQbaANHB/h2Gyy1JDD78Wd5P5YMtdDJ5t0kE6NCMCuQ7LAO5at65233r/eneSwbKGISn1n0JqXUU2tvCVWsxAFyKDbNOZhCkvl/v+ajIrLrY0pLCvJcPLam9FaPGYd03v+AibkKOxMQrN+aeXe/6GanSBPbEeyJ0hfJgwKsN2IFm2nxALY0wfpiLjiwLyHaa5p6glS9N5W2WcuxUNVrM6+LsOSEbq4EAeyokXGPAh3Q0NxSUqK47xGZQw/oC1UgKcYKKilRvIdtNwt+S1NQRk/pYBQj0meNWs9YsDDCKX+eqrit+iSfn58L2TFZ3545F0c0fBzrXZ/RB5QZqDx1SQF4qRfc1mtDCm5fRnHlyhBOGZMXc5w+4qoFYUErHNY1nGeEkoAfIQ+LrCCL7sFx5Igg24auhzli+UHB4uEPddC5SvzcOBzauZR+oLEVpW30hZamaijGyDXSBKs2ZyH6BPF0Ys/Ol1mAI6Zqxkx9HmZqe5mec1omVR6AwqL29nyJb7JJltpPwsd8sp+CQ852C18H1UvM+zS11K5K3GhhDIfWRj3ownNfoicgLj0elZP0tScuzY3zmUjq8J1FNOW/sxQSBlu5S/5Fju2TJjN1RBCuWpHQ6VbgugQLabMxFzGNqix75Zue/RxThUUwBmWOPoHnFnmrzlwpGAgIYUPVvG+7AU+vZQT8TlCsyot3mPa+BYsEm6QbX354y4fLXEvnfc3UpJVrKZ5Z3ENf2+bM/pRx5a/9kVX2daWsRgvb1U4jYYllQvo6GgZ1TZpLJfV+55xxAZ9f1kCGXTlnj/AEkNr6mN3Ueomb+1Dshc91FGCjXLORQuKyEI+gX6purePjwyoRrRnSvqRJxqaKhlfSYAU+mES15KIrlfAqKNEJxs9u5piGyRlcpD12w/qSEsj6","1; BLUPR0701MB2084;\n\t6:N/uu2y1mzW/C6+R32n9eta4fMhLPm0hML2hqgVYiyapV7NApE8VszVvHz3OUisNlKaEaQmy5t4sbeCcuqXZL/qWpNCMBXcH9ZgV8GIfed7mKNfRJgHDVQF4S/zxfnBnXInB7vx6owcaB0TPVSL2edpvy7YuFHEOH3X95/LIpxY1Q4iX949zYdAUdPQ26JQZK/lVnKGI2k8a1HfAgCWg1sx0gmbehHiHI0CgSgwVDSXVkbWyP27wLwvwp+MUNteoDwEuAxtlAojZK0lRceBR3hd205yavjcV5gGJnkk6xn5mtj48wXaAQKGOpGOoAAR7R9CCyX6AUDqgIc5sMwlPZYg==;\n\t5:GvZua2i0raXtYeSOiCorJFI/eHuzLtEe0szL3g7K3q4diL9NMLcggWGcP5x6apnGLkU2s4becmaZ4enFHgwSeqzhRyxbo9bxRVXSPU83AbpZWN9ZGyaO20f86GOe4DD6W0QOnQLQ1x0VVSvRwMZTEQ==;\n\t24:bxTn3NAG6h2JL2VtmvrMm2WlxoXLCtsLlttTf9A71R4VGpRrJWm5mzf9kgFINSG80RaWmVocLEzGHYqDTfKjYhJGETx76rNJZ0nxSZb2zrc=;\n\t7:ZcRxcTGDASfvGjfbE6rqgsdQzofNK7KoWhtYsO1jzLKC2V8zoNAEVH/9yYL2RShQ1o3w/m668AGKD5dXiNC4BZncMqFpa8jZAdsG3cOdmZaN3fWv6fVhNcEyldtHQk0yNmbUxhzWLiqG6WyTyKCtsabcFUYYicYjH1YTlUiOB+eifK24SUnE5PMZoLU1EATKvMkBlkZg9Gn/IWIQes/6voOr1GZi9sbGJXqlt8AiwCQ="],"X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"3e364908-e382-41d4-85f6-08d4ff83b8d9","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:BLUPR0701MB2084; ","X-MS-TrafficTypeDiagnostic":"BLUPR0701MB2084:","X-Exchange-Antispam-Report-Test":"UriScan:;","X-Microsoft-Antispam-PRVS":"","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(6041248)(20161123564025)(20161123560025)(20161123555025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:BLUPR0701MB2084; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:BLUPR0701MB2084; ","X-Forefront-PRVS":"04359FAD81","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-OriginatorOrg":"cavium.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"19 Sep 2017 17:27:36.9557\n\t(UTC)","X-MS-Exchange-CrossTenant-Id":"711e4ccf-2e9b-4bcf-a551-4094005b6194","X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp":"TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194;\n\tIp=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com]","X-MS-Exchange-CrossTenant-FromEntityHeader":"HybridOnPrem","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"BLUPR0701MB2084","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"A SYN packet which arrives with errors from FW should be dropped.\nThis required adding an additional field to the ll2\nrx completion data.\n\nSigned-off-by: Michal Kalderon \nSigned-off-by: Ariel Elior \n---\n drivers/net/ethernet/qlogic/qed/qed_iwarp.c | 8 ++++++++\n drivers/net/ethernet/qlogic/qed/qed_ll2.c | 1 +\n include/linux/qed/qed_ll2_if.h | 1 +\n 3 files changed, 10 insertions(+)","diff":"diff --git a/drivers/net/ethernet/qlogic/qed/qed_iwarp.c b/drivers/net/ethernet/qlogic/qed/qed_iwarp.c\nindex 568e985..8fc9c811 100644\n--- a/drivers/net/ethernet/qlogic/qed/qed_iwarp.c\n+++ b/drivers/net/ethernet/qlogic/qed/qed_iwarp.c\n@@ -1733,6 +1733,14 @@ int qed_iwarp_reject(void *rdma_cxt, struct qed_iwarp_reject_in *iparams)\n \n \tmemset(&cm_info, 0, sizeof(cm_info));\n \tll2_syn_handle = p_hwfn->p_rdma_info->iwarp.ll2_syn_handle;\n+\n+\t/* Check if packet was received with errors... */\n+\tif (data->err_flags) {\n+\t\tDP_NOTICE(p_hwfn, \"Error received on SYN packet: 0x%x\\n\",\n+\t\t\t data->err_flags);\n+\t\tgoto err;\n+\t}\n+\n \tif (GET_FIELD(data->parse_flags,\n \t\t PARSING_AND_ERR_FLAGS_L4CHKSMWASCALCULATED) &&\n \t GET_FIELD(data->parse_flags, PARSING_AND_ERR_FLAGS_L4CHKSMERROR)) {\ndiff --git a/drivers/net/ethernet/qlogic/qed/qed_ll2.c b/drivers/net/ethernet/qlogic/qed/qed_ll2.c\nindex c06ad4f..250afa5 100644\n--- a/drivers/net/ethernet/qlogic/qed/qed_ll2.c\n+++ b/drivers/net/ethernet/qlogic/qed/qed_ll2.c\n@@ -413,6 +413,7 @@ static void qed_ll2_rxq_parse_reg(struct qed_hwfn *p_hwfn,\n \t\t\t\t struct qed_ll2_comp_rx_data *data)\n {\n \tdata->parse_flags = le16_to_cpu(p_cqe->rx_cqe_fp.parse_flags.flags);\n+\tdata->err_flags = le16_to_cpu(p_cqe->rx_cqe_fp.err_flags.flags);\n \tdata->length.packet_length =\n \t le16_to_cpu(p_cqe->rx_cqe_fp.packet_length);\n \tdata->vlan = le16_to_cpu(p_cqe->rx_cqe_fp.vlan);\ndiff --git a/include/linux/qed/qed_ll2_if.h b/include/linux/qed/qed_ll2_if.h\nindex dd7a3b8..89fa0bb 100644\n--- a/include/linux/qed/qed_ll2_if.h\n+++ b/include/linux/qed/qed_ll2_if.h\n@@ -101,6 +101,7 @@ struct qed_ll2_comp_rx_data {\n \tvoid *cookie;\n \tdma_addr_t rx_buf_addr;\n \tu16 parse_flags;\n+\tu16 err_flags;\n \tu16 vlan;\n \tbool b_last_packet;\n \tu8 connection_handle;\n","prefixes":["net-next","4/4"]}