{"id":815716,"url":"http://patchwork.ozlabs.org/api/patches/815716/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/1505841979-26365-4-git-send-email-Michal.Kalderon@cavium.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1505841979-26365-4-git-send-email-Michal.Kalderon@cavium.com>","list_archive_url":null,"date":"2017-09-19T17:26:18","name":"[net-next,3/4] qed: Fix maximum number of CQs for iWARP","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":true,"hash":"16cfd43433efe08bad89466b3408fd22de388016","submitter":{"id":69904,"url":"http://patchwork.ozlabs.org/api/people/69904/?format=json","name":"Michal Kalderon","email":"Michal.Kalderon@cavium.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1505841979-26365-4-git-send-email-Michal.Kalderon@cavium.com/mbox/","series":[{"id":3932,"url":"http://patchwork.ozlabs.org/api/series/3932/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=3932","date":"2017-09-19T17:26:15","name":"qed: iWARP fixes and enhancements","version":1,"mbox":"http://patchwork.ozlabs.org/series/3932/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/815716/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/815716/checks/","tags":{},"related":[],"headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=CAVIUMNETWORKS.onmicrosoft.com\n\theader.i=@CAVIUMNETWORKS.onmicrosoft.com header.b=\"jmUL+DzL\"; \n\tdkim-atps=neutral","spf=none (sender IP is 50.232.66.26)\n\tsmtp.mailfrom=cavium.com; vger.kernel.org;\n\tdkim=none (message not signed)\n\theader.d=none; vger.kernel.org;\n\tdmarc=none action=none header.from=cavium.com; "],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxVFB583Nz9rvt\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 20 Sep 2017 03:27:42 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751488AbdISR1h (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 19 Sep 2017 13:27:37 -0400","from mail-sn1nam01on0062.outbound.protection.outlook.com\n\t([104.47.32.62]:63168\n\t\"EHLO NAM01-SN1-obe.outbound.protection.outlook.com\"\n\trhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S1751471AbdISR1e (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tTue, 19 Sep 2017 13:27:34 -0400","from SN1PR0701CA0063.namprd07.prod.outlook.com (10.163.126.31) by\n\tBLUPR0701MB2083.namprd07.prod.outlook.com (10.163.122.153) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7;\n\tTue, 19 Sep 2017 17:27:32 +0000","from BL2FFO11OLC013.protection.gbl (2a01:111:f400:7c09::111) by\n\tSN1PR0701CA0063.outlook.office365.com (2a01:111:e400:52fd::31) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.9 via\n\tFrontend Transport; Tue, 19 Sep 2017 17:27:31 +0000","from CAEXCH02.caveonetworks.com (50.232.66.26) by\n\tBL2FFO11OLC013.mail.protection.outlook.com (10.173.160.161) with\n\tMicrosoft SMTP Server (version=TLS1_0,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384)\n\tid 15.20.35.14 via Frontend Transport; Tue, 19 Sep 2017 17:27:31 +0000","from lb-tlvb-michal.il.qlogic.com.com (10.185.6.89) by\n\tCAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id\n\t14.2.347.0; Tue, 19 Sep 2017 10:27:28 -0700"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=1njQ5fCLNCWauzvgm+SG/3Zdq2/zH+gzw04gM086odM=;\n\tb=jmUL+DzLjXuM1+S8tkCVmKslT7kRfMfffBg8AtXlHVijB2bj521I3mZ7kPXLJzkih2LhsWHh0igRtvxCdG2A6TDYq0BsNS6/2lQQHS33JbvYKxIHkWtDfrXTeIUurhlMQXRQHh7C9ybOLOIBvRgEWArFuMutRtqpB9NUtUJV5h4=","Received-SPF":"None (protection.outlook.com: cavium.com does not designate\n\tpermitted sender hosts)","From":"Michal Kalderon <Michal.Kalderon@cavium.com>","To":"<davem@davemloft.net>, <netdev@vger.kernel.org>","CC":"<linux-rdma@vger.kernel.org>, <dledford@redhat.com>,\n\tMichal Kalderon <Michal.Kalderon@cavium.com>,\n\tAriel Elior <Ariel.Elior@cavium.com>","Subject":"[PATCH net-next 3/4] qed: Fix maximum number of CQs for iWARP","Date":"Tue, 19 Sep 2017 20:26:18 +0300","Message-ID":"<1505841979-26365-4-git-send-email-Michal.Kalderon@cavium.com>","X-Mailer":"git-send-email 1.9.3","In-Reply-To":"<1505841979-26365-1-git-send-email-Michal.Kalderon@cavium.com>","References":"<1505841979-26365-1-git-send-email-Michal.Kalderon@cavium.com>","MIME-Version":"1.0","Content-Type":"text/plain","X-EOPAttributedMessage":"0","X-Forefront-Antispam-Report":"CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI;\n\tSFV:NSPM;\n\tSFS:(10009020)(6009001)(346002)(376002)(2980300002)(428002)(189002)(199003)(72206003)(5003940100001)(47776003)(478600001)(2906002)(107886003)(54906002)(5660300001)(16586007)(110136005)(36756003)(69596002)(356003)(77096006)(305945005)(4326008)(316002)(81166006)(8676002)(50226002)(101416001)(106466001)(105586002)(86362001)(81156014)(189998001)(2950100002)(50986999)(104016004)(6666003)(76176999)(8936002)(48376002)(50466002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB2083;\n\tH:CAEXCH02.caveonetworks.com; FPR:; SPF:None;\n\tPTR:50-232-66-26-static.hfc.comcastbusiness.net; MX:1; A:1;\n\tLANG:en; ","X-Microsoft-Exchange-Diagnostics":["1; BL2FFO11OLC013;\n\t1:5GNn7dg3YJvtkqKYRXErUB1g+dGAr/UNZvKsFDcNnSPZkJgCHbExFis0R3CMlkIW0Pat4DeQ9rfQO3qNld+di2jEEXcy0bndQeA0W+zyrG39lwFFzIiTT+8/HaxfQ1bG","1; BLUPR0701MB2083;\n\t3:wS3gI1WDnIDAm0B69yIAhQYcji2ouO2KxqfkzlBGgMM3LX/+c0Ui27u5biRG3Hp6Us39SXHwTRPtSgLuH2NL+DQeJt+2MipaCob3c7X5n/50qHYZtNMjoFluf+prdC0wN1fsPEPcFhGu5Xipx4X6trw7lqn6zQAOr84o9FtVBmU/bKVH2HNOp442bzJXaNOyNoGiowIGGD6jRRvH5XMhAd/APjLs3cSzexsDePXCGMuURl87IWnyULTd2R9+J1b4hciIL/mk6uh6C1lrNwUAFve8nqknobeTy42PvB49vApYL1ffmdFr6jaDDJuTNXxQ9v9q0+AYXfXvpa30Was8L/pds/g/vnBzszcgnfyom44=;\n\t25:Pb4qsBcEO6wVYdm5F6BpeJFncnFNEH7x8O6gdEcJ2xONP8Qd9AyL7HsXSNHJolqUA1JwEkRmDhrTw35eSHsMC42YihCTln08eGwvvRXfPzHL38l5JG0BpvRN2P9NJgtNqtricCD1JMijwMahm/tkjy1dR0+y7nCh4RUdbfZbD/YFgxtgOmt0/eBT3M78RYnxTLErfsiLP79n3ocY9UA+MBp6zgt61apQ8Oi2pjzDdOQIKJYWdx4Uyd7tVGi7r2lEhHWhFYpBgOi7fEYVJEf3uRwJBOSydfbbuPLVoPFj8kjRO2asP0EMY9eBEjz5/qWaCUsieJvSjDN540AjUl/HTA==","1; BLUPR0701MB2083;\n\t31:riPb8/4fIhjYIWpCskSX6nKlFO9XKNSLEUV2Q9OOBq35mcBcgMLTl7ZxFI04OWqLi8laS2aA9i2uoz4COf7903LqpaYeQt2f+VeNRrXBP75I8n4LJNRdnTilkmFZKIkTsWWyEYR0IhUBlbx3bsslG3VY7nVxs/2j2JNK0x0V4kUWTvOV//nQl/DVQapbx4Pl702slZmkYmDusfXClTAa2+OWnaDWhplC0DOtzWsuJZA=;\n\t20:4qdElm0yKoBPzr9gYC6ptKRzUud7KHaW3SOdm1AyxWuOXThYYCvQihY5N8xka3B9RIFUo6NM+38NCCft8DL+7KvcEIGRjrtbZdqq7YT4YZMFUfDxJArk7d/PG8Ux6vtEzIN47oasDIWgkUOGJdF0pEnBxh7uInb6eWtAZM90UdlzxsmgkWVIBV0adXQRnrMlrVz4sjLc5n7Hf4Nt4BPKozQiZe8ooeoBaqt+VwbK9e1ynkOS9ffaVd6A92mC5LnFqowI0l4k3LDzpTPaUjA7qRApkfSxnRaq1Y2FWNib92uu0hXPhxyOXxTlNBJhRbAK/cCUZmrG3UQyO2tIdWhRDqcp5DrYcPnA5aUsZ0NtTx8ClEDGYiLfLsGxW2wKRM1y8s5YuCJIjxIPCYl/JK92ztbLYHBBa2ii92xdGs7oN4BvtL1c6hm54EAIwUmaWqv8Tji9I7Dp9NHS1YMvDfvyuSDF6k+JzEEvEikkzdpucPf+HQOIeuwfzW3M1clOcHMl","1; BLUPR0701MB2083;\n\t4:Y8YZwaUxc4q2epbBw10lEt94AEy+lCUMXXhikNm2R01CBIECA7VtaaMGoHhogm03wCWVtNBu+v5NeYRHCLT+j+giXLff17tWFW2gCO/gsNowwbxhs+6plJDUbysRMFhyr3axIdJsS3C+JLWUsQwHvS/C0yawIjg4itqC4MRwys48e5JFFlNwisAuAt7g22Ja75yRajAWwd0x19VH+KNUMg3tiGf4n3eGBFXpK7shmMl0ilLByhsQP+ofgexdNKF4","1; BLUPR0701MB2083;\n\t23:e+2u6WlomqvEY45Ll+9q3wT7tn7asLCF3IUZraUfVDNLlFIVOqYGPJsAVl5ocDPhYkJLwdgcEm3+ySkOzaCOLz7QjsD+OHXn71mYgMbzBq3Azsuv1qV6i6n9fTxGN1sejRMflegfZVRLaVGzloUtdgtOSqFg5fC08XsTvTPgDC5JcnVkUVjWlNR8uBi+S6W/aiH3haWwn2VHvdTw8qthNZZQQPYvIhL7T8endP6U/hq378/HsvpZ3GJvFIo5+XkS8o6OJQDL+55p/kyr8Mc8uRJUq88Z1XgijllW4KoJtNDR/QANBXB5e7wrMkpwo8y3zd6UDacxr3Rbz1BoTXL1JEnYC5cRW2xx0w4R4sTdh9ozLPkIs6Vb69ZClHlSeZq9tShJ7MZt/Q00ah66XDQhbcclhpe5HA42JFTQD5N7TjfFV9R4fMRjrqddbi2St0Sff8Dh2zbOJ2a2o0f1Y6qwF5Q7MI5spcduN2yd4QO67utJCu7rgkW9It54IIY+bXjkPrydEkOqcMBG7t0CMfx93Z5G87cKdO40FfeAsP/w9/+eH8z8xksGqg73kqoc3o1q44AEcHk+xTIdS7UmS21PAefRYKp/cry+HO4vELrhFun2zrGrqJ4ANUiFPDopY0Zfa4zjwn86iAXfGpLYzicbjT15zJdLpIE0d2I0foa3+r+d4X6WJeVPOSN09Tx5+PfiNO0Ukpdni08tirpwC1UKPz+1Pk8REo7FIjD81LGtbwiSTUTHinzSbvttIIrCp+03AfHGaaqB3WFECSu/ValFTiGCnG0o9k089EN+WVKui+UwGsOJHxc8k48d7dC0JaGI5I/xpCaB1k1tkqU0Hndxp+J11pEv4n0aPwOEhAbxn2B1mGSdpSPM0LKM+1qH7wPfX5BZS8Jhnp8BkFcfra7daYKsmL379TeJC8RR4CGBWhVjDL/ZglX4X14jR165YAg/R/PJeh4q4gGkN1r7B192L050Ev+pnAbIg2yAoz4PXeI=","1; BLUPR0701MB2083;\n\t6:3E7xNhcfTKozAUCjaz0ZkXy8Pm4KSSJSQdVntR7EDHqZ+iZrxW0YZl2tp0+DroaCkHBkukfDxdQst7wezERx9IXwHnkk+iju/B/LDTxcepz8pGRqznjy4AAmQMDnEC6dY2yLn4b1poIM/KFgRc7YOX8tIHy+sh0SK/x6bUpLorRmIJe7aPn9SfNCSXWqn9BrG5d5uSinZq8BryBhYFHlM5iLuUPBXFFqa91j0934vsTY6GPUSzJDdKgCE9aTmquDy0Scjeyn9ZKM3tuPxloGq0q4u0bUJ8u4geuUJBaJ5QciC71+GvXg3Ivt3v0Y/NLMqnk0QgtqEFg9UIVbIo3bXw==;\n\t5:pXZf2DHIz1Cp7SYYZ8Cln9zkgC/bSxoyrJkYMQq4znFCecV9VzlWisNdqoXokAjOSyHlnSBv4R32CkvMoHQSpkb4xgbMgQWyqXyUibYlk5z8mENVuBru/PfT0Ev1HKyxo78u9V/o1vhtd61oRyfehg==;\n\t24:CPoWOR8WqWz3ag7Z+5vTBazyJryuL07rzb2hgyyT4JwE/1SsbXB6qpRzEUA/5aDDnNo/bS3+ysjLfFp+q4T/hZ/YW/r1zzUhck08Z1AMtqM=;\n\t7:HR9zkjvCmDncxUh04VxEruIL8SZv17K9VQqH/oefhNPZKVD2vFrwdMvq0G7/R/TodWpgxRdk+XOJmf7VTF0jV1sdrpsYmUjHTga4GasTtqSRR4ZSwlok8/DDn3/n3bafUeTgtdGkEBkd8gk2dsRgBOcfwPzV62WHfepAy1qdin0DBGXkzau1G7RK4JjiJX2WituqSFoqpUl6B54ca+ucPZvnOsPked5BwPCM1pj+Zww="],"X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"ce2d6388-1594-41cd-bb93-08d4ff83b5da","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:BLUPR0701MB2083; ","X-MS-TrafficTypeDiagnostic":"BLUPR0701MB2083:","X-Exchange-Antispam-Report-Test":"UriScan:;","X-Microsoft-Antispam-PRVS":"<BLUPR0701MB20835A7987A9B4BC36F8F08788600@BLUPR0701MB2083.namprd07.prod.outlook.com>","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(93006095)(93001095)(3002001)(10201501046)(6041248)(20161123560025)(20161123555025)(20161123564025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:BLUPR0701MB2083; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:BLUPR0701MB2083; ","X-Forefront-PRVS":"04359FAD81","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-OriginatorOrg":"cavium.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"19 Sep 2017 17:27:31.9148\n\t(UTC)","X-MS-Exchange-CrossTenant-Id":"711e4ccf-2e9b-4bcf-a551-4094005b6194","X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp":"TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194;\n\tIp=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com]","X-MS-Exchange-CrossTenant-FromEntityHeader":"HybridOnPrem","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"BLUPR0701MB2083","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"},"content":"The maximum number of CQs supported is bound to the number\nof connections supported, which differs between RoCE and iWARP.\n\nThis fixes a crash that occurred in iWARP when running 1000 sessions\nusing perftest.\n\nSigned-off-by: Michal Kalderon <Michal.Kalderon@cavium.com>\nSigned-off-by: Ariel Elior <Ariel.Elior@cavium.com>\n---\n drivers/net/ethernet/qlogic/qed/qed_rdma.c | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)","diff":"diff --git a/drivers/net/ethernet/qlogic/qed/qed_rdma.c b/drivers/net/ethernet/qlogic/qed/qed_rdma.c\nindex 4f46f28..c8c4b39 100644\n--- a/drivers/net/ethernet/qlogic/qed/qed_rdma.c\n+++ b/drivers/net/ethernet/qlogic/qed/qed_rdma.c\n@@ -209,11 +209,11 @@ static int qed_rdma_alloc(struct qed_hwfn *p_hwfn,\n \t\tgoto free_pd_map;\n \t}\n \n-\t/* Allocate bitmap for cq's. The maximum number of CQs is bounded to\n-\t * twice the number of QPs.\n+\t/* Allocate bitmap for cq's. The maximum number of CQs is bound to\n+\t * the number of connections we support. (num_qps in iWARP or\n+\t * num_qps/2 in RoCE).\n \t */\n-\trc = qed_rdma_bmap_alloc(p_hwfn, &p_rdma_info->cq_map,\n-\t\t\t\t p_rdma_info->num_qps * 2, \"CQ\");\n+\trc = qed_rdma_bmap_alloc(p_hwfn, &p_rdma_info->cq_map, num_cons, \"CQ\");\n \tif (rc) {\n \t\tDP_VERBOSE(p_hwfn, QED_MSG_RDMA,\n \t\t\t   \"Failed to allocate cq bitmap, rc = %d\\n\", rc);\n@@ -222,10 +222,10 @@ static int qed_rdma_alloc(struct qed_hwfn *p_hwfn,\n \n \t/* Allocate bitmap for toggle bit for cq icids\n \t * We toggle the bit every time we create or resize cq for a given icid.\n-\t * The maximum number of CQs is bounded to  twice the number of QPs.\n+\t * Size needs to equal the size of the cq bmap.\n \t */\n \trc = qed_rdma_bmap_alloc(p_hwfn, &p_rdma_info->toggle_bits,\n-\t\t\t\t p_rdma_info->num_qps * 2, \"Toggle\");\n+\t\t\t\t num_cons, \"Toggle\");\n \tif (rc) {\n \t\tDP_VERBOSE(p_hwfn, QED_MSG_RDMA,\n \t\t\t   \"Failed to allocate toogle bits, rc = %d\\n\", rc);\n","prefixes":["net-next","3/4"]}