{"id":815339,"url":"http://patchwork.ozlabs.org/api/patches/815339/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1505807208-9063-16-git-send-email-eric.auger@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1505807208-9063-16-git-send-email-eric.auger@redhat.com>","list_archive_url":null,"date":"2017-09-19T07:46:47","name":"[RFC,v4,15/16] virtio-iommu: Implement set_page_size_mask","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"49670f70632633b32a0976fa14575a4cb59ebdcd","submitter":{"id":69187,"url":"http://patchwork.ozlabs.org/api/people/69187/?format=json","name":"Eric Auger","email":"eric.auger@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1505807208-9063-16-git-send-email-eric.auger@redhat.com/mbox/","series":[{"id":3796,"url":"http://patchwork.ozlabs.org/api/series/3796/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3796","date":"2017-09-19T07:46:32","name":"VIRTIO-IOMMU device","version":4,"mbox":"http://patchwork.ozlabs.org/series/3796/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/815339/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/815339/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eric.auger@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxFg43QQRz9s82\n\tfor ;\n\tTue, 19 Sep 2017 18:00:47 +1000 (AEST)","from localhost ([::1]:40650 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duDSV-0001FL-6y\n\tfor incoming@patchwork.ozlabs.org; Tue, 19 Sep 2017 04:00:43 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:48470)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duDIZ-0001mq-TV\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 03:50:29 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duDIZ-0001zT-0O\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 03:50:27 -0400","from mx1.redhat.com ([209.132.183.28]:54864)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1duDIU-0001vz-4a; Tue, 19 Sep 2017 03:50:22 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 0D17D85550;\n\tTue, 19 Sep 2017 07:50:21 +0000 (UTC)","from localhost.localdomain.com (ovpn-116-197.ams2.redhat.com\n\t[10.36.116.197])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 81D1F60466;\n\tTue, 19 Sep 2017 07:50:13 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 0D17D85550","From":"Eric Auger ","To":"eric.auger.pro@gmail.com, eric.auger@redhat.com, peter.maydell@linaro.org,\n\talex.williamson@redhat.com, mst@redhat.com, qemu-arm@nongnu.org,\n\tqemu-devel@nongnu.org, jean-philippe.brucker@arm.com","Date":"Tue, 19 Sep 2017 09:46:47 +0200","Message-Id":"<1505807208-9063-16-git-send-email-eric.auger@redhat.com>","In-Reply-To":"<1505807208-9063-1-git-send-email-eric.auger@redhat.com>","References":"<1505807208-9063-1-git-send-email-eric.auger@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tTue, 19 Sep 2017 07:50:21 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [RFC v4 15/16] virtio-iommu: Implement\n\tset_page_size_mask","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"wei@redhat.com, kevin.tian@intel.com, marc.zyngier@arm.com,\n\ttn@semihalf.com, \n\twill.deacon@arm.com, drjones@redhat.com, peterx@redhat.com,\n\tlinuc.decode@gmail.com, bharat.bhushan@nxp.com,\n\tchristoffer.dall@linaro.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"We implement the set_page_size_mask callback to allow the\nvirtio-iommu to be aware of any restrictions on the page size\nmask due to an underlying HW IOMMU.\n\nSigned-off-by: Eric Auger \n---\n hw/virtio/trace-events | 1 +\n hw/virtio/virtio-iommu.c | 16 ++++++++++++++++\n 2 files changed, 17 insertions(+)","diff":"diff --git a/hw/virtio/trace-events b/hw/virtio/trace-events\nindex 9ccfad1..2793604 100644\n--- a/hw/virtio/trace-events\n+++ b/hw/virtio/trace-events\n@@ -48,3 +48,4 @@ virtio_iommu_unmap_inc_interval(uint64_t low, uint64_t high) \"Unmap inc [0x%\"PRI\n virtio_iommu_translate_out(uint64_t virt_addr, uint64_t phys_addr, uint32_t sid) \"0x%\"PRIx64\" -> 0x%\"PRIx64 \" for sid=%d\"\n virtio_iommu_fill_resv_property(uint32_t devid, uint8_t subtype, uint64_t addr, uint64_t size, uint32_t flags, size_t filled) \"dev= %d, subtype=%d addr=0x%\"PRIx64\" size=0x%\"PRIx64\" flags=%d filled=0x%lx\"\n virtio_iommu_fill_none_property(uint32_t devid) \"devid=%d\"\n+virtio_iommu_set_page_size_mask(const char *iommu_mr, uint64_t mask) \"mr=%s page_size_mask=0x%\"PRIx64\ndiff --git a/hw/virtio/virtio-iommu.c b/hw/virtio/virtio-iommu.c\nindex 281b0f8..1873b9a 100644\n--- a/hw/virtio/virtio-iommu.c\n+++ b/hw/virtio/virtio-iommu.c\n@@ -714,6 +714,21 @@ unlock:\n return entry;\n }\n \n+static void virtio_iommu_set_page_size_mask(IOMMUMemoryRegion *mr,\n+ uint64_t page_size_mask)\n+{\n+ IOMMUDevice *sdev = container_of(mr, IOMMUDevice, iommu_mr);\n+ VirtIOIOMMU *s = sdev->viommu;\n+\n+ s->config.page_size_mask &= page_size_mask;\n+ if (!s->config.page_size_mask) {\n+ error_setg(&error_fatal,\n+ \"No compatible page size between guest and host iommus\");\n+ }\n+\n+ trace_virtio_iommu_set_page_size_mask(mr->parent_obj.name, page_size_mask);\n+}\n+\n static void virtio_iommu_get_config(VirtIODevice *vdev, uint8_t *config_data)\n {\n VirtIOIOMMU *dev = VIRTIO_IOMMU(vdev);\n@@ -881,6 +896,7 @@ static void virtio_iommu_memory_region_class_init(ObjectClass *klass,\n IOMMUMemoryRegionClass *imrc = IOMMU_MEMORY_REGION_CLASS(klass);\n \n imrc->translate = virtio_iommu_translate;\n+ imrc->set_page_size_mask = virtio_iommu_set_page_size_mask;\n }\n \n static const TypeInfo virtio_iommu_info = {\n","prefixes":["RFC","v4","15/16"]}