{"id":815321,"url":"http://patchwork.ozlabs.org/api/patches/815321/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1505807208-9063-10-git-send-email-eric.auger@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1505807208-9063-10-git-send-email-eric.auger@redhat.com>","list_archive_url":null,"date":"2017-09-19T07:46:41","name":"[RFC,v4,09/16] virtio-iommu: Implement translate","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"9665b8e0c5466019a64004a074706524012d8342","submitter":{"id":69187,"url":"http://patchwork.ozlabs.org/api/people/69187/?format=json","name":"Eric Auger","email":"eric.auger@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1505807208-9063-10-git-send-email-eric.auger@redhat.com/mbox/","series":[{"id":3796,"url":"http://patchwork.ozlabs.org/api/series/3796/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3796","date":"2017-09-19T07:46:32","name":"VIRTIO-IOMMU device","version":4,"mbox":"http://patchwork.ozlabs.org/series/3796/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/815321/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/815321/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eric.auger@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxFT06SHYz9s7M\n\tfor ;\n\tTue, 19 Sep 2017 17:52:04 +1000 (AEST)","from localhost ([::1]:40610 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duDK7-0002Qd-0n\n\tfor incoming@patchwork.ozlabs.org; Tue, 19 Sep 2017 03:52:03 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:47846)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duDHD-0000Ya-8P\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 03:49:04 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duDH9-0001Di-2s\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 03:49:03 -0400","from mx1.redhat.com ([209.132.183.28]:53166)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1duDH6-0001CS-IL; Tue, 19 Sep 2017 03:48:56 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 6F36C7EA90;\n\tTue, 19 Sep 2017 07:48:55 +0000 (UTC)","from localhost.localdomain.com (ovpn-116-197.ams2.redhat.com\n\t[10.36.116.197])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id E58496134B;\n\tTue, 19 Sep 2017 07:48:31 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 6F36C7EA90","From":"Eric Auger ","To":"eric.auger.pro@gmail.com, eric.auger@redhat.com, peter.maydell@linaro.org,\n\talex.williamson@redhat.com, mst@redhat.com, qemu-arm@nongnu.org,\n\tqemu-devel@nongnu.org, jean-philippe.brucker@arm.com","Date":"Tue, 19 Sep 2017 09:46:41 +0200","Message-Id":"<1505807208-9063-10-git-send-email-eric.auger@redhat.com>","In-Reply-To":"<1505807208-9063-1-git-send-email-eric.auger@redhat.com>","References":"<1505807208-9063-1-git-send-email-eric.auger@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tTue, 19 Sep 2017 07:48:55 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [RFC v4 09/16] virtio-iommu: Implement translate","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"wei@redhat.com, kevin.tian@intel.com, marc.zyngier@arm.com,\n\ttn@semihalf.com, \n\twill.deacon@arm.com, drjones@redhat.com, peterx@redhat.com,\n\tlinuc.decode@gmail.com, bharat.bhushan@nxp.com,\n\tchristoffer.dall@linaro.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"This patch implements the translate callback\n\nSigned-off-by: Eric Auger \n---\n hw/virtio/trace-events | 1 +\n hw/virtio/virtio-iommu.c | 39 +++++++++++++++++++++++++++++++++++++--\n 2 files changed, 38 insertions(+), 2 deletions(-)","diff":"diff --git a/hw/virtio/trace-events b/hw/virtio/trace-events\nindex da298c1..9010fbd 100644\n--- a/hw/virtio/trace-events\n+++ b/hw/virtio/trace-events\n@@ -45,3 +45,4 @@ virtio_iommu_put_as(uint32_t asid) \"Free asid=%d\"\n virtio_iommu_unmap_left_interval(uint64_t low, uint64_t high, uint64_t next_low, uint64_t next_high) \"Unmap left [0x%\"PRIx64\",0x%\"PRIx64\"], new interval=[0x%\"PRIx64\",0x%\"PRIx64\"]\"\n virtio_iommu_unmap_right_interval(uint64_t low, uint64_t high, uint64_t next_low, uint64_t next_high) \"Unmap right [0x%\"PRIx64\",0x%\"PRIx64\"], new interval=[0x%\"PRIx64\",0x%\"PRIx64\"]\"\n virtio_iommu_unmap_inc_interval(uint64_t low, uint64_t high) \"Unmap inc [0x%\"PRIx64\",0x%\"PRIx64\"]\"\n+virtio_iommu_translate_out(uint64_t virt_addr, uint64_t phys_addr, uint32_t sid) \"0x%\"PRIx64\" -> 0x%\"PRIx64 \" for sid=%d\"\ndiff --git a/hw/virtio/virtio-iommu.c b/hw/virtio/virtio-iommu.c\nindex 6f1a7d1..db46a91 100644\n--- a/hw/virtio/virtio-iommu.c\n+++ b/hw/virtio/virtio-iommu.c\n@@ -496,19 +496,54 @@ static IOMMUTLBEntry virtio_iommu_translate(IOMMUMemoryRegion *mr, hwaddr addr,\n IOMMUAccessFlags flag)\n {\n IOMMUDevice *sdev = container_of(mr, IOMMUDevice, iommu_mr);\n+ VirtIOIOMMU *s = sdev->viommu;\n uint32_t sid;\n+ viommu_dev *dev;\n+ viommu_mapping *mapping;\n+ viommu_interval interval;\n+\n+ interval.low = addr;\n+ interval.high = addr + 1;\n \n IOMMUTLBEntry entry = {\n .target_as = &address_space_memory,\n .iova = addr,\n .translated_addr = addr,\n- .addr_mask = ~(hwaddr)0,\n- .perm = IOMMU_NONE,\n+ .addr_mask = (1 << ctz32(s->config.page_size_mask)) - 1,\n+ .perm = flag,\n };\n \n sid = virtio_iommu_get_sid(sdev);\n \n trace_virtio_iommu_translate(mr->parent_obj.name, sid, addr, flag);\n+ qemu_mutex_lock(&s->mutex);\n+\n+ dev = g_tree_lookup(s->devices, GUINT_TO_POINTER(sid));\n+ if (!dev) {\n+ /* device cannot be attached to another as */\n+ printf(\"%s sid=%d is not known!!\\n\", __func__, sid);\n+ goto unlock;\n+ }\n+\n+ mapping = g_tree_lookup(dev->as->mappings, (gpointer)(&interval));\n+ if (!mapping) {\n+ printf(\"%s no mapping for 0x%\"PRIx64\" for sid=%d\\n\", __func__,\n+ addr, sid);\n+ goto unlock;\n+ }\n+\n+ if (((flag & IOMMU_RO) && !(mapping->flags & VIRTIO_IOMMU_MAP_F_READ)) ||\n+ ((flag & IOMMU_WO) && !(mapping->flags & VIRTIO_IOMMU_MAP_F_WRITE))) {\n+ error_report(\"Permission error on 0x%\"PRIx64\"(%d): allowed=%d\",\n+ addr, flag, mapping->flags);\n+ entry.perm = IOMMU_NONE;\n+ goto unlock;\n+ }\n+ entry.translated_addr = addr - mapping->virt_addr + mapping->phys_addr,\n+ trace_virtio_iommu_translate_out(addr, entry.translated_addr, sid);\n+\n+unlock:\n+ qemu_mutex_unlock(&s->mutex);\n return entry;\n }\n \n","prefixes":["RFC","v4","09/16"]}