{"id":815250,"url":"http://patchwork.ozlabs.org/api/patches/815250/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20170919021947.8971-5-f.fainelli@gmail.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170919021947.8971-5-f.fainelli@gmail.com>","list_archive_url":null,"date":"2017-09-19T02:19:39","name":"[net-next,v2,04/12] net: dsa: bcm_sf2: Defer port enabling to calling port_enable","commit_ref":null,"pull_url":null,"state":"superseded","archived":true,"hash":"6070678fd20f09d819f4d89cbc2b16875ed3a7a6","submitter":{"id":2800,"url":"http://patchwork.ozlabs.org/api/people/2800/?format=json","name":"Florian Fainelli","email":"f.fainelli@gmail.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170919021947.8971-5-f.fainelli@gmail.com/mbox/","series":[{"id":3767,"url":"http://patchwork.ozlabs.org/api/series/3767/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=3767","date":"2017-09-19T02:19:35","name":"net: dsa: b53/bcm_sf2 cleanups","version":2,"mbox":"http://patchwork.ozlabs.org/series/3767/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/815250/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/815250/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"nxBVeVap\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xx6840kvGz9s4s\n\tfor ;\n\tTue, 19 Sep 2017 12:21:56 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751186AbdISCVr (ORCPT );\n\tMon, 18 Sep 2017 22:21:47 -0400","from mail-wr0-f194.google.com ([209.85.128.194]:37300 \"EHLO\n\tmail-wr0-f194.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750982AbdISCUG (ORCPT\n\t); Mon, 18 Sep 2017 22:20:06 -0400","by mail-wr0-f194.google.com with SMTP id u48so1363245wrf.4\n\tfor ; Mon, 18 Sep 2017 19:20:05 -0700 (PDT)","from fainelli-desktop.broadcom.com ([192.19.255.250])\n\tby smtp.gmail.com with ESMTPSA id\n\tq19sm9332458wrb.17.2017.09.18.19.20.02\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 18 Sep 2017 19:20:03 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=tvrISfpzigYJ0EjxY1DQzoyWhUBwOUa/uMGHPfEJwqw=;\n\tb=nxBVeVapH4ESm4DEMSYThZEUDUwIN4ezPHmA3zZD8FWx0mmicNIN6QdY0lhkDDHF8S\n\tvrGtBNv6SC9zM1pL9z4k0RzdVNf0Plngnwtfst6StBW/+ELgiKTi/cuVUKyTlMdd1pM6\n\t05UT+zejPJ7iuebRlud+bkMbcxp7kn/oohfKziE7bf+U/o8p6q+Pa2TKeW9mN0bg0ynD\n\t1DzMyq/VEnfw6CRJN+9ue8RZbOvscRjKknspDX9WrYP2ik93ZIoxB5cZxfviInGnr+57\n\tWn15VB2K0u6Pr85ARGBBeN2x4rghF3eBmQrqlabA5frOeX2TUk9fhR26RGlpnYctaSXZ\n\tBjEw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=tvrISfpzigYJ0EjxY1DQzoyWhUBwOUa/uMGHPfEJwqw=;\n\tb=WhYXp3kAsGIQk3DUQbIMc4O/1JARYErPAIxig0l0vUpi3R51AHlB8/8dZ3UDLLvRBi\n\t3WQBl95e+PL3Gt52+uYIGfHV1Q26o87bZ6904Mx5l9V343v8Z9SwOrdoSZ/NJOvKOV0l\n\tlMFCW9kXPRd8y3uXp5RLxBY3R5s2d+pWqX0uhnk28mVcxsdg1Ld4uTQMLc1YosXre7hC\n\tis/oAyn0+kOabFobntr5XtS1X1R8Tp5HHE6NR4GKEWIUlIqgLFNtqLweGwGEchmvQ/+i\n\tptHTPu95a+xWFK3FsyHn1aZSy/BBXfTJJze1Ju16UY56A7brr10RB2Gdn0V+sShZm+GV\n\t4QlQ==","X-Gm-Message-State":"AHPjjUhyKKF1qqhQUvbqi3xepe8UXxDxU+zAcI0tS9o8CtQSKS/hFZHs\n\ttWdLrJ6jTybA7CklZ+U=","X-Google-Smtp-Source":"ADKCNb5e+K9FU3E3PXdi5e66W9KdN9Mc4eAWR3dvirrgHshgv+4cXegxS/yRxwRQjE9PZik0WXYo8A==","X-Received":"by 10.223.150.171 with SMTP id\n\tu40mr30880436wrb.201.1505787604731; \n\tMon, 18 Sep 2017 19:20:04 -0700 (PDT)","From":"Florian Fainelli ","To":"netdev@vger.kernel.org","Cc":"andrew@lunn.ch, vivien.didelot@savoirfairelinux.com,\n\tdavem@davemloft.net, Florian Fainelli ","Subject":"[PATCH net-next v2 04/12] net: dsa: bcm_sf2: Defer port enabling to\n\tcalling port_enable","Date":"Mon, 18 Sep 2017 19:19:39 -0700","Message-Id":"<20170919021947.8971-5-f.fainelli@gmail.com>","X-Mailer":"git-send-email 2.9.3","In-Reply-To":"<20170919021947.8971-1-f.fainelli@gmail.com>","References":"<20170919021947.8971-1-f.fainelli@gmail.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"There is no need to configure the enabled ports once in bcm_sf2_sw_setup() and\nthen a second time around when dsa_switch_ops::port_enable is called, just do\nit when port_enable is called which is better in terms of power consumption and\ncorrectness.\n\nReviewed-by: Vivien Didelot \nSigned-off-by: Florian Fainelli \n---\n drivers/net/dsa/bcm_sf2.c | 9 +++------\n 1 file changed, 3 insertions(+), 6 deletions(-)","diff":"diff --git a/drivers/net/dsa/bcm_sf2.c b/drivers/net/dsa/bcm_sf2.c\nindex d7b53d53c116..8acbd17bc1fd 100644\n--- a/drivers/net/dsa/bcm_sf2.c\n+++ b/drivers/net/dsa/bcm_sf2.c\n@@ -890,14 +890,11 @@ static int bcm_sf2_sw_setup(struct dsa_switch *ds)\n \tstruct bcm_sf2_priv *priv = bcm_sf2_to_priv(ds);\n \tunsigned int port;\n \n-\t/* Enable all valid ports and disable those unused */\n+\t/* Disable unused ports and configure IMP port */\n \tfor (port = 0; port < priv->hw_params.num_ports; port++) {\n-\t\t/* IMP port receives special treatment */\n-\t\tif ((1 << port) & ds->enabled_port_mask)\n-\t\t\tbcm_sf2_port_setup(ds, port, NULL);\n-\t\telse if (dsa_is_cpu_port(ds, port))\n+\t\tif (dsa_is_cpu_port(ds, port))\n \t\t\tbcm_sf2_imp_setup(ds, port);\n-\t\telse\n+\t\telse if (!((1 << port) & ds->enabled_port_mask))\n \t\t\tbcm_sf2_port_disable(ds, port, NULL);\n \t}\n \n","prefixes":["net-next","v2","04/12"]}